Page MenuHomePhabricator

Plans: Phriction modern "v3" APIs, Drafts
Open, NormalPublic

Description

See PHI840. This may unravel somewhat, but the immediate path forward looks like adding draft phases and a publish operation.


This probably mostly revolves around an EditEngine upgrade. Other EditEngine stuff:

  • See T4274. This may be trivial after EditEngine.
  • See T5811. The modern draft stuff has better behavior.
  • See T9102, maybe. I think just declining this is also reasonable.
  • See T3963. EditEngine forms can roughly approximate this.
  • See T10859. Bundling additional data in the preview would be nice.

See T5410. I'm likely to just decline this.

History might need to become a real object?

  • See T12193. Notes could be comments? See also T1894. But we can pull mentions out of them, at a minimum.

See T4815. This is a minor but reasonable UI improvement.


Done

See PHI366. An instance wants more reasonable API access to Phriction. Phriction has weird v2 APIs and should have modern v3 APIs.

See T11163. I'll likely decline this.

See T10969. This is just a bug.

See T5941. Requires ferret or ngrams but those seem reasonable.

See T12344. This is "wrong" but we can probably make this work (maybe?) since "%" isn't a valid slug character anyway.

The contentID property on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road. (This was resolved by swapping everything to PHIDs.)

Revisions and Commits

rPHU libphutil
D19111
rP Phabricator
D19668
D19664
D19663
D19662
D19661
D19660
D19659
D19627
D19626
D19625
D19622
D19621
D19620
D19619
D19618
D19617
D19616
D19125
D19115
D19114
D19113
D19112
D19110
D19109
D19108
D19107
D19106
D19105
D19103
D19100
D19099
D19098
D19097
D19096
D19095
D19094
D19093
D19092

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ftdysa added a subscriber: ftdysa.Feb 15 2018, 1:43 PM
epriestley updated the task description. (Show Details)Feb 16 2018, 12:49 AM
epriestley moved this task from Backlog to Future on the Plans board.Mar 5 2018, 3:03 PM

The corresponding support ticket was likely addressed by these changes. The remaining stuff here is still planned, but probably not moving forward any time soon.

contentID on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road.

D19619 fixes this, but now we have a different problem: if you create a new document and want the new document to be a draft, we have no way to represent that. I'm just going to not support that for now and figure it out later if there's interest in it.

epriestley moved this task from Future to Soon on the Plans board.Sep 5 2018, 1:32 PM
epriestley renamed this task from Plans: Phriction modern "v3" APIs to Plans: Phriction modern "v3" APIs, Drafts.Sep 5 2018, 2:35 PM
epriestley updated the task description. (Show Details)