Page MenuHomePhabricator
Create Task
Maniphest T13077

Plans: Phriction modern "v3" APIs, Drafts
Open, NormalPublic
Actions

Description

See PHI840. This may unravel somewhat, but the immediate path forward looks like adding draft phases and a publish operation.

This probably mostly revolves around an EditEngine upgrade. Other EditEngine stuff:

  • See T4274. This may be trivial after EditEngine.
  • See T5811. The modern draft stuff has better behavior.
  • See T9102, maybe. I think just declining this is also reasonable.
  • See T3963. EditEngine forms can roughly approximate this.
  • See T10859. Bundling additional data in the preview would be nice.

See T5410. I'm likely to just decline this.

History might need to become a real object?

  • See T12193. Notes could be comments? See also T1894. But we can pull mentions out of them, at a minimum.

See T4815. This is a minor but reasonable UI improvement.

Done

See PHI366. An instance wants more reasonable API access to Phriction. Phriction has weird v2 APIs and should have modern v3 APIs.

See T11163. I'll likely decline this.

See T10969. This is just a bug.

See T5941. Requires ferret or ngrams but those seem reasonable.

See T12344. This is "wrong" but we can probably make this work (maybe?) since "%" isn't a valid slug character anyway.

The contentID property on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road. (This was resolved by swapping everything to PHIDs.)

Revisions and Commits

rPHU libphutil
D19111rPHU9f49d4ed21f1 Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses
rP Phabricator
D19668rP0abf29765e05 Make Phriction diff-of-changes view draft-aware and clarify some language
D19664rP0089ef4b60e3 Don't show Phriction draft edit events in feed
D19663rPb6ba75d991df Add a Phriction hint when a draft exists, and fix some draft editing bugs
D19662rP550028a8825a Allow Phriction document edits to be saved as drafts
D19661rP152e7713eb06 Remove obsolete, nonfunctional draft auto-saving in Phriction
D19660rPe19c555913b1 Support (basic) commenting on Phriction documents
D19659rP2379c21fbbd1 Give Phriction documents a normal timeline
D19627rP26d9ee456f30 Hide the new Phriction "Publish" operation behind the "Prototype" toggle
D19626rP18e8d9a45265 Make the Phriction "History" view more aware of drafts
D19625rP3b1294cf4599 Store Phriction max version on Document, improve editing rules for editing…
D19622rP876638e42895 Add a UI element for navigating between versions of a Phriction document
D19621rP349686319e30 Allow the published version of a Phriction document to differ from the most…
D19620rP50f4adef64cf Remove on-object mailkeys from Phriction
D19619rP64cee4a902da Move Phriction internal document/content references from IDs to PHIDs
D19618rP04f8270a7466 Remove some unusual UI policy hints in Phriction
D19617rP4afb6446d97b Allow DocumentView to render with a curtain, and make Phriction use a curtain
D19616rPfd0da4c41f82 Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
D19125rP4cb62ca0d6ae Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths"
D19115rPcb2f7106069b Provide the document content as a context object when rendering Phriction…
D19114rP66a7ca49b20c Fix incorrect context extraction for relative Phriction links on Phriction pages
D19113rPdb3ef4021a5d Freeze the "phriction.info" Conduit API method
D19112rP6d3177a3bf29 Allow "phriction.document.search" to query by path
D19110rP8796a6036ed1 Let users escape more easily from the autosuggester after typing "[" or "("
D19109rP0202c36b62d7 Suggest Phurl URLs on "((..." in Remarkup text areas
D19108rP8771b7d5c40c Add autocomplete for Phriction documents on "[[ ..." in Remarkup
D19107rPf82206a4d1af Add a rough Quick Search datasource for Phriction documents
D19106rPb8bb4d3ad590 Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/"…
D19105rPbfdc9411f705 Provide context objects for remarkup mail rendering, fixing Phriction relative…
D19103rP45403b162aa5 Flesh out "phriction.document.search" slightly and provide page text for…
D19100rP143350fdba48 Give Phriction documents modern string status constants instead of numeric…
D19099rPc1056f6dab53 Partially clean up Phriction document status constants; introduce "phriction.
D19098rP48eb82f229be Freeze "phriction.history" in favor of "phriction.content.search"
D19097rP8101bf74e9ce Introduce a "phriction.content.search" API method to replace "phriction.history"
D19096rPa965d8d6ae5a Make PhrictionContent "description" non-nullable
D19095rPf742d00c2894 Mostly use PhrictionContentQuery to load PhrictionContent objects
D19094rP9404e2b3d425 Implement PolicyInterface, ExtendedPolicyInterface, and DestructibleInterface…
D19093rPb2c829f2743b Move PhrictionContent from RemarkupInterface (deprecated) to PHUIRemarkupView
D19092rPe492c717c657 Give PhrictionContent objects (older versions of wiki pages) legitimate PHIDs

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley added a revision: D19095: Mostly use PhrictionContentQuery to load PhrictionContent objects.Feb 15 2018, 1:33 PM
ftdysa added a subscriber: ftdysa.Feb 15 2018, 1:43 PM
epriestley added a revision: D19096: Make PhrictionContent "description" non-nullable.Feb 15 2018, 1:50 PM
epriestley added a revision: D19097: Introduce a "phriction.content.search" API method to replace "phriction.history".Feb 15 2018, 2:29 PM
epriestley added a revision: D19098: Freeze "phriction.history" in favor of "phriction.content.search".Feb 15 2018, 4:31 PM
epriestley added a revision: D19099: Partially clean up Phriction document status constants; introduce "phriction.document.search".Feb 15 2018, 5:49 PM
epriestley added a revision: D19100: Give Phriction documents modern string status constants instead of numeric constants.Feb 15 2018, 8:56 PM
epriestley updated the task description. (Show Details)Feb 16 2018, 12:49 AM
epriestley added a revision: D19103: Flesh out "phriction.document.search" slightly and provide page text for content/documents.Feb 16 2018, 1:20 AM
epriestley added a commit: rPe492c717c657: Give PhrictionContent objects (older versions of wiki pages) legitimate PHIDs.Feb 16 2018, 1:39 AM
epriestley added a commit: rPb2c829f2743b: Move PhrictionContent from RemarkupInterface (deprecated) to PHUIRemarkupView.
epriestley added a commit: rP9404e2b3d425: Implement PolicyInterface, ExtendedPolicyInterface, and DestructibleInterface….Feb 16 2018, 1:44 AM
epriestley added a commit: rPf742d00c2894: Mostly use PhrictionContentQuery to load PhrictionContent objects.
epriestley added a commit: rPa965d8d6ae5a: Make PhrictionContent "description" non-nullable.Feb 16 2018, 1:55 AM
epriestley added a commit: rP8101bf74e9ce: Introduce a "phriction.content.search" API method to replace "phriction.history".Feb 16 2018, 2:13 AM
epriestley added a commit: rP48eb82f229be: Freeze "phriction.history" in favor of "phriction.content.search".Feb 16 2018, 2:15 AM
epriestley added a commit: rPc1056f6dab53: Partially clean up Phriction document status constants; introduce "phriction..Feb 16 2018, 2:19 AM
epriestley added a commit: rP143350fdba48: Give Phriction documents modern string status constants instead of numeric….Feb 16 2018, 2:23 AM
epriestley added a commit: rP45403b162aa5: Flesh out "phriction.document.search" slightly and provide page text for….
epriestley added a revision: D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email.Feb 16 2018, 1:18 PM
epriestley added a revision: D19106: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/" Phriction document.Feb 16 2018, 2:44 PM
epriestley added a revision: D19107: Add a rough Quick Search datasource for Phriction documents.Feb 16 2018, 3:50 PM
epriestley added a revision: D19108: Add autocomplete for Phriction documents on "[[ ..." in Remarkup.Feb 16 2018, 5:26 PM
epriestley added a revision: D19109: Suggest Phurl URLs on "((..." in Remarkup text areas.Feb 16 2018, 5:42 PM
epriestley added a commit: rPbfdc9411f705: Provide context objects for remarkup mail rendering, fixing Phriction relative….Feb 16 2018, 5:55 PM
epriestley added a commit: rPb8bb4d3ad590: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/"….
epriestley added a commit: rPf82206a4d1af: Add a rough Quick Search datasource for Phriction documents.
epriestley added a commit: rP8771b7d5c40c: Add autocomplete for Phriction documents on "[[ ..." in Remarkup.
epriestley added a commit: rP0202c36b62d7: Suggest Phurl URLs on "((..." in Remarkup text areas.
epriestley added a revision: D19110: Let users escape more easily from the autosuggester after typing "[" or "(".Feb 16 2018, 7:01 PM
epriestley added a commit: rP8796a6036ed1: Let users escape more easily from the autosuggester after typing "[" or "(".Feb 16 2018, 7:02 PM
epriestley added a revision: D19111: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.Feb 16 2018, 7:05 PM
epriestley added a commit: rPHU9f49d4ed21f1: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.Feb 16 2018, 7:08 PM
epriestley added a revision: D19112: Allow "phriction.document.search" to query by path.Feb 16 2018, 7:37 PM
epriestley added a commit: rP6d3177a3bf29: Allow "phriction.document.search" to query by path.Feb 16 2018, 7:40 PM
epriestley added a revision: D19113: Freeze the "phriction.info" Conduit API method.Feb 16 2018, 7:45 PM
epriestley added a commit: rPdb3ef4021a5d: Freeze the "phriction.info" Conduit API method.Feb 16 2018, 8:14 PM
epriestley added a revision: D19114: Fix incorrect context extraction for relative Phriction links on Phriction pages.Feb 16 2018, 8:32 PM
epriestley added a commit: rP66a7ca49b20c: Fix incorrect context extraction for relative Phriction links on Phriction pages.Feb 16 2018, 8:33 PM
epriestley added a revision: D19115: Provide the document content as a context object when rendering Phriction documents.Feb 16 2018, 8:41 PM
epriestley added a commit: rPcb2f7106069b: Provide the document content as a context object when rendering Phriction….Feb 16 2018, 8:42 PM
epriestley mentioned this in 2018 Week 7 (Mid February).Feb 16 2018, 10:04 PM
• GoogleLegacy added a subscriber: • GoogleLegacy.Feb 19 2018, 4:38 AM
epriestley mentioned this in T13090: Plans: 2018 Week 8 Bonus Content.Feb 22 2018, 5:55 PM
epriestley added a revision: D19125: Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths".Feb 22 2018, 6:55 PM
epriestley added a commit: rP4cb62ca0d6ae: Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths".Feb 22 2018, 8:49 PM
epriestley added a project: Plans.Feb 25 2018, 3:28 PM
epriestley moved this task from Backlog to Future on the Plans board.Mar 5 2018, 3:03 PM

The corresponding support ticket was likely addressed by these changes. The remaining stuff here is still planned, but probably not moving forward any time soon.

Herald added a subscriber: faulconbridge. · View Herald TranscriptMar 5 2018, 3:03 PM
• pasik added a subscriber: • pasik.May 12 2018, 1:51 PM
epriestley mentioned this in T8970: Ability to draft/archive Phriction documents.Aug 27 2018, 9:43 PM
epriestley updated the task description. (Show Details)
epriestley mentioned this in T12793: Unable to move Phriction documents.Aug 27 2018, 9:47 PM
epriestley updated the task description. (Show Details)
epriestley added a revision: D19616: Rename "PHUIDocumentViewPro" to "PHUIDocumentView".Aug 28 2018, 9:00 PM
epriestley added a revision: D19617: Allow DocumentView to render with a curtain, and make Phriction use a curtain.Aug 28 2018, 9:51 PM
epriestley added a commit: rPfd0da4c41f82: Rename "PHUIDocumentViewPro" to "PHUIDocumentView".Aug 28 2018, 9:53 PM
epriestley added a commit: rP4afb6446d97b: Allow DocumentView to render with a curtain, and make Phriction use a curtain.Aug 28 2018, 9:58 PM
epriestley added a revision: D19618: Remove some unusual UI policy hints in Phriction.Aug 28 2018, 10:14 PM
epriestley added a commit: rP04f8270a7466: Remove some unusual UI policy hints in Phriction.Aug 29 2018, 2:32 PM
epriestley added a revision: D19619: Move Phriction internal document/content references from IDs to PHIDs.Aug 29 2018, 3:18 PM
epriestley added a revision: D19620: Remove on-object mailkeys from Phriction.Aug 29 2018, 3:29 PM
epriestley added a revision: D19621: Allow the published version of a Phriction document to differ from the most recent version.Aug 29 2018, 3:47 PM
epriestley added a comment.Aug 29 2018, 4:04 PM

contentID on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road.

D19619 fixes this, but now we have a different problem: if you create a new document and want the new document to be a draft, we have no way to represent that. I'm just going to not support that for now and figure it out later if there's interest in it.

epriestley added a revision: D19622: Add a UI element for navigating between versions of a Phriction document.Aug 29 2018, 4:34 PM
epriestley added a commit: rP64cee4a902da: Move Phriction internal document/content references from IDs to PHIDs.Aug 29 2018, 8:41 PM
epriestley added a commit: rP50f4adef64cf: Remove on-object mailkeys from Phriction.
epriestley added a commit: rP349686319e30: Allow the published version of a Phriction document to differ from the most….Aug 29 2018, 8:47 PM
epriestley added a commit: rP876638e42895: Add a UI element for navigating between versions of a Phriction document.
epriestley mentioned this in D19624: Work around an issue in MariaDB where dropping a column from a UNIQUE KEY fails.Aug 30 2018, 1:18 PM
epriestley mentioned this in rP0a77b0e53e7f: Work around an issue in MariaDB where dropping a column from a UNIQUE KEY fails.Aug 30 2018, 1:25 PM
epriestley added a revision: D19625: Store Phriction max version on Document, improve editing rules for editing documents with drafts.Aug 30 2018, 5:09 PM
epriestley added a commit: rP3b1294cf4599: Store Phriction max version on Document, improve editing rules for editing….Aug 30 2018, 5:12 PM
epriestley added a revision: D19626: Make the Phriction "History" view more aware of drafts.Aug 30 2018, 5:34 PM
epriestley added a commit: rP18e8d9a45265: Make the Phriction "History" view more aware of drafts.Aug 30 2018, 5:37 PM
epriestley added a revision: D19627: Hide the new Phriction "Publish" operation behind the "Prototype" toggle.Aug 31 2018, 5:08 PM
epriestley added a commit: rP26d9ee456f30: Hide the new Phriction "Publish" operation behind the "Prototype" toggle.Aug 31 2018, 5:30 PM
epriestley moved this task from Future to Soon on the Plans board.Sep 5 2018, 1:32 PM
epriestley renamed this task from Plans: Phriction modern "v3" APIs to Plans: Phriction modern "v3" APIs, Drafts.Sep 5 2018, 2:35 PM
epriestley updated the task description. (Show Details)
epriestley added a revision: D19659: Give Phriction documents a normal timeline.Sep 11 2018, 3:15 PM
epriestley added a revision: D19660: Support (basic) commenting on Phriction documents.Sep 11 2018, 3:40 PM
epriestley added a revision: D19661: Remove obsolete, nonfunctional draft auto-saving in Phriction.Sep 11 2018, 4:39 PM
epriestley added a revision: D19662: Allow Phriction document edits to be saved as drafts.Sep 11 2018, 5:07 PM
epriestley added a revision: D19663: Add a Phriction hint when a draft exists, and fix some draft editing bugs.Sep 11 2018, 5:28 PM
epriestley added a commit: rP2379c21fbbd1: Give Phriction documents a normal timeline.Sep 11 2018, 8:32 PM
epriestley added a revision: D19664: Don't show Phriction draft edit events in feed.Sep 11 2018, 8:39 PM
amckinley added a subscriber: amckinley.Sep 12 2018, 7:10 PM
amckinley mentioned this in D19663: Add a Phriction hint when a draft exists, and fix some draft editing bugs.Sep 12 2018, 7:21 PM
epriestley added a commit: rPe19c555913b1: Support (basic) commenting on Phriction documents.Sep 12 2018, 8:21 PM
epriestley added a commit: rP152e7713eb06: Remove obsolete, nonfunctional draft auto-saving in Phriction.
epriestley added a commit: rP550028a8825a: Allow Phriction document edits to be saved as drafts.Sep 12 2018, 8:30 PM
epriestley added a commit: rPb6ba75d991df: Add a Phriction hint when a draft exists, and fix some draft editing bugs.Sep 12 2018, 8:45 PM
epriestley added a commit: rP0089ef4b60e3: Don't show Phriction draft edit events in feed.Sep 12 2018, 8:56 PM
epriestley added a revision: D19668: Make Phriction diff-of-changes view draft-aware and clarify some language.Sep 13 2018, 3:33 PM
epriestley added a commit: rP0abf29765e05: Make Phriction diff-of-changes view draft-aware and clarify some language.Sep 13 2018, 9:12 PM
Phabricator · Built by Phacility