Page MenuHomePhabricator

brhodes (Brandon Rhodes)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 13 2018, 6:25 PM (319 w, 2 d)
Availability
Available

Recent Activity

Mar 14 2019

brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I was imagining keeping the Message-ID, while having the first email also include the same value for In-Reply-To — I completely agree that removing the Message-ID would not work out. If the first email always included both fields, thus referencing itself as a reply to itself, I suppose there could be MUAs that would go into infinite loops. So, maybe too risky.

Mar 14 2019, 3:07 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

The only effect I can imagine of always setting the In-Reply-To would be to encourage threading where it's not currently happening, so removing the behavior and deleting all these little methods would be very attractive to me if it were my project. :)

Mar 14 2019, 2:46 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

It worked!

Mar 14 2019, 12:24 PM · Mail

Mar 13 2019

brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

I merely wanted to have both possible resolutions on the table, one of which was to give the first message the ID later used In-Reply-To.

Mar 13 2019, 5:03 PM · Mail
brhodes added a comment to T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.

How old were things before the upgrade? (Roughly: less or more than about a year old?)

Mar 13 2019, 5:02 PM · Mail
brhodes created T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer.
Mar 13 2019, 4:19 PM · Mail
brhodes abandoned D19079: Cut the middle, not bottom, of a big traceback.
Mar 13 2019, 4:07 PM

Feb 14 2018

brhodes planned changes to D19079: Cut the middle, not bottom, of a big traceback.

many megabytes or gigabytes … In some cases at Facebook, this command produced gigabytes of output.

Feb 14 2018, 9:44 PM
brhodes added a comment to D19079: Cut the middle, not bottom, of a big traceback.

My first response should be to step back and ask for a bit of context. Why is any truncation occurring here? My real preference would be to display the entire error output of the commands run, and if users dislike the verbosity, then they can dial back how much information is returned on an error or in the case of a crash. If a tool does decide that it needs, say, 4k of text to explain to the user what happened, then my preference would be that arc doesn't try to second-guess the tool, and simply prints all 4k of text.

Feb 14 2018, 5:34 PM
brhodes requested review of D19079: Cut the middle, not bottom, of a big traceback.
Feb 14 2018, 1:58 AM