Page MenuHomePhabricator
Feed All Stories

Feb 16 2018

epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 8:41 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Restricted Differential Revision.
Feb 16 2018, 8:32 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:45 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:37 PM · Plans, Phriction
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

D19111 doesn't fix this in the general case, but should produce the desired behavior for most inputs such that the input is in the form [x](y) and y is the URI of a Wikipedia article.

Feb 16 2018, 7:07 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

The intent isn't unambiguous in the general case, consider: Blah blah (see also [x](y)).

Feb 16 2018, 7:06 PM · Remarkup, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:05 PM · Plans, Phriction
epriestley added a revision to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: Unknown Object (Differential Revision).
Feb 16 2018, 7:05 PM · Remarkup, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:01 PM · Plans, Phriction
epriestley merged task T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Remarkup
epriestley merged T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Ah thanks!

Feb 16 2018, 6:23 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

The non-bold ones also open in a new tab.

Feb 16 2018, 6:20 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Oh! Yes. Sort of.

Feb 16 2018, 6:17 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Just curious, but is the bold effect intentional in the "No Encoding Relative" scenario?

Feb 16 2018, 5:57 PM · Phriction, Remarkup, Bug Report
epriestley closed T5941: Show Phriction Pages in Search Typeahead as Resolved by committing Restricted Diffusion Commit.
Feb 16 2018, 5:56 PM · Phriction
epriestley closed T12344: Relative links to Phriction pages misinterprets URL-encoded characters as Resolved by committing Restricted Diffusion Commit.
Feb 16 2018, 5:55 PM · Phriction, Remarkup, Bug Report
epriestley closed T10969: Incorrect Phriction link in email as Resolved by committing Restricted Diffusion Commit.
Feb 16 2018, 5:55 PM · Phriction, Bug Report
epriestley added a revision to T12241: Make it easier to find objects while in remarkup box: Unknown Object (Differential Revision).
Feb 16 2018, 5:42 PM · Phurl, Remarkup, Feature Request
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 5:42 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 5:26 PM · Plans, Phriction
epriestley added a revision to T5941: Show Phriction Pages in Search Typeahead: Unknown Object (Differential Revision).
Feb 16 2018, 3:50 PM · Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 3:50 PM · Plans, Phriction
epriestley closed T13085: Test Task for Self Mail + Must Encrypt as Invalid.

This doesn't look like a bug in Phabricator; the reporting user is likely discussing client-side mail filtering rules which, by design, can never work against "Must Encrypt" mail.

Feb 16 2018, 2:59 PM · Must Encrypt Mail
epriestley added a comment to T13085: Test Task for Self Mail + Must Encrypt.

Comment 3: Self mail on again.

Feb 16 2018, 2:51 PM · Must Encrypt Mail
epriestley added a comment to T13085: Test Task for Self Mail + Must Encrypt.

Comment 2: Self mail off.

Feb 16 2018, 2:51 PM · Must Encrypt Mail
epriestley added a comment to T13085: Test Task for Self Mail + Must Encrypt.

Comment 1: Self mail on.

Feb 16 2018, 2:50 PM · Must Encrypt Mail
epriestley created T13085: Test Task for Self Mail + Must Encrypt.
Feb 16 2018, 2:50 PM · Must Encrypt Mail
mcorteel added a comment to T8824: Allow relative URLs in custom fields of type "link".

It would be perfect if the syntax supported in remarkup links could be used, which means that for @swisspol's example, projects/phabricator_transition/ would translate to https://temp.phacility.com/w/projects/phabricator_transition/.
And it would be even more awesome if the behavior of the displayed link in the "view" page could be the same, which means that in this case, it wouldn't display the link but the name of the Phriction page!

Feb 16 2018, 2:47 PM · Custom Fields
epriestley added a revision to T12344: Relative links to Phriction pages misinterprets URL-encoded characters: Unknown Object (Differential Revision).
Feb 16 2018, 2:44 PM · Phriction, Remarkup, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 2:44 PM · Plans, Phriction
epriestley added a comment to T13084: Phriction page links using URL encoding can be retargeted without editing.

A similar "attack" is to send a link to two destinations based on the viewer:

Feb 16 2018, 2:41 PM · Phriction, Security
epriestley closed T13084: Phriction page links using URL encoding can be retargeted without editing as Wontfix.
Feb 16 2018, 2:23 PM · Phriction, Security
mcorteel awarded T8824: Allow relative URLs in custom fields of type "link" a Like token.
Feb 16 2018, 1:56 PM · Custom Fields
epriestley added a revision to T10969: Incorrect Phriction link in email: Unknown Object (Differential Revision).
Feb 16 2018, 1:18 PM · Phriction, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 1:18 PM · Plans, Phriction
epriestley closed T11163: Speed up wiki documents creation as Wontfix.

We haven't seen other interest in this and the use case feels a little unusual (I suspect 15-20% empty documents is very unusual) so I don't plan to implement it at this time.

Feb 16 2018, 12:48 PM · Phriction, Feature Request
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

I'll follow up with more details on what was accessed once we conclude our response.

Feb 16 2018, 2:33 AM · Phacility
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 1:20 AM · Plans, Phriction
epriestley updated the task description for T13077: Plans: Phriction modern "v3" APIs, Drafts.
Feb 16 2018, 12:49 AM · Plans, Phriction
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Restricted Differential Revision.
Feb 16 2018, 12:22 AM · Plans, Drydock

Feb 15 2018

epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 15 2018, 11:39 PM · Plans, Drydock
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 8:56 PM · Plans, Phriction
epriestley added projects to T13083: Plans: Portals and Facts: Dashboards, Facts.
Feb 15 2018, 8:52 PM · Plans, Facts, Dashboards
epriestley triaged T13083: Plans: Portals and Facts as Normal priority.
Feb 15 2018, 8:52 PM · Plans, Facts, Dashboards
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 5:49 PM · Plans, Phriction
epriestley added a comment to T12845: Convert remaining ancient configuration type classes to modern modular type classes.

See PHI372 -- setting user.custom-field-definitions (or, probably, any similar config) to a string will pass validation but then fatal in use.

Feb 15 2018, 5:15 PM · Infrastructure, Config
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Feb 15 2018, 4:56 PM · Quicksand
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 4:31 PM · Plans, Phriction
epriestley added a comment to T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags.

No. Mail stamps are not intended to answer "Why am I receiving this mail?" in the general case (which lives in T9412 now, I think).

Feb 15 2018, 4:13 PM · Mail
nemobis added a comment to T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags.

Will stamps be applied for all email notifications and reasons for the recipient to receive them, so as to fix T6297: Maniphest email notification doesn't say why I'm receiving it?

Feb 15 2018, 3:38 PM · Mail
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 2:29 PM · Plans, Phriction
epriestley triaged T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title as Low priority.
Feb 15 2018, 2:02 PM · Transactions, Mail
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 1:50 PM · Plans, Phriction
epriestley added a revision to T6203: Adjust nullability of various questionable columns: Unknown Object (Differential Revision).
Feb 15 2018, 1:50 PM · Infrastructure
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 1:33 PM · Plans, Phriction
epriestley renamed T13081: Quicksand breaks the back button after a reload, et al from Quicksand breaks the back button after a reload to Quicksand breaks the back button after a reload, et al.
Feb 15 2018, 1:31 PM · Quicksand
epriestley triaged T13081: Quicksand breaks the back button after a reload, et al as Normal priority.
Feb 15 2018, 1:26 PM · Quicksand
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 1:01 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 12:46 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 12:12 PM · Plans, Phriction
jcox awarded T13079: Allow third-party code to extend the list of functions that function datasources support a Dat Boi token.
Feb 15 2018, 5:44 AM · Typeahead
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: Unknown Object (Differential Revision).
Feb 15 2018, 3:08 AM · Harbormaster
avivey awarded T13079: Allow third-party code to extend the list of functions that function datasources support a Like token.
Feb 15 2018, 2:22 AM · Typeahead
epriestley closed T13079: Allow third-party code to extend the list of functions that function datasources support as Resolved by committing Restricted Diffusion Commit.
Feb 15 2018, 2:11 AM · Typeahead
epriestley added a comment to T13079: Allow third-party code to extend the list of functions that function datasources support.

Example usage (for simplicity, requires at least one user named "Jake" on your install to function correctly):

Feb 15 2018, 2:01 AM · Typeahead
epriestley added a revision to T13079: Allow third-party code to extend the list of functions that function datasources support: Unknown Object (Differential Revision).
Feb 15 2018, 1:57 AM · Typeahead
epriestley added a comment to T13079: Allow third-party code to extend the list of functions that function datasources support.

After D19089, you can probably emit a projects(people-named-jake()) token or whatever and have it work for some values of "work" and "whatever". Tentatively, it doesn't look like this needs a lot of API changes, so I'm going to move forward with the simple version of the original request.

Feb 15 2018, 1:35 AM · Typeahead
epriestley added a revision to T13079: Allow third-party code to extend the list of functions that function datasources support: Unknown Object (Differential Revision).
Feb 15 2018, 1:30 AM · Typeahead
epriestley added a revision to T13079: Allow third-party code to extend the list of functions that function datasources support: Unknown Object (Differential Revision).
Feb 15 2018, 12:31 AM · Typeahead

Feb 14 2018

epriestley added a revision to T13079: Allow third-party code to extend the list of functions that function datasources support: Unknown Object (Differential Revision).
Feb 14 2018, 11:38 PM · Typeahead
epriestley updated subscribers of T13079: Allow third-party code to extend the list of functions that function datasources support.

@avivey, heads up that I'm renaming PhabricatorQuickSearchEngineExtension to PhabricatorDatasourceEngineExtension. I'm leaving an empty subclass in master for now so that nothing breaks, but will delete it sooner or later, so rename QuickSearch to Datasource in your extends ... statements (and, ideally, class names) at some point before then to keep things working smoothly.

Feb 14 2018, 11:36 PM · Typeahead
epriestley renamed T13079: Allow third-party code to extend the list of functions that function datasources support from Modularize typeahead function datasources to Allow third-party code to extend the list of functions that function datasources support.
Feb 14 2018, 11:29 PM · Typeahead
epriestley added a comment to T13080: Freeze header from differential sometimes sticks around when using the back button.

Quicksand isn't really bound by natural law, but I think that might fix it.

Feb 14 2018, 11:28 PM · Quicksand, Differential
epriestley closed T13080: Freeze header from differential sometimes sticks around when using the back button as Resolved by committing Restricted Diffusion Commit.
Feb 14 2018, 11:25 PM · Quicksand, Differential
epriestley added a revision to T13080: Freeze header from differential sometimes sticks around when using the back button: Unknown Object (Differential Revision).
Feb 14 2018, 11:22 PM · Quicksand, Differential
epriestley added projects to T13080: Freeze header from differential sometimes sticks around when using the back button: Differential, Quicksand.
Feb 14 2018, 11:13 PM · Quicksand, Differential
epriestley added a comment to T13080: Freeze header from differential sometimes sticks around when using the back button.

A workaround is to turn off the little inline chat thing so Quicksand disables itself, but this should be an easy fix.

Feb 14 2018, 11:13 PM · Quicksand, Differential
yelirekim added a comment to T13080: Freeze header from differential sometimes sticks around when using the back button.

Or apparently just doing this anywhere

Screen Shot 2018-02-14 at 5.45.53 PM.png (2×3 px, 694 KB)

Feb 14 2018, 10:46 PM · Quicksand, Differential
yelirekim added a comment to T13080: Freeze header from differential sometimes sticks around when using the back button.

Using Chrome

Feb 14 2018, 10:43 PM · Quicksand, Differential
yelirekim triaged T13080: Freeze header from differential sometimes sticks around when using the back button as Normal priority.
Feb 14 2018, 10:42 PM · Quicksand, Differential
epriestley closed T13078: `phabricator.silent` should also silence remote builds and webhooks as Resolved by committing Restricted Diffusion Commit.
Feb 14 2018, 7:41 PM · Config
epriestley added a revision to T13078: `phabricator.silent` should also silence remote builds and webhooks: Unknown Object (Differential Revision).
Feb 14 2018, 7:36 PM · Config
epriestley added a revision to T13078: `phabricator.silent` should also silence remote builds and webhooks: Unknown Object (Differential Revision).
Feb 14 2018, 7:14 PM · Config
epriestley triaged T13079: Allow third-party code to extend the list of functions that function datasources support as Normal priority.
Feb 14 2018, 4:56 PM · Typeahead
epriestley triaged T13078: `phabricator.silent` should also silence remote builds and webhooks as Normal priority.
Feb 14 2018, 4:40 PM · Config
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

We got a printer fax spam support request into the completely private Support app today. 😑

Feb 14 2018, 3:43 PM · Abuse
epriestley added a comment to T13077: Plans: Phriction modern "v3" APIs, Drafts.

Phriction already has modular transactions, but does not have an EditEngine. That likely needs to happen first.

Feb 14 2018, 3:14 PM · Plans, Phriction
epriestley renamed T12435: Add support for Spaces in Phriction from Add support for spaces in Phriction to Add support for Spaces in Phriction.
Feb 14 2018, 2:54 PM · Phriction, Feature Request
epriestley updated the task description for T13077: Plans: Phriction modern "v3" APIs, Drafts.
Feb 14 2018, 2:45 PM · Plans, Phriction
epriestley moved T13077: Plans: Phriction modern "v3" APIs, Drafts from Backlog to Next on the Phriction board.
Feb 14 2018, 2:44 PM · Plans, Phriction
epriestley closed T11478: Build PHUICMSView as Wontfix.

This never got fleshed out into an actionable plan, see T13077 for the next planned phase here.

Feb 14 2018, 2:44 PM · Design, PHUI, Phriction
epriestley closed T11478: Build PHUICMSView, a subtask of T9379: Build Phriction v3, as Wontfix.
Feb 14 2018, 2:44 PM · Phriction
epriestley moved T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Backlog to Next on the Phriction board.
Feb 14 2018, 2:43 PM · Phriction, Remarkup, Bug Report
epriestley moved T12193: Allow mentions to work in Phriction edit notes from Backlog to Next on the Phriction board.
Feb 14 2018, 2:42 PM · Phriction, Feature Request
epriestley moved T10859: Wiki page title is not updated in preview from Backlog to Next on the Phriction board.
Feb 14 2018, 2:41 PM · Feature Request, Phriction
epriestley moved T3963: Templates in Phriction from Backlog to Next on the Phriction board.
Feb 14 2018, 2:41 PM · Phriction
epriestley moved T4768: Phabricator silently overwrites concurrent changes (no conflict detection) from Backlog to Far Future on the Phriction board.
Feb 14 2018, 2:41 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley merged tasks T5394: Add support for specifying heading anchor IDs, T5380: Better handling of anchored links in Phriction into T4280: Embed anchor in remark up text and later link to it. .
Feb 14 2018, 2:40 PM · Remarkup
epriestley merged task T5394: Add support for specifying heading anchor IDs into T4280: Embed anchor in remark up text and later link to it. .
Feb 14 2018, 2:40 PM · Remarkup