Page MenuHomePhabricator
Create Task
Maniphest T13072

Merge Harbormaster BuildCommand into BuildMessage
Open, WishlistPublic
Actions

Description

See T13054. After those changes:

Buildables stuck in "building" despite an aborted build should get a best-effort migration if nothing else moots that (see also T10746).

Harbormaster has BuildCommand and BuildMessage. These are basically the same table. BuildCommand is sent to Build. BuildMessage is sent to BuildTarget and Buildable. These should probably just be the same table, and Build should be a valid receiver for BuildMessage.

If you arc diff --only, the buildable never leaves PENDING. A likely fix for this is to make arc call harbormaster.sendmessage(<buildablePHID>, "build") after it uploads lint and unit results if it's not going to create a revision. Currently, this method can not send messages to a Buildable and probably can't send a "build" message.

See PHI1380, which wants API access to the restart command. (This issue has nothing to do with Harbormaster, not sure what the original issue was.)

See also PHI1390, which is adjacent.

See also PHI1966, which wants access to the build command.

See also PHI614, which wants build/restart commands (approximately).

Revisions and Commits

rP Phabricator
D21696rP3df1e175273f Add a side nav to Conduit API method console pages
D21699rP4cffaa600bec Rename "HarbormasterRestartException" to "HarbormasterMessageException"
D21695rP2ff1d4b3b007 Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods
D21694rP346ffc51e100 Modularize "HarbormasterBuildableTransaction"
D21698rP4c4123f98b6d Allow "harbormaster.sendmessage" to send control command (pause, restart, abort…
D21693rP706b91adf677 Remove "HarbormasterBuildableTransaction::TYPE_CREATE"
D21692rP1a1395579f95 Remove "HarbormasterBuildCommand"
D21691rP1212dc5fbe8b Modularize almost all Harbormaster build message workflows and UI/UX
D21690rP8bbee921398d Modularize individual Harbormaster build messages
D21689rP6dfea0adaddc Modularize HarbormasterBuildTransaction
D21687rPbf83fffca129 Correct the flow of edit authority when sending messages to HarbormasterBuild…
D21688rPb84c02959a8b Remove "HarbormasterBuildTransaction::TYPE_CREATE"
D21685rP012af00731fd Improve formality of "HarbormasterBuild" states
D21684rPb48d4fabaf9e Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"
D21683rP0f93d1ffe450 Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"…
D19269rP7f9a9bc800f7 Make Harbormaster objects destructible
D19091rP2b0f98900bcb Fail outstanding buildables with aborted builds

Related Objects

Event Timeline

epriestley triaged this task as Wishlist priority.Feb 12 2018, 11:01 PM
epriestley created this task.
Herald added a subscriber: eadler. · View Herald TranscriptFeb 12 2018, 11:01 PM
epriestley mentioned this in T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.Feb 12 2018, 11:03 PM
epriestley updated the task description. (Show Details)
epriestley added a revision: D19091: Fail outstanding buildables with aborted builds.Feb 15 2018, 3:08 AM
epriestley added a commit: rP2b0f98900bcb: Fail outstanding buildables with aborted builds.Feb 15 2018, 11:57 AM
epriestley added a revision: D19269: Make Harbormaster objects destructible.Mar 29 2018, 7:58 PM
epriestley added a comment.Mar 29 2018, 7:59 PM

D19269 makes Harbormaster objects destructible. I've made Build destroy BuildMessage (which it doesn't receive, so this never destroys anything) but not BuildCommand (which it does receive), so that when this change is made (and it starts receiving BuildMessage instead of BuildCommand) things will just work. Until then, BuildCommand objects are technically left hanging, but destroying builds is exceptionally rare so I'm just assuming that this will probably be fixed before anyone notices.

epriestley added a commit: rP7f9a9bc800f7: Make Harbormaster objects destructible.Mar 29 2018, 8:01 PM
epriestley mentioned this in T13088: Plans: Harbormaster UI usability and interconnectedness.Apr 16 2018, 5:17 PM
epriestley mentioned this in T13289: Plans: 2019 Week 21-23 Bonus Content.May 30 2019, 11:48 PM
epriestley updated the task description. (Show Details)Aug 8 2019, 2:27 PM
Herald added a subscriber: amckinley. · View Herald TranscriptAug 8 2019, 2:27 PM
epriestley updated the task description. (Show Details)Aug 20 2019, 3:50 PM
• pasik added a subscriber: • pasik.Aug 29 2019, 6:09 PM
epriestley updated the task description. (Show Details)Jan 13 2021, 8:39 PM
epriestley removed a subscriber: • pasik.
epriestley updated the task description. (Show Details)Jul 13 2021, 10:04 PM
epriestley added a revision: D21683: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages" table.Jul 13 2021, 10:23 PM
epriestley added a revision: D21684: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage".Jul 13 2021, 10:48 PM
epriestley added a revision: D21685: Improve formality of "HarbormasterBuild" states.Jul 13 2021, 11:37 PM
epriestley added a comment.Jul 13 2021, 11:41 PM

In D21685, I've imposed stricter rules for which state transitions are allowed: for example, you can't issue a "pause" command to a build that is already pausing.

These make sense for humans clicking buttons in the web UI, but the API may be more useful if it is a bit more flexible and allows callers to issue no-op commands (e.g., pause an already-pausing build). So the distinction would then be:

  • Does the caller have permission to issue this command? (Web & API)
  • Is the build in a permissible state to receive this command? (Web & API)
  • Is the command useful to issue? (Human Web Only)
epriestley added a revision: D21687: Correct the flow of edit authority when sending messages to HarbormasterBuild objects.Jul 15 2021, 6:02 PM
epriestley added a revision: D21688: Remove "HarbormasterBuildTransaction::TYPE_CREATE".Jul 15 2021, 6:08 PM
epriestley added a revision: D21689: Modularize HarbormasterBuildTransaction.Jul 15 2021, 9:05 PM
epriestley added a revision: D21690: Modularize individual Harbormaster build messages.Jul 15 2021, 10:24 PM
epriestley added a comment.Jul 15 2021, 11:03 PM

This ("Queued at") looks suspicious:

Screen Shot 2021-07-15 at 4.03.26 PM.png (44×302 px, 7 KB)

epriestley added a revision: D21691: Modularize almost all Harbormaster build message workflows and UI/UX.Jul 16 2021, 1:30 AM
epriestley added a revision: D21692: Remove "HarbormasterBuildCommand".Jul 16 2021, 3:10 PM
epriestley added a revision: D21693: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".Jul 16 2021, 3:34 PM
epriestley added a revision: D21694: Modularize "HarbormasterBuildableTransaction".Jul 16 2021, 4:00 PM
epriestley added a revision: D21695: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.Jul 16 2021, 4:43 PM
epriestley added a revision: D21696: Add a side nav to Conduit API method console pages.Jul 16 2021, 10:15 PM
epriestley added a revision: D21698: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables.Jul 20 2021, 9:41 PM
epriestley added a revision: D21699: Rename "HarbormasterRestartException" to "HarbormasterMessageException".Jul 20 2021, 9:43 PM
epriestley added a commit: rP0f93d1ffe450: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"….Jul 21 2021, 9:17 PM
epriestley added a commit: rPb48d4fabaf9e: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage".
epriestley added a commit: rP012af00731fd: Improve formality of "HarbormasterBuild" states.
epriestley added a commit: rPbf83fffca129: Correct the flow of edit authority when sending messages to HarbormasterBuild….
epriestley added a commit: rPb84c02959a8b: Remove "HarbormasterBuildTransaction::TYPE_CREATE".
epriestley added a commit: rP6dfea0adaddc: Modularize HarbormasterBuildTransaction.
epriestley added a commit: rP8bbee921398d: Modularize individual Harbormaster build messages.
epriestley added a commit: rP1212dc5fbe8b: Modularize almost all Harbormaster build message workflows and UI/UX.
epriestley added a commit: rP1a1395579f95: Remove "HarbormasterBuildCommand".
epriestley added a commit: rP706b91adf677: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".
epriestley added a commit: rP346ffc51e100: Modularize "HarbormasterBuildableTransaction".
epriestley added a commit: rP4c4123f98b6d: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort….
epriestley added a commit: rP2ff1d4b3b007: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.
epriestley added a commit: rP3df1e175273f: Add a side nav to Conduit API method console pages.
epriestley added a commit: rP4cffaa600bec: Rename "HarbormasterRestartException" to "HarbormasterMessageException".
epriestley mentioned this in D21712: Trying out removing "Phabricator" from some user-visible text.Jul 28 2021, 5:09 AM
Phabricator · Built by Phacility