In D12444 I changed the default Differential query to use viewer(), instead of implicitly resolving the user's PHID. That means that when you "Edit Query", you get:

Responsible Users: [ Current Viewer ]

...instead of this, which is what you'd see previously:

Responsible Users: [ epriestley ]

I'm leaning toward reverting this. While using viewer() helps users discover tokenizer functions, I think these are a pretty advanced feature, and a new user is more likely to get a more useful understanding by seeing their own name (i.e., it implies "I can type a username to chose a user", while the viewer() token doesn't really suggest anything helpful about the typeahead).

It also makes the "Edit Query -> Change Something -> Execute -> Share URL" workflow more confusing, because the URL with someone else as the viewer will show them a completely different result set. (And if the recipient is logged out, the query will fail with an error.) This probably isn't very common, but using "epriestley" gives this workflow more predictable behavior.

Defaulting to viewer() never seems better for workflow reasons (except in cases where whoever is editing the query is sophisticated and intentionally trying to construct a parametrized query, but we don't need to look out for sophisticated users as much), and I think it's advanced enough that it doesn't make sense to try to drive function discovery on a user's first encounter with typeaheads. Function results show up as normal typeahead results and are discoverable through "Browse..." and will get documented at some point. These feel more appropriate for discovery of this feature than surfacing defaults in terms of tokenizer functions.

A big chunk of this is in HEAD. This should be where we are, roughly:

• All typeaheads/tokenizers should still work correctly.
• "Browse" button should work correctly everywhere.
• Differential "Responsible Users" field should now let you you use viewer() and members() functions.

This stuff is still known to be janky:

• Design needs a bit of work.
• Every search UI should support functions.
• We should have more functions.
• Function sort order can probably be better.
• Browse UI could probably do a better job of explaining function tokens.
• Browse UI dialog title is off.
• Documentation.

All typeaheads/tokenizers should still work correctly.

I'm seeing some issues on this install that I can't reproduce locally, looking into it...