HomePhabricator

Make token UI stronger and more consistent

Authored by epriestley.

Description

Make token UI stronger and more consistent

Summary:
Ref T4100. Overall:

  • Use token background color to communicate token type (blue = object, yellow = function, grey = disabled/closed, red = invalid).
  • Use token icon color to make color choices consistent (specifically, use project icon colors in project tokens).
  • For functions, use token icon to communicate function result type (e.g., viewer() has a user icon; members(...) has a group icon), since we don't need the icon to indicate "this is a function" anymore.

Test Plan:



Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12446

Details

Committed
epriestleyApr 17 2015, 6:06 PM
Pushed
epriestleyApr 17 2015, 6:07 PM
Reviewer
btrahan
Differential Revision
D12446: Make token UI stronger and more consistent
Parents
rP845466b49bf8: Implement viewer() and members(project) typeahead functions
Branches
Unknown
Tags
Unknown
Tasks
T4100: Support query parameterization in typeaheads