HomePhabricator

Make token UI stronger and more consistent

Tags
None
Referenced Files
F374616: Screen_Shot_2015-04-17_at_7.04.54_AM.png
Apr 17 2015, 6:09 PM
F374617: Screen_Shot_2015-04-17_at_6.57.31_AM.png
Apr 17 2015, 6:09 PM
F374615: Screen_Shot_2015-04-17_at_7.04.45_AM.png
Apr 17 2015, 6:09 PM
Subscribers
None

Description

Make token UI stronger and more consistent

Summary:
Ref T4100. Overall:

  • Use token background color to communicate token type (blue = object, yellow = function, grey = disabled/closed, red = invalid).
  • Use token icon color to make color choices consistent (specifically, use project icon colors in project tokens).
  • For functions, use token icon to communicate function result type (e.g., viewer() has a user icon; members(...) has a group icon), since we don't need the icon to indicate "this is a function" anymore.

Test Plan:

Screen_Shot_2015-04-17_at_7.04.45_AM.png (49×980 px, 16 KB)

Screen_Shot_2015-04-17_at_7.04.54_AM.png (432×608 px, 52 KB)

Screen_Shot_2015-04-17_at_6.57.31_AM.png (842×1 px, 162 KB)

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12446

Details