HomePhabricator

Require TokenizerControl to always have a datasource

Authored by epriestley.

Description

Require TokenizerControl to always have a datasource

Summary:
Ref T4100. I can simplify the logic a bit here by moving some rendering into the datasources, but a few TokenizerControls currently don't have datasources.

Require datasources and always provide datasources.

Test Plan:

  • Used previously-datasourceless controls (e.g., "Add Reviewers").
  • Used normal controls.
  • Manually verified that no other controls are missing datasources.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12456

Details

Committed
epriestleyApr 20 2015, 5:06 PM
Pushed
epriestleyApr 20 2015, 5:13 PM
Reviewer
btrahan
Differential Revision
D12456: Require TokenizerControl to always have a datasource
Parents
rPe27c0b416d45: Add "Edge Logic" support to PolicyAwareQuery
Branches
Unknown
Tags
Unknown
Tasks
T4100: Support query parameterization in typeaheads