Page MenuHomePhabricator

No Typeahead on Herald object rule creation
Open, Needs TriagePublic

Assigned To
None
Authored By
epkugelmass
Apr 1 2015, 11:37 PM
Referenced Files
F5084893: Screen Shot 2017-08-06 at 4.48.45 AM.png
Aug 6 2017, 11:50 AM
F5084416: image.png
Aug 6 2017, 3:59 AM
F356124: herald.png
Apr 1 2015, 11:37 PM

Description

During the Herald object rule creation workflow, there is no typeahead for the object selection text box (this is box that allows you to pick a project or repo to be linked to the rule).

herald.png (366×1 px, 25 KB)

Event Timeline

epkugelmass raised the priority of this task from to Needs Triage.
epkugelmass updated the task description. (Show Details)
epkugelmass added projects: Herald, Typeahead.
epkugelmass added a subscriber: epkugelmass.

I think we wrote this before typeaheads were modularized (T4420) so it wasn't easy to add a composite datasource at the time.

This is relatively easy nowadays.

Although tokenizer/typeahead stuff is churning a bit in connection with T4100 right now so this should probably wait for that to settle down.

chad claimed this task.
chad added a subscriber: chad.

image.png (1×2 px, 218 KB)

I don't think this is resolved, just an unclear report. To access this screen:

  • HeraldCreate Herald RuleCommit Hook: Branches/Tags/Bookmarks
  • Select Object on the next screen and submit.
  • Now, you get a plain text field labeled "Object", not, e.g., a "projects and repositories" tokenizer:

Screen Shot 2017-08-06 at 4.48.45 AM.png (1×1 px, 137 KB)

This reproduces for me at current HEAD of master.

chad removed chad as the assignee of this task.Aug 21 2017, 6:10 PM