Page MenuHomePhabricator

Fix an issue where "Browse > Select" did not work for dynamic tokenizers
ClosedPublic

Authored by epriestley on Apr 23 2015, 1:16 PM.

Details

Summary

Ref T4100. In Herald, using the browse dialog to select a result didn't work because we'd add the token with no name value. Other things would render it elsewhere, but it would eventaully be discarded.

Instead, add it with a name value.

Test Plan

Edited a Herald rule and used Browse > Select to add a token. Saved rule. Saw token persist.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 30076.Apr 23 2015, 1:16 PM
epriestley retitled this revision from to Fix an issue where "Browse > Select" did not work for dynamic tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Apr 23 2015, 5:30 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.