Page MenuHomePhabricator
Create Task
Maniphest T7688

Move token rendering into TypeaheadDatasource
Closed, ResolvedPublic
Actions

Description

Currently, TypeaheadDatasources accept lists of handles. They use these handle lists to render tokens in order to prefill the typeahead value.

Once we parameterize tokenizers, they need to accept strings instead (usually PHIDs) and render tokens internally. (An alternative is turning viewer() and members(differential) into "PHIDs", which immediately seems incredibly sketchy and terrible.)

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

StatusAssignedTask
 ResolvedchadT4323 Scaling bug (for Chrome browser)
 ResolvedNoneT3979 Support logged out version of the home page
 ResolvedepriestleyT3583 Fix the Swamp of Suck that is the home page content panel
 DuplicateNoneT5034 Show repositories when viewing a project
 ResolvedNoneT4980 Move Dashboards to beta
 WontfixepriestleyT3461 Improve documentation around Maniphest Excel exports
 ResolvedepriestleyT5391 Support custom fields in 'Export to Excel'
 OpenepriestleyT5151 Allow to export query results from Phrequent
 ResolvedepriestleyT5954 Modularize "Export to Excel" as a feature of ApplicationSearch
 ResolvedNoneT6787 Clarify UI for Objects with a non-default Policy
 ResolvedNoneT5135 Allow to change defaults for Passphrase "Visible To" and "Editable By" policies
 DuplicateNoneT6860 Allow creation of parameterized application policies
 WontfixepriestleyT6579 Display hovercards on Tokens in Typeaheads
 DuplicateNoneT6634 Typeahead default should maybe be more than 5
 ResolvedepriestleyT3670 Add subprojects
 OpenNoneT5529 Clear Flags on Accept
 WontfixepriestleyT6187 Allow query results to be exported to spreadsheet rendered in the browser
 ResolvedepriestleyT5815 Make it easier to work through a queue of stuff
 ResolvedchadT5307 UX for taking actions with search results
 ResolvedepriestleyT5595 Allow all applications to filter results by project
 WontfixepriestleyT5162 Add Herald action value for content creator / author
 OpenNoneT5288 Add a filter to show projects that I haven't joined
 OpenNoneT7729 No Typeahead on Herald object rule creation
 ResolvedepriestleyT4100 Support query parameterization in typeaheads
 ResolvedepriestleyT5746 Phabricator does not show project color in Projects Typeahead field
 ResolvedepriestleyT5750 Implement typeahead browse mode
 ResolvedepriestleyT7688 Move token rendering into TypeaheadDatasource
 ResolvedepriestleyT7689 Load handles just-in-time

Event Timeline

epriestley created this task.Mar 30 2015, 12:16 AM
epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Typeahead.
epriestley added a revision: Restricted Differential Revision.Apr 2 2015, 2:00 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 2 2015, 8:42 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley closed subtask T7689: Load handles just-in-time as Resolved.Apr 10 2015, 5:17 PM
Phabricator · Built by Phacility