Move token rendering into TypeaheadDatasource
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Mar 30 2015, 12:16 AM

Description

Currently, TypeaheadDatasources accept lists of handles. They use these handle lists to render tokens in order to prefill the typeahead value.

Once we parameterize tokenizers, they need to accept strings instead (usually PHIDs) and render tokens internally. (An alternative is turning viewer() and members(differential) into "PHIDs", which immediately seems incredibly sketchy and terrible.)

Revisions and Commits

rP Phabricator
	D12261	rPc39b64d963db Improve handle loading semantics for tokenizers

Related Objects
Search...

Status	Assigned	Task
Resolved	chad	T4323 Scaling bug (for Chrome browser)
Resolved	None	T3979 Support logged out version of the home page
Resolved	epriestley	T3583 Fix the Swamp of Suck that is the home page content panel
Duplicate	None	T5034 Show repositories when viewing a project
Resolved	None	T4980 Move Dashboards to beta
Wontfix	epriestley	T3461 Improve documentation around Maniphest Excel exports
Resolved	epriestley	T5391 Support custom fields in 'Export to Excel'
Open	epriestley	T5151 Allow to export query results from Phrequent
Resolved	epriestley	T5954 Modularize "Export to Excel" as a feature of ApplicationSearch
Resolved	None	T6787 Clarify UI for Objects with a non-default Policy
Resolved	None	T5135 Allow to change defaults for Passphrase "Visible To" and "Editable By" policies
Duplicate	None	T6860 Allow creation of parameterized application policies
Wontfix	epriestley	T6579 Display hovercards on Tokens in Typeaheads
Duplicate	None	T6634 Typeahead default should maybe be more than 5
Resolved	epriestley	T3670 Add subprojects
Open	None	T5529 Clear Flags on Accept
Wontfix	epriestley	T6187 Allow query results to be exported to spreadsheet rendered in the browser
Resolved	epriestley	T5815 Make it easier to work through a queue of stuff
Resolved	chad	T5307 UX for taking actions with search results
Resolved	epriestley	T5595 Allow all applications to filter results by project
Wontfix	epriestley	T5162 Add Herald action value for content creator / author
Open	None	T5288 Add a filter to show projects that I haven't joined
Open	None	T7729 No Typeahead on Herald object rule creation
Resolved	epriestley	T4100 Support query parameterization in typeaheads
Resolved	epriestley	T5746 Phabricator does not show project color in Projects Typeahead field
Resolved	epriestley	T5750 Implement typeahead browse mode
Resolved	epriestley	T7688 Move token rendering into TypeaheadDatasource
Resolved	epriestley	T7689 Load handles just-in-time