Page MenuHomePhabricator

Require TokenizerControl to always have a datasource
ClosedPublic

Authored by epriestley on Apr 18 2015, 3:43 PM.

Details

Summary

Ref T4100. I can simplify the logic a bit here by moving some rendering into the datasources, but a few TokenizerControls currently don't have datasources.

Require datasources and always provide datasources.

Test Plan
  • Used previously-datasourceless controls (e.g., "Add Reviewers").
  • Used normal controls.
  • Manually verified that no other controls are missing datasources.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Require TokenizerControl to always have a datasource.Apr 18 2015, 3:43 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 29899.
btrahan edited edge metadata.Apr 20 2015, 4:23 PM
btrahan accepted this revision.
This revision is now accepted and ready to land.Apr 20 2015, 4:23 PM
This revision was automatically updated to reflect the committed changes.