Page MenuHomePhabricator

Implement a projects() datasource function
ClosedPublic

Authored by epriestley on Apr 18 2015, 4:16 PM.

Details

Summary

Ref T4100. This is like members(), but is implemented on top of the raw datasource. This is a lot simpler and involves way less code duplication.

I'll go back and implement members() like this, too.

Nothing actually uses this yet.

Test Plan
  • Used browse view to browse datasource.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Implement a projects() datasource function.Apr 18 2015, 4:16 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 29901.
epriestley added inline comments.Apr 18 2015, 6:09 PM
src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php
42–62

This isn't quite right, but a diff a few changes from now (probably D12462 by the time you read this) adjusts this source anyway.

btrahan edited edge metadata.Apr 20 2015, 4:28 PM
btrahan accepted this revision.
This revision is now accepted and ready to land.Apr 20 2015, 4:28 PM
This revision was automatically updated to reflect the committed changes.