Page MenuHomePhabricator

Add contextual typeahead function documentation
ClosedPublic

Authored by epriestley on Apr 20 2015, 7:37 PM.

Details

Summary

Ref T4100. This integration into the "Browse" dialog is probably a little more heavy-handed than we should shoot for.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29965.Apr 20 2015, 7:37 PM
epriestley retitled this revision from to Add contextual typeahead function documentation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.Apr 20 2015, 7:43 PM

Can we float some text in the footer opposite of the close button?

epriestley updated this revision to Diff 29966.Apr 20 2015, 7:53 PM
epriestley edited edge metadata.
  • Use a footer instead.
chad accepted this revision.Apr 20 2015, 8:30 PM
chad edited edge metadata.
chad added inline comments.
src/applications/maniphest/typeahead/ManiphestNoOwnerDatasource.php
32

return return

This revision is now accepted and ready to land.Apr 20 2015, 8:30 PM
epriestley updated this revision to Diff 29968.Apr 20 2015, 8:42 PM
epriestley marked an inline comment as done.
epriestley edited edge metadata.
  • Return less returns.
This revision was automatically updated to reflect the committed changes.