Page MenuHomePhabricator

Refine global search UI for tokenizer functions
ClosedPublic

Authored by epriestley on Apr 23 2015, 10:19 AM.

Details

Summary

Ref T4100.

  • Removes the "with unowned" checkbox in favor of the "no owners" function.
  • Support functions in "Authors" and "Owners".
Test Plan
  • Ran various global search and Maniphest queries.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Refine global search UI for tokenizer functions.Apr 23 2015, 10:19 AM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 30069.
btrahan edited edge metadata.Apr 23 2015, 5:00 PM
btrahan accepted this revision.
btrahan added inline comments.
src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php
82–83

surprised this is necessary

This revision is now accepted and ready to land.Apr 23 2015, 5:00 PM
epriestley added inline comments.Apr 23 2015, 5:05 PM
src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php
82–83

The token is originally coming from the underlying Project tokenizer, which sets the color on it if the project has a color. If it was just freshly created we wouldn't have to do it.

We could do something else like automatically ignore colors on function tokens, but it's possible that we'll want colored functions or something. This may end up getting cleaned up if we don't adjust the design much, though.

This revision was automatically updated to reflect the committed changes.