Page MenuHomePhabricator
Differential D12469

Give typeahead browse dialogs sensible titles
ClosedPublic
Actions

Authored by epriestley on Apr 19 2015, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 7:31 AM
Unknown Object (File)
Sat, Jan 25, 9:11 PM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Wed, Jan 22, 9:22 AM
Unknown Object (File)
Fri, Jan 17, 5:14 PM
Unknown Object (File)
Mon, Jan 6, 2:11 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPe5e5974d9fe1: Give typeahead browse dialogs sensible titles
Summary

Ref T4100. Let datasources specify a more meaningful title than the class name.

Test Plan

Browsed some sources.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29924.Apr 19 2015, 2:33 PM
epriestley retitled this revision from to Give typeahead browse dialogs sensible titles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2015, 2:33 PM
chad accepted this revision.Apr 19 2015, 2:38 PM
chad added a reviewer: chad.
chad added a subscriber: chad.
chad added inline comments.
src/applications/people/typeahead/PhabricatorViewerDatasource.php
7

Is this a browse interface of one item?

This revision is now accepted and ready to land.Apr 19 2015, 2:38 PM
epriestley added a comment.Apr 19 2015, 2:39 PM

Yeah, the viewer(), viewerprojects() and null() datasources all return only one item. Users can never normally hit these browse dialogs unless they're developing/debugging, though.

Closed by commit rPe5e5974d9fe1: Give typeahead browse dialogs sensible titles (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
typeahead/
4 lines
4 lines
diffusion/
typeahead/
4 lines
4 lines
4 lines
4 lines
harbormaster/
typeahead/
4 lines
4 lines
legalpad/
typeahead/
4 lines
macro/
typeahead/
4 lines
mailinglists/
typeahead/
4 lines
maniphest/
typeahead/
4 lines
4 lines
meta/
typeahead/
4 lines
metamta/
typeahead/
4 lines
4 lines
owners/
typeahead/
4 lines
people/
typeahead/
4 lines
4 lines
project/
typeahead/
4 lines
4 lines
6 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
search/
typeahead/
4 lines
typeahead/
controller/
2 lines
datasource/
5 lines
4 lines
4 lines
4 lines
6 lines

Diff 29960

View Options

src/applications/almanac/typeahead/AlmanacInterfaceDatasource.php

Loading...
View Options

src/applications/almanac/typeahead/AlmanacServiceDatasource.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionArcanistProjectDatasource.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionAuditorDatasource.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php

Loading...
View Options

src/applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php

Loading...
View Options

src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php

Loading...
View Options

src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php

Loading...
View Options

src/applications/macro/typeahead/PhabricatorMacroDatasource.php

Loading...
View Options

src/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php

Loading...
View Options

src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php

Loading...
View Options

src/applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php

Loading...
View Options

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php

Loading...
View Options

src/applications/metamta/typeahead/PhabricatorMetaMTAApplicationEmailDatasource.php

Loading...
View Options

src/applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php

Loading...
View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorPeopleDatasource.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorViewerDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectOrUserDatasource.php

Loading...
View Options

src/applications/search/typeahead/PhabricatorSearchDatasource.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadMonogramDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php

Loading...
Phabricator · Built by Phacility