Page MenuHomePhabricator

Give typeahead browse dialogs sensible titles
ClosedPublic

Authored by epriestley on Apr 19 2015, 2:33 PM.

Details

Summary

Ref T4100. Let datasources specify a more meaningful title than the class name.

Test Plan

Browsed some sources.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Give typeahead browse dialogs sensible titles.Apr 19 2015, 2:33 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 29924.
chad added a reviewer: chad.Apr 19 2015, 2:38 PM
chad accepted this revision.
chad added a subscriber: chad.
chad added inline comments.
src/applications/people/typeahead/PhabricatorViewerDatasource.php
7

Is this a browse interface of one item?

This revision is now accepted and ready to land.Apr 19 2015, 2:38 PM

Yeah, the viewer(), viewerprojects() and null() datasources all return only one item. Users can never normally hit these browse dialogs unless they're developing/debugging, though.

This revision was automatically updated to reflect the committed changes.