Page MenuHomePhabricator

Move token rendering into Datasources
ClosedPublic

Authored by epriestley on Apr 18 2015, 3:57 PM.

Details

Summary

Ref T4100. I want to reduce the amount of code duplication that function datasources currently need to wrap some parameter datasource.

For example, ProjectMembersDatasource should really just be a little bit of logic on top of ProjectsDatasource, which should do most of the heavy lifting.

Moving rendering into datasources brings us a step closer to being able to do this.

Test Plan
  • Rendered normal, function, and invalid tokens.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Move token rendering into Datasources.Apr 18 2015, 3:57 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 29900.
btrahan edited edge metadata.Apr 20 2015, 4:27 PM
btrahan accepted this revision.
This revision is now accepted and ready to land.Apr 20 2015, 4:27 PM
This revision was automatically updated to reflect the committed changes.