Page MenuHomePhabricator

Move token rendering into Datasources
ClosedPublic

Authored by epriestley on Apr 18 2015, 3:57 PM.
Tags
None
Referenced Files
F14055502: D12457.diff
Sat, Nov 16, 12:35 PM
F14042264: D12457.diff
Tue, Nov 12, 1:48 AM
F14025931: D12457.diff
Thu, Nov 7, 9:26 PM
F14009793: D12457.diff
Wed, Oct 30, 11:51 PM
F14004902: D12457.diff
Sun, Oct 27, 4:50 AM
F13965180: D12457.id29951.diff
Oct 16 2024, 12:27 AM
F13958722: D12457.id29900.diff
Oct 14 2024, 4:14 PM
Unknown Object (File)
Sep 4 2024, 7:24 PM
Subscribers

Details

Summary

Ref T4100. I want to reduce the amount of code duplication that function datasources currently need to wrap some parameter datasource.

For example, ProjectMembersDatasource should really just be a little bit of logic on top of ProjectsDatasource, which should do most of the heavy lifting.

Moving rendering into datasources brings us a step closer to being able to do this.

Test Plan
  • Rendered normal, function, and invalid tokens.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move token rendering into Datasources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:27 PM
This revision was automatically updated to reflect the committed changes.