Differential D12467

Give tokenizer tokens CSS color classes on the container instead of the icon
ClosedPublic
Actions

Authored by epriestley on Apr 19 2015, 1:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 8:13 PM

	Unknown Object (File)
	Fri, Jan 24, 6:04 PM

	Unknown Object (File)
	Fri, Jan 24, 2:49 AM

	Unknown Object (File)
	Fri, Jan 24, 2:49 AM

	Unknown Object (File)
	Fri, Jan 24, 2:49 AM

	Unknown Object (File)
	Wed, Jan 22, 5:20 PM

	Unknown Object (File)
	Sat, Jan 18, 12:05 PM

	Unknown Object (File)
	Fri, Jan 17, 2:29 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T4100: Support query parameterization in typeaheads

Commits

Restricted Diffusion Commit
rP8f61eb45ab3b: Give tokenizer tokens CSS color classes on the container instead of the icon

Summary

Ref T4100. See D12465.

Instead of putting CSS color classes on the tokenizer icons, put them on the container tags.
Note that this removes the "bluegrey" default classes.
This doesn't actually add CSS for the classes so, e.g., "green" doesn't make things green yet. This just supports D12465.

Test Plan

Viewed markup, saw classes.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29920.Apr 19 2015, 1:12 PM

epriestley retitled this revision from to Give tokenizer tokens CSS color classes on the container instead of the icon.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4100: Support query parameterization in typeaheads.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2015, 1:12 PM

chad accepted this revision.Apr 19 2015, 2:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 19 2015, 2:12 PM

Closed by commit rP8f61eb45ab3b: Give tokenizer tokens CSS color classes on the container instead of the icon (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2015, 2:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

typeahead/

PhabricatorProjectDatasource.php

3 lines

typeahead/

storage/

PhabricatorTypeaheadResult.php

13 lines

view/

PhabricatorTypeaheadTokenView.php

19 lines

uiexample/

examples/

PHUITypeaheadExample.php

5 lines

view/

form/

control/

AphrontFormTokenizerControl.php

1 line

webroot/

rsrc/

js/

core/

15 lines

Diff 29923

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

Loading...

src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php

Loading...

src/applications/uiexample/examples/PHUITypeaheadExample.php

Loading...

src/view/form/control/AphrontFormTokenizerControl.php

Loading...

webroot/rsrc/js/core/Prefab.js

Loading...