- User Since
- Aug 8 2013, 12:01 AM (337 w, 5 d)
Jan 24 2017
May 18 2016
Feb 13 2016
Dec 2 2015
This one is totally my bad.
My intention was to make it less spooky to migrate individual pieces to the section construct (since the API remained largely the same), but the API weirdness was not worth it, and didn't even achieve that goal
Nov 23 2015
Badly designed workaround for an issue we had
The use case for it was related to CI, but it's not relevant anymore
Oct 30 2015
My favorite commit of 2015.
Aug 26 2015
Aug 12 2015
It was a screenshot taken on a retina Mac. It had some mapping image on it. The whole thing was around 5mb.
Apr 17 2015
Mar 23 2015
Dec 16 2014
Dec 10 2014
Dec 4 2014
Dec 2 2014
It would be nice (and maybe pretty complex) for (3) to work if you happen to use S3 (which would work if you instance is behind VPN), although right now the Phabricator guide does not recommend using it.
What about inlining the images with data:base64 ?
Sure it will make emails with images bigger, but it will always work and most emails don't have macros.
Nov 18 2014
Nov 12 2014
project.query does not emits the auxiliary dictionary, so there's no way of getting custom field value with the api :(
Oct 30 2014
Looks good, although it won't fix inline links (in comments and such)
Oct 13 2014
Sep 9 2014
This causes Phabricator to blow up on our install
Call to undefined method JsonLintLexer::len()
... phutil_json_decode() /Users/tal/dev/phabricator/phabricator/src/applications/differential/customfield/DifferentialAuditorsField.php:24 PhutilJSONParser->parse() /Users/tal/dev/phabricator/libphutil/src/utils/utils.php:1053 JsonLintJsonParser->parse() /Users/tal/dev/phabricator/libphutil/src/parser/PhutilJSONParser.php:27 JsonLintJsonParser->lex() /Users/tal/dev/phabricator/libphutil/externals/jsonlint/src/Seld/JsonLint/JsonParser.php:178
Sep 8 2014
Aug 20 2014
Aug 15 2014
Aug 14 2014
- removed server config option for html email
- cleaned out escaping and removed colorful headers
my arcanist seems to be messed up?
- added per-user config and removed diff colorization (will come back again in a separate patch)
Actually I think I can test the rendering with something like litmus, so it should be pretty easy to verify this one.
Aug 13 2014
Awesome! Can you arc patch D9375 locally and see if:
Cool. I'll chop em up and send patches.
I mean, make v1 also do diffs (because they are so easy compared to remarkup), which is pretty much D9375 plus minor fixes plus per-user config. I can also rip that part out if you'd prefer, although we found it to be useful.
Yeah, this needs some poking around, although I'm leaning towards teaching PhutilRemarkupBlockRule how to render things for email.
There's just one render target right now I think. The text rendering just dumps the remarkup as is.
- Cool, I'll add the formatting option.
- Correctly rendering remarkup blocks might be a little hairy, as it requires inlining CSS. Maybe we need to teach PhutilRemarkupBlockRule how to render tags for email, or figure out some post-processing css inline pass?
Aug 12 2014
Aug 9 2014
One click instead of two (it works as advertised)
can we get a way to do a one-click "add task to column"?
Aug 5 2014
Jul 18 2014
Jul 15 2014
oops! I did search for it, but my feng shui was misaligned.
Jul 11 2014
Awesome! I've really wanted this :)
Jul 9 2014
Jul 4 2014
FWIW, we've been running this since I've submitted the diff, and it abolished Mail.app threading issues, and we haven't seen any issues elsewhere.
I see. Is there a ticket for the filter-by-project reworking? I couldn't find one
Jun 30 2014
added support for colorized diffs for inline comments
added PhabricatorMetaMTAMailSection helper for building email sections
Jun 27 2014
We have the exact same issue. it makes Phabricator "feel" spammy.
Jun 25 2014
One clarification: the only requirement for this to work is knowing what the Message-ID of the message is.
Jun 24 2014
ping? There's totally tests for it :D
Jun 19 2014
@chad: yeah, that's fair. It also needs testing across more email clients to verify that it doesn't break replies and threading.
D9375 works reasonably well, but need to verify that it doesn't break reply-by-email in popular email client (see differential review for details)
Jun 18 2014
I personally dislike it the addition to the body, as it adds more metadata to scroll through before I can get into the comments.
What about something like T5244?
We use [REPO/BRANCH] [Differential] <...> for our email subjects, and it's super convenient.
Jun 17 2014
REALLY TOTALLY REBASE
Jun 16 2014
Is there any interest in this patch?
We've been dogfooding it for a while now, and it works pretty well (we also reply from emails a lot).
- show up in help --full
- moved config parsing to pre-workflow phase
- clean up patch a bit
Jun 13 2014
Jun 12 2014
--set-config -> --config
Not that useful :D
Jun 11 2014
fixed sloppy newline