Page MenuHomePhabricator

talshiri (Tal Shiri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 8 2013, 12:01 AM (305 w, 2 d)
Availability
Available

Recent Activity

Jan 24 2017

talshiri awarded D17244: Add an Emoji Typeahead a Party Time token.
Jan 24 2017, 9:45 PM

May 18 2016

talshiri awarded D15885: Send HTML email by default a The World Burns token.
May 18 2016, 10:07 PM
kaya awarded D9342: Make Differential email subject more configurable. a Like token.
May 18 2016, 6:09 PM

Feb 13 2016

talshiri added a comment to Blog Post: Updates to Workboards: Dragging, Cover Photos and Points.

Really awesome.

Feb 13 2016, 12:32 AM · Workboards, Maniphest

Dec 2 2015

talshiri added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

This one is totally my bad.
My intention was to make it less spooky to migrate individual pieces to the section construct (since the API remained largely the same), but the API weirdness was not worth it, and didn't even achieve that goal

Dec 2 2015, 4:44 AM · Differential

Nov 23 2015

talshiri abandoned D10954: Don't force main menu search form to use POST.
Nov 23 2015, 6:34 PM
talshiri abandoned D9382: Only canonize paths if both sourceControlPath field is present and we're in SVN..

Badly designed workaround for an issue we had

Nov 23 2015, 6:32 PM
talshiri abandoned D9342: Make Differential email subject more configurable..
Nov 23 2015, 6:31 PM
talshiri abandoned D9383: return remote for getSourceControlPath.

The use case for it was related to CI, but it's not relevant anymore

Nov 23 2015, 6:28 PM
talshiri abandoned D10279: basic diff highlighting for html emails.
Nov 23 2015, 6:28 PM

Oct 30 2015

talshiri added a comment to D14369: Allow any {icon} to spin.

My favorite commit of 2015.

Oct 30 2015, 10:09 PM

Aug 26 2015

fernando.otero awarded T5244: Allow email subjects and bodies to be more customizable a Like token.
Aug 26 2015, 2:25 PM · Restricted Project, Mail

Aug 12 2015

talshiri added a comment to rP2bdb5404c7e9: Implement new profile transform with amazing "error handling" feature.

It was a screenshot taken on a retina Mac. It had some mapping image on it. The whole thing was around 5mb.

Aug 12 2015, 6:06 PM
talshiri added inline comments to rP2bdb5404c7e9: Implement new profile transform with amazing "error handling" feature.
Aug 12 2015, 8:20 AM

Apr 17 2015

talshiri awarded D12444: Implement viewer() and members(project) typeahead functions a Baby Tequila token.
Apr 17 2015, 12:44 AM

Mar 23 2015

talshiri added inline comments to D9430: Don't bundle PEP8.
Mar 23 2015, 6:53 PM

Dec 16 2014

talshiri created T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user.
Dec 16 2014, 9:39 PM · Arcanist

Dec 10 2014

talshiri retitled D10954: Don't force main menu search form to use POST from to Don't force main menu search form to use POST.
Dec 10 2014, 3:13 AM

Dec 4 2014

talshiri edited the content of Organizations Using Phabricator.
Dec 4 2014, 11:36 PM

Dec 2 2014

talshiri added a comment to T6670: Macro images don't show up on html emails if your instance requires logins.

It would be nice (and maybe pretty complex) for (3) to work if you happen to use S3 (which would work if you instance is behind VPN), although right now the Phabricator guide does not recommend using it.

Dec 2 2014, 7:17 PM · Macros, Mail
talshiri added a comment to T6670: Macro images don't show up on html emails if your instance requires logins.

What about inlining the images with data:base64 ?
Sure it will make emails with images bigger, but it will always work and most emails don't have macros.

Dec 2 2014, 7:05 PM · Macros, Mail
talshiri created T6670: Macro images don't show up on html emails if your instance requires logins.
Dec 2 2014, 12:33 AM · Macros, Mail

Nov 18 2014

talshiri edited P1425 raw mail.
Nov 18 2014, 3:28 AM

Nov 12 2014

talshiri added a comment to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

project.query does not emits the auxiliary dictionary, so there's no way of getting custom field value with the api :(

Nov 12 2014, 1:35 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Oct 30 2014

talshiri added a comment to D10762: Add addLinkSection to MailBody to properly format URIs.

Looks good, although it won't fix inline links (in comments and such)

Oct 30 2014, 5:59 PM

Oct 13 2014

talshiri added a comment to D9716: Improve out-of-the-box compatability with Mail.app's threading.

ping

Oct 13 2014, 8:29 AM

Sep 9 2014

talshiri added a comment to D10435: Patch the `JSONLint` external to be compatible with PHP 5.2.

This causes Phabricator to blow up on our install
Call to undefined method JsonLintLexer::len()
callstack:

...
phutil_json_decode() /Users/tal/dev/phabricator/phabricator/src/applications/differential/customfield/DifferentialAuditorsField.php:24
PhutilJSONParser->parse() /Users/tal/dev/phabricator/libphutil/src/utils/utils.php:1053
JsonLintJsonParser->parse() /Users/tal/dev/phabricator/libphutil/src/parser/PhutilJSONParser.php:27
JsonLintJsonParser->lex() /Users/tal/dev/phabricator/libphutil/externals/jsonlint/src/Seld/JsonLint/JsonParser.php:178
Sep 9 2014, 12:05 AM

Sep 8 2014

talshiri retitled D10447: restored --head support from to restored --head support.
Sep 8 2014, 8:52 PM

Aug 20 2014

talshiri added a comment to D10279: basic diff highlighting for html emails.

Aug 20 2014, 1:17 AM
talshiri added a task to D10279: basic diff highlighting for html emails: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Aug 20 2014, 1:04 AM
talshiri added a revision to T992: Send rich HTML mail bodies without impacting reply handling functionality: D10279: basic diff highlighting for html emails.
Aug 20 2014, 1:04 AM · Differential, Mail

Aug 15 2014

talshiri retitled D10279: basic diff highlighting for html emails from to basic diff highlighting for html emails.
Aug 15 2014, 7:59 PM
talshiri added inline comments to D9375: HTML emails.
Aug 15 2014, 6:55 PM
talshiri added inline comments to D9375: HTML emails.
Aug 15 2014, 12:45 AM

Aug 14 2014

talshiri updated the diff for D9375: HTML emails.
  • removed server config option for html email
Aug 14 2014, 11:42 PM
talshiri updated the diff for D9375: HTML emails.
  • cleaned out escaping and removed colorful headers
Aug 14 2014, 11:31 PM
talshiri updated the diff for D9375: HTML emails.

my arcanist seems to be messed up?

Aug 14 2014, 8:25 PM
talshiri updated the diff for D9375: HTML emails.
  • cosmetics
Aug 14 2014, 8:24 PM
talshiri added inline comments to D9375: HTML emails.
Aug 14 2014, 8:23 PM
chad awarded D9375: HTML emails a Evil Spooky Haunted Tree token.
Aug 14 2014, 2:43 PM
talshiri updated the diff for D9375: HTML emails.

really fix it

Aug 14 2014, 4:54 AM
talshiri updated the diff for D9375: HTML emails.

wops

Aug 14 2014, 4:54 AM
talshiri retitled D9375: HTML emails from HTML emails + basic DIFF colorizing to HTML emails.
Aug 14 2014, 4:52 AM
talshiri updated the diff for D9375: HTML emails.
  • added per-user config and removed diff colorization (will come back again in a separate patch)
Aug 14 2014, 4:52 AM
talshiri added a comment to D9375: HTML emails.

Actually I think I can test the rendering with something like litmus, so it should be pretty easy to verify this one.

Aug 14 2014, 1:59 AM

Aug 13 2014

talshiri added a comment to D9375: HTML emails.

Awesome! Can you arc patch D9375 locally and see if:

Aug 13 2014, 8:58 PM
talshiri added a comment to T992: Send rich HTML mail bodies without impacting reply handling functionality.

Cool. I'll chop em up and send patches.

Aug 13 2014, 8:18 PM · Differential, Mail
talshiri added a comment to T992: Send rich HTML mail bodies without impacting reply handling functionality.

I mean, make v1 also do diffs (because they are so easy compared to remarkup), which is pretty much D9375 plus minor fixes plus per-user config. I can also rip that part out if you'd prefer, although we found it to be useful.

Aug 13 2014, 8:10 PM · Differential, Mail
talshiri awarded D10255: Show projects on feed stories a Love token.
Aug 13 2014, 8:07 PM
talshiri added a comment to T992: Send rich HTML mail bodies without impacting reply handling functionality.

Yeah, this needs some poking around, although I'm leaning towards teaching PhutilRemarkupBlockRule how to render things for email.
There's just one render target right now I think. The text rendering just dumps the remarkup as is.

Aug 13 2014, 7:45 PM · Differential, Mail
talshiri added a comment to T992: Send rich HTML mail bodies without impacting reply handling functionality.
  • Cool, I'll add the formatting option.
  • Correctly rendering remarkup blocks might be a little hairy, as it requires inlining CSS. Maybe we need to teach PhutilRemarkupBlockRule how to render tags for email, or figure out some post-processing css inline pass?
Aug 13 2014, 6:42 PM · Differential, Mail

Aug 12 2014

talshiri updated the diff for D9342: Make Differential email subject more configurable..

resend

Aug 12 2014, 9:44 PM
talshiri updated the diff for D9342: Make Differential email subject more configurable..

rebased

Aug 12 2014, 9:41 PM
talshiri updated the test plan for D9375: HTML emails.
Aug 12 2014, 1:56 AM
talshiri updated the diff for D9375: HTML emails.

rebase

Aug 12 2014, 1:54 AM

Aug 9 2014

talshiri added a comment to D10190: Convert workboard column options into a dropdown menu.

One click instead of two (it works as advertised)

Aug 9 2014, 5:55 PM
talshiri added a comment to D10190: Convert workboard column options into a dropdown menu.

can we get a way to do a one-click "add task to column"?

Aug 9 2014, 10:04 AM

Aug 5 2014

talshiri updated the diff for D9375: HTML emails.

few fixes + rebase

Aug 5 2014, 3:01 AM

Jul 18 2014

talshiri retitled D9978: don't add email addresses to CC if they are already in TO from to don't add email addresses to CC if they are already in TO.
Jul 18 2014, 1:18 AM

Jul 15 2014

talshiri added a comment to T5624: Workboards: when drag 'n dropping a task, scroll the page when the cursor is at the screen edges.

oops! I did search for it, but my feng shui was misaligned.

Jul 15 2014, 4:34 AM
talshiri updated subscribers of T5624: Workboards: when drag 'n dropping a task, scroll the page when the cursor is at the screen edges.
Jul 15 2014, 3:58 AM
talshiri created T5624: Workboards: when drag 'n dropping a task, scroll the page when the cursor is at the screen edges.
Jul 15 2014, 3:57 AM

Jul 11 2014

talshiri added a comment to D9871: Allow worker tasks to have priorities.

Awesome! I've really wanted this :)

Jul 11 2014, 5:48 PM
talshiri accepted D9898: Use `git diff a b` for ranges, not `git diff a..b`.
Jul 11 2014, 5:43 PM

Jul 9 2014

talshiri updated the test plan for D9375: HTML emails.
Jul 9 2014, 9:16 PM
talshiri updated the test plan for D9375: HTML emails.
Jul 9 2014, 9:15 PM
talshiri updated the test plan for D9375: HTML emails.
Jul 9 2014, 9:15 PM

Jul 4 2014

talshiri added a comment to D9716: Improve out-of-the-box compatability with Mail.app's threading.

FWIW, we've been running this since I've submitted the diff, and it abolished Mail.app threading issues, and we haven't seen any issues elsewhere.

Jul 4 2014, 8:13 PM
talshiri added a comment to T5552: Feed: allow creating a feed that filters on a per-project basis.

I see. Is there a ticket for the filter-by-project reworking? I couldn't find one

Jul 4 2014, 3:55 AM
talshiri created T5552: Feed: allow creating a feed that filters on a per-project basis.
Jul 4 2014, 12:08 AM

Jun 30 2014

talshiri updated the diff for D9375: HTML emails.

added support for colorized diffs for inline comments
added PhabricatorMetaMTAMailSection helper for building email sections

Jun 30 2014, 9:48 PM

Jun 27 2014

talshiri added a comment to T5185: Comment emails generated from parsing incoming email replies should not go to people already on the To/CC of the incoming email.

We have the exact same issue. it makes Phabricator "feel" spammy.

Jun 27 2014, 8:52 AM

Jun 25 2014

talshiri added a comment to D9716: Improve out-of-the-box compatability with Mail.app's threading.

One clarification: the only requirement for this to work is knowing what the Message-ID of the message is.

Jun 25 2014, 12:21 AM
talshiri updated D9716: Improve out-of-the-box compatability with Mail.app's threading.
Jun 25 2014, 12:13 AM
talshiri retitled D9716: Improve out-of-the-box compatability with Mail.app's threading from to Improve out-of-the-box compatability with Mail.app's threading.
Jun 25 2014, 12:10 AM

Jun 24 2014

talshiri retitled D9715: mailgun support messageids. supportsMessageIDHeader accidentally returned false. from to mailgun support messageids. supportsMessageIDHeader accidentally returned false..
Jun 24 2014, 11:18 PM
talshiri added a comment to D9405: made email commands extraction a bit more lax.

ping? There's totally tests for it :D

Jun 24 2014, 7:13 PM

Jun 19 2014

talshiri added a comment to D9375: HTML emails.

@chad: yeah, that's fair. It also needs testing across more email clients to verify that it doesn't break replies and threading.

Jun 19 2014, 6:26 PM
talshiri added a comment to T992: Send rich HTML mail bodies without impacting reply handling functionality.

D9375 works reasonably well, but need to verify that it doesn't break reply-by-email in popular email client (see differential review for details)

Jun 19 2014, 6:22 PM · Differential, Mail
talshiri added a task to D9375: HTML emails: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Jun 19 2014, 6:18 PM
talshiri edited this Maniphest Task.
Jun 19 2014, 6:18 PM · Differential, Mail

Jun 18 2014

talshiri added a comment to T5137: Make emails easier to filter.

I personally dislike it the addition to the body, as it adds more metadata to scroll through before I can get into the comments.

Jun 18 2014, 5:46 PM · Mail
talshiri added a comment to T5137: Make emails easier to filter.

What about something like T5244?
We use [REPO/BRANCH] [Differential] <...> for our email subjects, and it's super convenient.

Jun 18 2014, 5:21 PM · Mail

Jun 17 2014

talshiri updated the diff for D9405: made email commands extraction a bit more lax.

REALLY TOTALLY REBASE

Jun 17 2014, 8:21 PM
talshiri updated the diff for D9405: made email commands extraction a bit more lax.

rebased

Jun 17 2014, 8:18 PM

Jun 16 2014

talshiri added a comment to D9375: HTML emails.

Looks kinda like this

Jun 16 2014, 10:26 PM
talshiri added a comment to D9375: HTML emails.

Is there any interest in this patch?
We've been dogfooding it for a while now, and it works pretty well (we also reply from emails a lot).

Jun 16 2014, 10:21 PM
talshiri updated the diff for D9442: Allow specifying runtime configuration with --set-config key=value.
  • show up in help --full
Jun 16 2014, 10:17 PM
talshiri updated the diff for D9442: Allow specifying runtime configuration with --set-config key=value.
  • moved config parsing to pre-workflow phase
  • clean up patch a bit
Jun 16 2014, 10:14 PM

Jun 13 2014

talshiri updated the diff for D9442: Allow specifying runtime configuration with --set-config key=value.

rebased

Jun 13 2014, 11:48 PM

Jun 12 2014

talshiri updated the diff for D9375: HTML emails.

missed some commits

Jun 12 2014, 11:06 PM
talshiri updated the diff for D9442: Allow specifying runtime configuration with --set-config key=value.

--set-config -> --config

Jun 12 2014, 11:05 PM
talshiri abandoned D9488: added arc upgrade --force, which discards all local commits and syncs it up with origin..

Not that useful :D

Jun 12 2014, 11:02 PM
talshiri accepted D9506: Dirty cache of HEAD commit after an amend/range reload.

Oh damn!

Jun 12 2014, 10:43 PM

Jun 11 2014

talshiri accepted D9489: Tweak error and status messages for commit ranges.
Jun 11 2014, 10:58 PM
talshiri added inline comments to D9489: Tweak error and status messages for commit ranges.
Jun 11 2014, 10:52 PM
talshiri updated the diff for D9488: added arc upgrade --force, which discards all local commits and syncs it up with origin..

fixed sloppy newline

Jun 11 2014, 10:03 PM
talshiri retitled D9488: added arc upgrade --force, which discards all local commits and syncs it up with origin. from to added arc upgrade --force, which discards all local commits and syncs it up with origin..
Jun 11 2014, 10:02 PM
talshiri updated the diff for D9369: --range support for git.

send all commits

Jun 11 2014, 9:32 PM
talshiri updated the diff for D9369: --range support for git.
  • getFullGitDiff() now explicitly gets base and head revisions. This provides a slightly cleaner API, and allows fetching a diff against the working copy.
Jun 11 2014, 9:06 PM