Page MenuHomePhabricator

Implement open() and closed() Maniphest tokenizer status functions, plus cleanup

Authored by epriestley on Apr 23 2015, 1:49 PM.



Ref T4100.

  • Make it easy to choose all open or closed tasks.
  • Make "special" tokenizers composable.
  • Get viewer() generating documentation properly.
Test Plan
  • Ran queries with new tokens.
  • Browsed new tokens.
  • Viewed docs on new tokens.
  • Used plain status tokens.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 30077.Apr 23 2015, 1:49 PM
epriestley retitled this revision from to Implement open() and closed() Maniphest tokenizer status functions, plus cleanup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad awarded a token.Apr 23 2015, 2:15 PM

One minor thing is that the "open status" default icon (an unchecked box) looks kind of like a unicode error when shown in context:

I don't know if that will bother anyone but me.

Also, how useful do you guys think min() and max() functions would be for priority? I'm inclined to wait for users to request them since they seem less clearly useful than open() and closed(), but if you'd definitely use them I can build them now.

For example, you could use min(normal) to select all tasks with priority normal or higher.

chad added a comment.Apr 23 2015, 3:18 PM

It's not something I would use day to day, but I could see its use in bigger companies (ones that highly customize priority levels).

btrahan edited edge metadata.Apr 23 2015, 4:58 PM

I like min() and max() but wouldn't use them much here and can easily work around when I do.

btrahan accepted this revision.Apr 23 2015, 5:31 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:31 PM
This revision was automatically updated to reflect the committed changes.