HomePhabricator

Move token rendering into Datasources

Authored by epriestley.

Description

Move token rendering into Datasources

Summary:
Ref T4100. I want to reduce the amount of code duplication that function datasources currently need to wrap some parameter datasource.

For example, ProjectMembersDatasource should really just be a little bit of logic on top of ProjectsDatasource, which should do most of the heavy lifting.

Moving rendering into datasources brings us a step closer to being able to do this.

Test Plan:

  • Rendered normal, function, and invalid tokens.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12457

Details

Committed
epriestleyApr 20 2015, 5:06 PM
Pushed
epriestleyApr 20 2015, 5:13 PM
Reviewer
btrahan
Differential Revision
D12457: Move token rendering into Datasources
Parents
rPa11dab59b0d5: Require TokenizerControl to always have a datasource
Branches
Unknown
Tags
Unknown
Tasks
T4100: Support query parameterization in typeaheads