Paths

Table of Contentst

Differential D12468

Implement readProjectsFromRequest() helper for SearchEngines
ClosedPublic
Actions

Authored by epriestley on Apr 19 2015, 2:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 12:02 AM

	Unknown Object (File)
	Mon, Dec 9, 2:40 PM

	Unknown Object (File)
	Oct 19 2024, 6:20 PM

	Unknown Object (File)
	Oct 18 2024, 11:51 AM

	Unknown Object (File)
	Oct 14 2024, 6:12 PM

	Unknown Object (File)
	Oct 14 2024, 12:00 PM

	Unknown Object (File)
	Oct 1 2024, 3:27 AM

	Unknown Object (File)
	Sep 24 2024, 3:46 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4100: Support query parameterization in typeaheads

Commits

Restricted Diffusion Commit
rPb85f8b91de69: Implement readProjectsFromRequest() helper for SearchEngines

Summary

Ref T4100. This just makes the "specify stuff in query parameters" workflow a little better:

You can now do ?projects=differential,diffusion.
You can now do ?projects=projects(alincoln).

Test Plan

Did that stuff ^^^^

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29922.Apr 19 2015, 2:16 PM

epriestley retitled this revision from to Implement readProjectsFromRequest() helper for SearchEngines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4100: Support query parameterization in typeaheads.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2015, 2:16 PM

btrahan accepted this revision.Apr 20 2015, 4:48 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/phid/PhabricatorPHIDConstants.php
5	Nice, though random ish.

This revision is now accepted and ready to land.Apr 20 2015, 4:48 PM

epriestley added inline comments.Apr 20 2015, 4:53 PM

src/applications/phid/PhabricatorPHIDConstants.php
5	Yeah -- I nuked one elsewhere in this diff and grepped for it and saw no more uses. Not sure why it stuck around so long; must have been a merge issue or maybe we cleaned up the rest of it without realizing it.

Closed by commit rPb85f8b91de69: Implement readProjectsFromRequest() helper for SearchEngines (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

5 lines

phid/

PhabricatorPHIDConstants.php

1 line

project/

typeahead/

PhabricatorProjectLogicalUserDatasource.php

38 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

70 lines

Diff 29959

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...

src/applications/phid/PhabricatorPHIDConstants.php

Loading...

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...