Page MenuHomePhabricator

Implement readProjectsFromRequest() helper for SearchEngines
ClosedPublic

Authored by epriestley on Apr 19 2015, 2:16 PM.

Details

Summary

Ref T4100. This just makes the "specify stuff in query parameters" workflow a little better:

  • You can now do ?projects=differential,diffusion.
  • You can now do ?projects=projects(alincoln).
Test Plan

Did that stuff ^^^^

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Implement readProjectsFromRequest() helper for SearchEngines.Apr 19 2015, 2:16 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 29922.
btrahan edited edge metadata.Apr 20 2015, 4:48 PM
btrahan accepted this revision.
btrahan added inline comments.
src/applications/phid/PhabricatorPHIDConstants.php
5

Nice, though random ish.

This revision is now accepted and ready to land.Apr 20 2015, 4:48 PM
epriestley added inline comments.Apr 20 2015, 4:53 PM
src/applications/phid/PhabricatorPHIDConstants.php
5

Yeah -- I nuked one elsewhere in this diff and grepped for it and saw no more uses.

Not sure why it stuck around so long; must have been a merge issue or maybe we cleaned up the rest of it without realizing it.

This revision was automatically updated to reflect the committed changes.