Differential D12462

Make "user's projects" a logical datasource and add viewerprojects()
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 6:17 PM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T4100: Support query parameterization in typeaheads
T5595: Allow all applications to filter results by project

Commits

Restricted Diffusion Commit
rPf331463d5072: Make "user's projects" a logical datasource and add viewerprojects()

Summary

Ref T4100. Ref T5595. This converts projects(user) into a logical datasource.

Also adds a viewerprojects() logical datasource.

Test Plan

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29910.Apr 18 2015, 6:17 PM

epriestley retitled this revision from to Make "user's projects" a logical datasource and add viewerprojects().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T5595: Allow all applications to filter results by project, T4100: Support query parameterization in typeaheads.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 6:17 PM

btrahan accepted this revision.Apr 20 2015, 4:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2015, 4:44 PM

Closed by commit rPf331463d5072: Make "user's projects" a logical datasource and add viewerprojects() (authored by epriestley). · Explain WhyApr 20 2015, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/__phutil_library_map__.php (10 lines)
V			src/applications/{people/typeahead/PhabricatorUserProjectsDatasource.php → project/typeahead/PhabricatorProjectLogicalUserDatasource.php}
V			src/applications/project/typeahead/{PhabricatorProjectLogicDatasource.php → PhabricatorProjectLogicalDatasource.php}
V			src/applications/project/typeahead/{PhabricatorProjectLogicalDatasource.php ← PhabricatorProjectLogicDatasource.php} (4 lines)
V			src/applications/{project/typeahead/PhabricatorProjectLogicalUserDatasource.php ← people/typeahead/PhabricatorUserProjectsDatasource.php} (25 lines)
A	M		src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php (80 lines)

Diff 29958

src/__phutil_library_map__.php

Loading...

src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php

Loading...

src/applications/project/typeahead/PhabricatorProjectLogicDatasource.php

Loading...

src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php

Loading...

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...

src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php

Loading...