Page MenuHomePhabricator

Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery
ClosedPublic

Authored by epriestley on Apr 18 2015, 2:38 PM.

Details

Summary

Ref T4100. Ref T5595.

To support a unified "Projects:" query across all applications, a future diff is going to add a set of "Edge Logic" capabilities to PolicyAwareQuery which write the required SELECT, JOIN, WHERE, HAVING and GROUP clauses for you.

With the addition of "Edge Logic", we'll have three systems which may need to build components of query claues: ordering/paging, customfields/applicationsearch, and edge logic.

For most clauses, queries don't currently call into the parent explicitly to get default components. I want to move more query construction logic up the class tree so it can be shared.

For most methods, this isn't a problem, but many subclasses define a buildWhereClause(). Make all such definitions protected and consistent.

This causes no behavioral changes.

Test Plan

Ran arc unit --everything, which does a pretty through job of verifying this statically.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29895.Apr 18 2015, 2:38 PM
epriestley retitled this revision from to Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Apr 20 2015, 3:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 3:58 PM
This revision was automatically updated to reflect the committed changes.