Contextually, this is vaguely adjacent to T4100, since I plan to write search user guides next and this saves me from rewriting this stuff after we implement this.

This looks awesome!

dat puzzle piece tho. ?

(patching locally to play with)

Yeah the puzzle piece is a bit sketch ("globe" seemed best for "all documents", but maybe something like "fa-files-o" would work better), and the double-magnifying-glass is even worse, but nothing jumped out at me as clearly the right pick in 10 seconds of looking.

Oh, I see, in the mock I had it dynamic to the application, but really we're just setting a preference.

Yeah, it's just a secret preference.

I could make the menu item say "Current Application (Maniphest)" or whatever, but I worry that will be kind of confusing since you're really setting a preference for "always search the current application, whatever that application might be".

Actually a dynamic icon I don't think would be too confusing. At least, when I'm in Maniphest, I'll see and be reminded its a local search before any dropdown.

Oh, yeah, that's a great idea.

I still need a default icon for when you aren't in an application (e.g., 404 page) or the application isn't searchable (e.g., Auth), do you see a better option than this to get rid of the puzzle piece?

• All Documents
• Curent Application

or

I still like Globe for Global

Maybe move the notice to be after the list of results?

When you get a full page of results it's really easy to miss the notice since it's so far below the fold.

We could try just removing it and see if it's actually confusing. It's possible that it won't be, but I'm worried that's might be too optimistic.

The fa-file-o default icon actually stands out pretty well, so maybe that's enough of a hint. We can try no notice + document behavior and see if users run into trouble?

leeeeeeeroy jenkinssssssss

It's already in production here... wow, looks nothing short of amazing :)

Short thoughts:

• probably do want the "Current Application (Open) option

• Not sure saved searches are useful?

• On non application pages, since we're doing a global search, show globe instead?

probably do want the "Current Application (Open) option

Or maybe "Current Application" should always imply "Open"?

Not sure saved searches are useful?

I use "Open Tasks" as my default; this is the most common (non-typeahead) thing I use global search for by a reasonable margin.

On non application pages, since we're doing a global search, show globe instead?

Maybe -- I worry showing two globes that do different things (although the same thing on the current page) might be confusing rather than helpful.

If we add "Current Application (Open)" as distinct from "Current Application" we'll also have two copies of the same icon that do different things, I suppose.

This still looks weird to me, too (double magnifying glass icons):

Yeah I think custom searches should use the custom icon like in policies.