Page MenuHomePhabricator

In Diffusion, show commit messages as parsed fields by default with an option to view them raw
Open, Needs TriagePublic

Description

When Arcanist creates a commit message, either via amend or land, it formats the usernames included in the message as username instead of @username. It'd be nice if it used the @username format instead, so that the usernames were linked when the commit message was shown in Diffusion.

Event Timeline

edibiase created this task.Nov 4 2015, 8:08 PM
edibiase updated the task description. (Show Details)
edibiase added a project: Arcanist.
edibiase added a subscriber: edibiase.
joshuaspence added a subscriber: joshuaspence.EditedNov 5 2015, 8:30 AM

+1, although an alternative would be for Diffusion/Remarkup to render Reviewers: alincoln identically to Reviewers: @alincoln.

Another alternative would be to mangle the commit message more heavily and strip out the fields we believe we can parse. So instead of showing something like this:

Exact repeat of commit title

blah blah blah blah
blah 

Reviewers: X

Reviewed By: Y

...we'd show the fields we think we know about above as properties (in some cases, we already do, and would probably just hide duplicate fields like "Subscribers"):

  Reviewers: X
Reviewed By: Y
Subscribers: Z

...and then just show whatever else was left as the message:

blah blah blah blah
blah

With a Show Raw Commit Message link somewhere if you want to look at the original.

Ah yeah, that would be better.

epriestley renamed this task from Arcanist commit messages format usernames without a leading "@" to In Diffusion, show commit messages as parsed fields by default with an option to view them raw.Jul 21 2016, 11:47 AM
epriestley edited projects, added Diffusion; removed Arcanist.
epriestley moved this task from Backlog to v3 on the Diffusion board.Jan 1 2017, 4:11 PM
epriestley edited projects, added Diffusion (v3); removed Diffusion.
pasik added a subscriber: pasik.Jun 1 2019, 10:53 AM