Page MenuHomePhabricator
Create Task
Maniphest T9713

In Diffusion, show commit messages as parsed fields by default with an option to view them raw
Open, Needs TriagePublic
Actions

Description

When Arcanist creates a commit message, either via amend or land, it formats the usernames included in the message as username instead of @username. It'd be nice if it used the @username format instead, so that the usernames were linked when the commit message was shown in Diffusion.

On commit view pages, the page title uses the precomputed "summary" text, but could often fit more text than the precomputed summary size.

Generally, if someone pushes a 3GB commit message, Phabricator probably breaks right now. D21574 introduced a getCommitMessageForDisplay() fiction which could handle this some day. The 3GB message shouldn't make it into the database, the full "message" on the Data object should be some long prefix with a total byte count, and the UI should handle warnings like "Only the first 256KB of this huge 3GB commit message are shown."

Related Objects

Event Timeline

edibiase created this task.Nov 4 2015, 8:08 PM
edibiase updated the task description. (Show Details)
edibiase added a project: Arcanist.
edibiase added a subscriber: edibiase.
cburroughs added a subscriber: cburroughs.Nov 4 2015, 8:15 PM
joshuaspence added a subscriber: joshuaspence.EditedNov 5 2015, 8:30 AM

+1, although an alternative would be for Diffusion/Remarkup to render Reviewers: alincoln identically to Reviewers: @alincoln.

epriestley added a subscriber: epriestley.Nov 5 2015, 2:18 PM

Another alternative would be to mangle the commit message more heavily and strip out the fields we believe we can parse. So instead of showing something like this:

Exact repeat of commit title

blah blah blah blah
blah 

Reviewers: X

Reviewed By: Y

...we'd show the fields we think we know about above as properties (in some cases, we already do, and would probably just hide duplicate fields like "Subscribers"):

  Reviewers: X
Reviewed By: Y
Subscribers: Z

...and then just show whatever else was left as the message:

blah blah blah blah
blah

With a Show Raw Commit Message link somewhere if you want to look at the original.

joshuaspence added a comment.Nov 5 2015, 7:21 PM

Ah yeah, that would be better.

epriestley renamed this task from Arcanist commit messages format usernames without a leading "@" to In Diffusion, show commit messages as parsed fields by default with an option to view them raw.Jul 21 2016, 11:47 AM
epriestley edited projects, added Diffusion; removed Arcanist.
epriestley mentioned this in T11407: Make is possible to react to commits being parsed.Jul 31 2016, 10:14 PM
epriestley mentioned this in D16436: When a commit has a "rewritten" hint, show it in the UI instead of the generic "deleted" message.Aug 24 2016, 12:59 PM
epriestley mentioned this in rP498fb331038c: When a commit has a "rewritten" hint, show it in the UI instead of the generic….Aug 24 2016, 4:33 PM
epriestley mentioned this in T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.Nov 12 2016, 4:06 PM
epriestley added a subtask: T7443: Include full link to Maniphest tasks in commit messages.Nov 14 2016, 6:01 PM
epriestley removed a subtask: T7443: Include full link to Maniphest tasks in commit messages.
epriestley mentioned this in T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.Dec 14 2016, 3:16 PM
epriestley mentioned this in T11114: Move Differential to EditEngine.Dec 14 2016, 3:26 PM
epriestley moved this task from Backlog to v3 on the Diffusion board.Jan 1 2017, 4:11 PM
epriestley edited projects, added Diffusion (v3); removed Diffusion.
epriestley mentioned this in T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y".Jan 1 2017, 4:19 PM
epriestley mentioned this in T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure.Jan 18 2017, 6:39 PM
epriestley moved this task from Backlog to Wow! Features! on the Diffusion (v3) board.Feb 2 2017, 3:54 PM
epriestley mentioned this in T12197: Audits are no longer triggered using singular "Auditor:".Feb 3 2017, 2:31 PM
epriestley mentioned this in T12749: Performance test and tune DiffusionHistoryListView.May 26 2017, 4:34 PM
epriestley mentioned this in T12780: Icons look bad in HistoryTableView.May 31 2017, 2:33 AM
epriestley mentioned this in T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.Feb 14 2018, 1:33 AM
• pasik added a subscriber: • pasik.Jun 1 2019, 10:53 AM
Herald added a subscriber: amckinley. · View Herald TranscriptJun 1 2019, 10:53 AM
epriestley mentioned this in T5028: Commit message text formatting in remote git repository (SSH) is not preserved.Feb 24 2020, 7:53 PM
epriestley updated the task description. (Show Details)Apr 30 2021, 4:31 PM
Phabricator · Built by Phacility