Page MenuHomePhabricator

"43 ↗" etc comments should link to the comment on the left side of the screen.
Open, LowPublic

Description

I feel like it'd be a lot more useful if clicking on the "43 ↗" etc comments took you to the view where the comment is on the left side of the screen, not the right side, because you can see if the comment has been addressed.

Event Timeline

This is probably reasonable, but there are a couple of gotchas:

  • Comments on the left hand side of any versus-base diff can not currently be viewed in a "has this been addressed" view, which would be right-of-head versus left-of-origin. This state is currently impossible in the UI, so our options would be something like: link to a versus-base state for these comments (inconsistent); link to an otherwise unreachable state (confusing, and current UI would not properly reflect the state); or add another column of radio buttons allowing you to select the base of each diff (very confusing?).
  • Comments on the right hand side of the head diff obviously can not appear in an "addressed" view because there are no further diffs which can address them.
epriestley added a subscriber: Unknown Object (MLST).Sep 4 2013, 3:12 PM

Via FB.

epriestley added subscribers: sophiebits, csilvers.

T6556 isn't exactly the same, but deals with a similar case. In general, we can sometimes generate more or better links for out-of-date comments, depending on the current view and/or which side of things they appear on.

chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 4:41 AM