Page MenuHomePhabricator

nipunn (Nipunn Koorapati)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 22 2014, 7:46 PM (269 w, 3 d)
Availability
Available

Recent Activity

Dec 31 2016

nipunn created T12052: Dependent revision stack UI showing endpoints incorrectly.
Dec 31 2016, 2:10 AM · Bug Report (Needs Information)

Apr 21 2016

angie awarded D10035: Added popularity-based ranking to macros app (WIP) a Manufacturing Defect? token.
Apr 21 2016, 10:51 PM

Mar 8 2016

dgoldstein awarded T9410: Policy behavior for Herald rules is murky and inconsistent a Orange Medal token.
Mar 8 2016, 11:58 PM · Restricted Project, Herald, Unknown Object (Project)

Feb 13 2016

nipunn planned changes to D10035: Added popularity-based ranking to macros app (WIP).
Feb 13 2016, 1:30 PM
nipunn updated the diff for D10035: Added popularity-based ranking to macros app (WIP).

@jhurwitz and I made some effort toward this mid-last-year, but the backfill script is still not quite working. Figure I'd put up the progress.

Feb 13 2016, 1:30 PM

Jan 14 2016

nipunn added a comment to T10146: Surface lint failures in reviews for a given repository.

There are many existing failures in our codebase. Linting all files would give copious (unhelpful) output. That being said, I haven't tried it because it would (probably) take hours to run. Should I give it a try?

Jan 14 2016, 9:25 PM · Diffusion, Feature Request

Jan 13 2016

nipunn created T10146: Surface lint failures in reviews for a given repository.
Jan 13 2016, 11:19 PM · Diffusion, Feature Request

Jan 12 2016

nipunn created T10137: Add comments to .arclint json.
Jan 12 2016, 9:18 PM · Lint, Feature Request

Dec 12 2015

nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

That prioritization makes sense to me. It doesn't seem worth putting a lot of effort into optimizing the workflow for a bad configuration.

Dec 12 2015, 12:17 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)

Dec 11 2015

nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

I was able to get some metrics for how many revisions have lint errors in this particular project (repo callsign 'C') with this query:

Dec 11 2015, 11:34 PM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)

Dec 9 2015

nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.
  1. In this case I was yes.
  2. We have post-push builds hooked up, but not pre-push for this project in particular. (rely on arc unit)
  3. We have tests only run on affected files, but we have certain files that can trigger a lot of tests.
  4. I'm all for this (reducing some big categories from warning to advice by default). Going to try to make it happen. Would be cool to have a list of "top errors in this project" somewhere to make this process easier.
Dec 9 2015, 1:29 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)
nipunn renamed T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff from During arc land, surface lint/unit excuses from previous arc diff to During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.
Dec 9 2015, 12:56 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)
nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

Ah yes, this should be a feature request and not a bug report. Sorry!

Dec 9 2015, 12:54 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)
nipunn merged task T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed into T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.
Dec 9 2015, 12:53 AM · Harbormaster, Arcanist, Unknown Object (Project), Bug Report
nipunn merged T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed into T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.
Dec 9 2015, 12:53 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)
nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

I saw it as two subproblems

  1. Difficulty remembering whether lint or unit failed
  2. Difficulty remembering excuse for lint failures in particular.
Dec 9 2015, 12:53 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)
nipunn created T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.
Dec 9 2015, 12:30 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Unknown Object (Project)
nipunn updated subscribers of T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed.
Dec 9 2015, 12:20 AM · Harbormaster, Arcanist, Unknown Object (Project), Bug Report
nipunn added a project to T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed: Unknown Object (Project).
Dec 9 2015, 12:19 AM · Harbormaster, Arcanist, Unknown Object (Project), Bug Report
nipunn created T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed.
Dec 9 2015, 12:19 AM · Harbormaster, Arcanist, Unknown Object (Project), Bug Report

Nov 25 2015

nipunn updated the diff for D14528: Increase the maximum size eligible for image transforms configurable from 4MB->16MB.

Fix comment from 10->60

Nov 25 2015, 9:24 AM
nipunn retitled D14528: Increase the maximum size eligible for image transforms configurable from 4MB->16MB from RFC: Make the maximum size eligible for image transforms configurable to Increase the maximum size eligible for image transforms configurable from 4MB->16MB.
Nov 25 2015, 8:53 AM
nipunn updated the diff for D14528: Increase the maximum size eligible for image transforms configurable from 4MB->16MB.

Only change the constants. No extra option

Nov 25 2015, 8:51 AM

Nov 20 2015

nipunn awarded T8227: Why not just add an option/setting/preference? a Like token.
Nov 20 2015, 6:44 AM · Guides
nipunn added a comment to D14528: Increase the maximum size eligible for image transforms configurable from 4MB->16MB.

Increasing seems reasonable to me too. The problem I see is a 4.1MB gif which doesn't get thumbnailed for the pinboard view. It's not a major issue, but it seemed one that was avoidable.

Nov 20 2015, 6:43 AM
nipunn updated the diff for D14528: Increase the maximum size eligible for image transforms configurable from 4MB->16MB.

Running unit tests

Nov 20 2015, 5:20 AM
nipunn retitled D14528: Increase the maximum size eligible for image transforms configurable from 4MB->16MB from to RFC: Make the maximum size eligible for image transforms configurable.
Nov 20 2015, 5:12 AM

Nov 14 2015

nipunn added a comment to T9783: Multiple linters affecting same line, one of which applying autocorrect.

+1. I agree that conflicting rules are un-resolvable (and thus a configuration issue), but in this case, even consistent rules cause an issue.

Nov 14 2015, 12:09 AM · Unknown Object (Project), Lint

Nov 13 2015

nipunn created T9783: Multiple linters affecting same line, one of which applying autocorrect.
Nov 13 2015, 11:29 PM · Unknown Object (Project), Lint

Oct 28 2015

nipunn awarded D14356: Make "arc land" great again a Love token.
Oct 28 2015, 3:48 AM

Sep 14 2015

nipunn closed T9418: Able to accept differential revision twice in a row as Invalid.

Nope totally sounds reasonable.
I think the thing that was weird to me was that I was able to accept from the UI after it was already in an accepted state, but since I had an old session, sure do it twice.

Sep 14 2015, 8:39 PM · Differential, Unknown Object (Project)
nipunn renamed T9418: Able to accept differential revision twice in a row from Able to accept twice in a row to Able to accept differential revision twice in a row.
Sep 14 2015, 7:06 PM · Differential, Unknown Object (Project)
nipunn created T9418: Able to accept differential revision twice in a row.
Sep 14 2015, 7:05 PM · Differential, Unknown Object (Project)
nipunn added a comment to T9026: arc land might identify wrong revision if branch is missing revision.

I honestly am not sure how I ended up in the state where there were two commits against one revision. I was splitting one revision into two and unfortunately, I'm not exactly sure what I did at the time. I believe it was a git rebase -i HEAD^ followed by git add -p followed by git commit and git rebase --continue, but there may have been some more nuance to it.

Sep 14 2015, 5:24 PM · Unknown Object (Project), Arcanist
nipunn added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

Sgtm

Sep 14 2015, 12:45 AM · Restricted Project, Herald, Unknown Object (Project)

Sep 13 2015

nipunn added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

I'm don't see why the number-of-rules is relevant

Sep 13 2015, 11:44 PM · Restricted Project, Herald, Unknown Object (Project)
nipunn added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

Ah you are right. You can see the set of conditions that were checked for the rule.
In my particular case, I wanted to find the rule that was adding me as a subscriber and disable it.
I ended up typing "/herald/rule/(rulenumber)" into my URL bar to get to the page of the rule.

Sep 13 2015, 10:16 PM · Restricted Project, Herald, Unknown Object (Project)
nipunn created T9410: Policy behavior for Herald rules is murky and inconsistent.
Sep 13 2015, 7:54 PM · Restricted Project, Herald, Unknown Object (Project)

Sep 12 2015

nipunn added a comment to T9026: arc land might identify wrong revision if branch is missing revision.

I went back to repro this and realized that my repro steps weren't perfect. On second thought, this seems like an expected behavior, but it still threw me for a bit of a loop. I had created one commit and split it up into two (the first of which was trivial and could skip review). I think the behavior is reasonable - I just didn't realize why it had associated branch A with the revision on branch B.

Sep 12 2015, 7:23 PM · Unknown Object (Project), Arcanist
nipunn updated the task description for T9026: arc land might identify wrong revision if branch is missing revision.
Sep 12 2015, 7:19 PM · Unknown Object (Project), Arcanist

Jul 30 2015

nipunn created T9026: arc land might identify wrong revision if branch is missing revision.
Jul 30 2015, 10:37 PM · Unknown Object (Project), Arcanist

Jul 13 2015

nipunn added a comment to T8833: Branch state not preserved during arc land with a failed pre-receive hook.

As a tangent, this flow also leaks slightly in that the end of arc land output says "you can get this commit back by..." and the SHA that it tells you is the SHA of the merged commit, not the tip of the branch that you originally had.

Jul 13 2015, 11:37 PM · Unknown Object (Project), Arcanist
nipunn created T8833: Branch state not preserved during arc land with a failed pre-receive hook.
Jul 13 2015, 7:29 PM · Unknown Object (Project), Arcanist

Jun 12 2015

nipunn added a comment to T8520: Cannot disable email during batch operations.

Sure. I'll try to describe the problem we ran into.

Jun 12 2015, 9:05 PM · Unknown Object (Project)
nipunn created T8521: Batch removing maniphest subscriber via batch editor is slow.
Jun 12 2015, 12:50 AM · Unknown Object (Project)
nipunn created T8520: Cannot disable email during batch operations.
Jun 12 2015, 12:46 AM · Unknown Object (Project)

Apr 11 2015

nipunn created T7805: Use ApplicationSearch in the ObjectSelector dialog.
Apr 11 2015, 3:30 AM · Restricted Project, Unknown Object (Project), ApplicationSearch

Feb 28 2015

joshuaspence awarded D10035: Added popularity-based ranking to macros app (WIP) a Piece of Eight token.
Feb 28 2015, 12:57 AM

Dec 12 2014

lfaraone awarded D10035: Added popularity-based ranking to macros app (WIP) a Like token.
Dec 12 2014, 10:22 PM

Sep 23 2014

nipunn retitled D10540: Revisionss -> revision from to Revisionss -> revision.
Sep 23 2014, 12:25 AM

Sep 18 2014

nipunn updated the diff for D10035: Added popularity-based ranking to macros app (WIP).

Got the backfill migration script to work on DifferentialTransactionComment.
Still can't quite get it working in the general case. I feel like I misunderstand
PhabricatorApplicationTransaction and PhabricatorApplicationTransactionComment
Thx

Sep 18 2014, 5:52 PM

Aug 30 2014

nipunn updated the diff for D10035: Added popularity-based ranking to macros app (WIP).

Moved logic to remarkup rules.
Couldn't quite get the backfill migration script working. Looking for some help there.
Otherwise, it works great.

Aug 30 2014, 11:33 AM

Aug 5 2014

nipunn updated subscribers of D10035: Added popularity-based ranking to macros app (WIP).
Aug 5 2014, 7:28 AM

Jul 24 2014

nipunn added a comment to D10035: Added popularity-based ranking to macros app (WIP).

Macro was targeted at myself of course

Jul 24 2014, 7:52 AM
nipunn added a comment to D10035: Added popularity-based ranking to macros app (WIP).

uglyhack

Jul 24 2014, 7:52 AM
nipunn retitled D10035: Added popularity-based ranking to macros app (WIP) from to Added popularity-based ranking to macros app (WIP).
Jul 24 2014, 7:40 AM
nipunn abandoned D10034: Pin the macro app by default..

Hey cool!

Jul 24 2014, 6:09 AM
nipunn retitled D10034: Pin the macro app by default. from to Pin the macro app by default..
Jul 24 2014, 5:12 AM