Page MenuHomePhabricator

Undefined index in changeset parser
Closed, ResolvedPublic

Description

[17-Jun-2015 18:41:52 Australia/Sydney] [2015-06-17 18:41:52] ERROR 8: Undefined index:  at [/usr/src/phabricator/src/applications/differential/parser/DifferentialChangesetParser.php:953]
[17-Jun-2015 18:41:52 Australia/Sydney] arcanist(head=master, ref.master=9a7c4d87a850), phabricator(head=master, ref.master=ca8adac1eb40, custom=1), phlab(head=master, ref.master=36469f5efae6), phutil(head=master, ref.master=3b4da3f33153)
[17-Jun-2015 18:41:52 Australia/Sydney]   #0 DifferentialChangesetParser::render(NULL, NULL, array) called at [<phabricator>/src/applications/differential/parser/DifferentialChangesetParser.php:72]
[17-Jun-2015 18:41:52 Australia/Sydney]   #1 DifferentialChangesetParser::renderChangeset() called at [<phabricator>/src/applications/differential/controller/DifferentialChangesetViewController.php:258]
[17-Jun-2015 18:41:52 Australia/Sydney]   #2 DifferentialChangesetViewController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:226]
[17-Jun-2015 18:41:52 Australia/Sydney]   #3 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:140]
[17-Jun-2015 18:41:52 Australia/Sydney]   #4 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:21]

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Differential.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.

No clue how to reproduce this.

I've got a reproduction case for this now: https://secure.phabricator.com/differential/diff/44008/

It seems that it is something to do with a synthetic comment with no line number.

epriestley claimed this task.

The diff above no longer reproduces this, and I think an equivalent to D18302 landed in D21178. T13524 was almost certainly the same issue.