Root problem: include a phpunit output in a commit message
Reproduction steps
- Create a revision
- Add the following text through the web UI to Test plan: field
… Test plan: ` ` ` $ phpunit […] OK, but incomplete, skipped, or risky tests! Tests: 181, Assertions: 328, Incomplete: 2. ` ` ` …
- Try arc diff.
Expected result
As it's enclosed in ` block, not to be parsed by Arcanist.
Actual result
Arcanist is more than happy to parse it.
[2016-12-31 03:29:41] EXCEPTION: (ArcanistDifferentialCommitMessageParserException) Field "testPlan" occurs twice in commit message! at [<arcanist>/src/differential/ArcanistDifferentialCommitMessage.php:54] arcanist(head=master, ref.master=c243cbbd9fc7), phutil(head=master, ref.master=5ac2ca121489) #0 ArcanistDifferentialCommitMessage::pullDataFromConduit(ConduitClient) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1795] #1 ArcanistDiffWorkflow::getCommitMessageFromRevision(string) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1527] #2 ArcanistDiffWorkflow::buildCommitMessage() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:469] #3 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]