I don't recall all the history here, but I seem to recall --signoff was a feature added to git for reviewing linux kernel patches.

Hrrm, I would have expected this to associate. We did some work here recently (T5693 / T3686) on the Differential side ("Why did this associate?") but don't currently expose a link on the Diffusion side to see the other half of the story ("Why didn't this associate?").

I suspect this probably isn't just a parse issue, but it's possible that it's that simple.

Does this reproduce at all?

I'd guess environment / install issues before a general, reproducible problem.

In T6483#82485, @chad wrote:

I don't recall all the history here, but I seem to recall --signoff was a feature added to git for reviewing linux kernel patches.

Yeah, this originated for use in combination with the context of the DCO (http://elinux.org/Developer_Certificate_Of_Origin) about a decade ago, but this convention has been adopted by other projects as well, and the --signoff feature make this convenient to use.

In T6483#82500, @btrahan wrote:

Does this reproduce at all?

I'd guess environment / install issues before a general, reproducible problem.

I'll keep an eye on it. It's the first time I noticed Differential not picking up a code-rev reference, and it happened to be in combination w/ a Signed-off-by annotation. (and btw, I never use arc land (so I don't think this issue concerns Arcanist?), I rather always manually git push, and that has worked perfectly fine so far, except in combination with this Signed-off-by field)

./bin/phd log

this may be illuminating in terms of potential parsing errors.

btw, found another such case in our history pushed by @thoughtpolice

https://phabricator.haskell.org/rGHCf9ca529d3b35f24e7d4193489f48609584bd5a37