Page MenuHomePhabricator
Feed All Stories

Apr 21 2017

chad merged task T12615: Make Phriction ToC more structured into T9379: Build Phriction v3.
Apr 21 2017, 2:17 PM · Feature Request
chad added a comment to T12615: Make Phriction ToC more structured.

We already have a path forward on the next iteration of Phriction, and it doesn't include this direction. Please read Contributing Feature Requests and Describing Root Problems if you have future feature suggestions, root problems are required for any request filed. Thanks!

Apr 21 2017, 2:17 PM · Feature Request
epriestley added a comment to T12612: Design (and possibly implement) production rate limiting controls.

Here's what we currently have:

Apr 21 2017, 2:02 PM · Phacility, Ops
NDKilla added a member for Space Test Users: NDKilla.
Apr 21 2017, 1:43 PM
epriestley lowered the priority of T12612: Design (and possibly implement) production rate limiting controls from High to Normal.
Apr 21 2017, 12:49 PM · Phacility, Ops
epriestley shifted T12612: Design (and possibly implement) production rate limiting controls from the Restricted Space space to the S1 Core space.
Apr 21 2017, 12:49 PM · Phacility, Ops
epriestley added a comment to T12612: Design (and possibly implement) production rate limiting controls.

I'm going to kick this out of the ops space since none of this should be sensitive.

Apr 21 2017, 12:49 PM · Phacility, Ops
epriestley added a comment to T12616: Modernize display code for inline comments.

On mobile, I'd probably just keep this element in a fixed position on the page

Apr 21 2017, 12:47 PM · Inline Comments
epriestley updated subscribers of T12616: Modernize display code for inline comments.

@chad, some design stuff I'm thinking for later on, about in case you have feedback/ideas/objections:

Apr 21 2017, 12:45 PM · Inline Comments
epriestley added a project to T8250: Would like to see all comments and their status in a list: Inline Comments.
Apr 21 2017, 12:31 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley created T12616: Modernize display code for inline comments.
Apr 21 2017, 12:30 PM · Inline Comments
epriestley moved T802: "43 ↗" etc comments should link to the comment on the left side of the screen. from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T1026: Request: ability to select line range for comment via touchscreen from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T5030: Improve behavior when jumping to inline comments from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Restricted Project, Differential
epriestley moved T7682: JS Errors when mousing over image diff comments, right side only from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Differential
epriestley moved T8420: Hidden inlines don't work properly with anchor-based navigation from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:25 PM · Inline Comments, Restricted Project, Differential
epriestley moved T10563: Inline comments displayed on the same line are shown in creation order without regard for threading from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:24 PM · Inline Comments, Differential, Restricted Project
epriestley added a comment to T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.

I'm going to fix the editor behavior and then call this done.

Apr 21 2017, 12:24 PM · Inline Comments, Differential, Restricted Project
epriestley moved T9269: Undoing multiple inline comments on the same line will restore the comment out of position. from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:24 PM · Inline Comments, Differential
epriestley moved T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Differential
epriestley moved T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Differential
epriestley moved T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Restricted Project, Differential
epriestley moved T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Differential, Feature Request
epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley moved T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Differential, Bug Report
epriestley moved T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Customer Impact, Differential
epriestley moved T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:22 PM · Inline Comments, Differential, Bug Report
epriestley moved T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:22 PM · Inline Comments, Differential, Bug Report
epriestley moved T11401: Add ability to quote, edit, view raw, view history, and remove inline comments from Backlog to Future on the Inline Comments board.
Apr 21 2017, 12:22 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a project to T5030: Improve behavior when jumping to inline comments: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential
epriestley added a project to T5654: Show more context for inline comments in Differential timeline: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley added a project to T1026: Request: ability to select line range for comment via touchscreen: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T802: "43 ↗" etc comments should link to the comment on the left side of the screen.: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T5232: Keyboard shortcut to create inline comment: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T7682: JS Errors when mousing over image diff comments, right side only: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential
epriestley added a project to T8130: Keyboard shortcut for "Done": Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential
epriestley added a project to T8131: Clicking "Done" breaks keyboard navigation: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential
epriestley added a project to T8909: Provide ability to hide all inline or done comments: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley added a project to T9269: Undoing multiple inline comments on the same line will restore the comment out of position.: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T8420: Hidden inlines don't work properly with anchor-based navigation: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential
epriestley added a project to T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential
epriestley added a project to T10563: Inline comments displayed on the same line are shown in creation order without regard for threading: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential, Restricted Project
epriestley added a project to T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential
epriestley added a project to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?): Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential, Feature Request
epriestley added a project to T11093: DifferentialInlineCommentEditor retains state across Quicksand requests: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley added a project to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential, Bug Report
epriestley added a project to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a project to T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Customer Impact, Differential
epriestley added a project to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential, Bug Report
epriestley added a project to T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Differential, Bug Report
epriestley created Inline Comments.
Apr 21 2017, 12:20 PM
epriestley merged T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) into T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.
Apr 21 2017, 12:04 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley merged task T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) into T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.
Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a comment to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).

I'm just going to merge this into T11401, at least for the moment. That may eventually split out into application-specific tasks when it gets underway.

Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley closed T3960: Add capability to hide lint messages when viewing a diff as Wontfix.

If you experience this, please file a new task explaining what specific messages you're encountering and why hiding these messages is a better solution than changing the linters to raise more relevant messages. I believe fixing the linters is always a better approach here.

Apr 21 2017, 12:01 PM · Restricted Project, Differential
epriestley closed T3462: In Differential, expose "featurename (branched from master)" via Conduit as Wontfix.

Actually, I'm just going to WONTFIX this. We may actually fix it, but I don't currently see a legitimate use case for it described anywehre.

Apr 21 2017, 11:51 AM · Differential, Arcanist
epriestley closed T3462: In Differential, expose "featurename (branched from master)" via Conduit, a subtask of T6486: Pending Differential Revisions isn't filtered by branch, as Wontfix.
Apr 21 2017, 11:51 AM · Diffusion
epriestley renamed T3462: In Differential, expose "featurename (branched from master)" via Conduit from Show "Branch: featurename (branched from master)" in Differential UI, conduit to In Differential, expose "featurename (branched from master)" via Conduit.
Apr 21 2017, 11:43 AM · Differential, Arcanist
epriestley closed T10607: Remote target/landing branch in Diff details as Resolved.

My expectation is that the workflow in the task description will generally show this:

Apr 21 2017, 11:41 AM · Restricted Project, Differential, Feature Request
epriestley added a comment to T7470: show the base branch name in Differential revision info.

Actually, that description is a little misleading, but I'll follow up in T10607.

Apr 21 2017, 11:31 AM · Differential
epriestley merged T7470: show the base branch name in Differential revision info into T10607: Remote target/landing branch in Diff details.
Apr 21 2017, 11:26 AM · Restricted Project, Differential, Feature Request
epriestley merged task T7470: show the base branch name in Differential revision info into T10607: Remote target/landing branch in Diff details.
Apr 21 2017, 11:26 AM · Differential
epriestley added a comment to T7470: show the base branch name in Differential revision info.

I'm going to merge this into T10607.

Apr 21 2017, 11:26 AM · Differential
epriestley moved T12109: Updating revision reverts description changes, if you edit the description while `arc` is running from Branch Handling to Far Future Work on the Differential board.
Apr 21 2017, 11:23 AM · Differential, Bug Report
epriestley added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

I can't reproduce this:

Apr 21 2017, 11:09 AM · Diffusion, Bug Report
p_sakzhang updated Q611: the author of common users' revision is still administrator from to the author of common users' revision is still administrator.
Apr 21 2017, 9:44 AM
benwick updated the task description for T12615: Make Phriction ToC more structured.
Apr 21 2017, 9:16 AM · Feature Request
benwick awarded T5427: Force a line break in a table cell a Like token.
Apr 21 2017, 9:15 AM · Remarkup
benwick created T12615: Make Phriction ToC more structured.
Apr 21 2017, 9:15 AM · Feature Request
kay54068 moved T5523: Make bulk moves easier on Workboards from Workboards v2 to Backlog on the Workboards board.
Apr 21 2017, 8:29 AM · Restricted Project, Workboards
kay54068 moved T5523: Make bulk moves easier on Workboards from Backlog to Workboards v2 on the Workboards board.
Apr 21 2017, 8:29 AM · Restricted Project, Workboards
kevinchea created T12614: Add file transform unit tests.
Apr 21 2017, 7:05 AM · Bug Report
chad placed T11726: Durable Column "minimized" should notify you of new messages in rooms up for grabs.
Apr 21 2017, 4:34 AM · Conpherence (v4)
chad closed T10390: Dashboards v2 (UX) as Resolved.
Apr 21 2017, 4:33 AM · Dashboards (v2)
chad placed T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned up for grabs.
Apr 21 2017, 4:33 AM · Dashboards, Bug Report
k_kazu updated the task description for T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
Apr 21 2017, 3:45 AM · Diffusion, Bug Report
k_kazu created T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
Apr 21 2017, 3:32 AM · Diffusion, Bug Report

Apr 20 2017

amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

This is also prrrrobably an awful idea, but in theory we could put, say, HAProxy on each host in front of Apache and have it queue connections while Apache was restarting. That feels like we're building a really flimsy house of cards, but it's something computers could technically do.

Apr 20 2017, 10:55 PM · Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

This is also prrrrobably an awful idea, but in theory we could put, say, HAProxy on each host in front of Apache and have it queue connections while Apache was restarting. That feels like we're building a really flimsy house of cards, but it's something computers could technically do.

Apr 20 2017, 10:49 PM · Phacility
epriestley closed T12609: Prevent arc land when unit tests or build fails as Resolved.

Cool. Harbormaster integration will also give you other UI hints like these, to help communicate build status to reviewers so they don't accept a change which has failed or in-progress builds:

Apr 20 2017, 10:46 PM · Feature Request
jessjohnson added a comment to T12609: Prevent arc land when unit tests or build fails.

Yes, it would. We haven't fully integrated the build system with Phabricator, but I'll review the docs and see how much more work we need to do.

Apr 20 2017, 10:25 PM · Feature Request
epriestley added a comment to T12562: Make substantially more Conpherence thread rendering occur in Javascript.

This isn't the end of the world, but it's pretty bad if you have a mixture of private and less-private threads (sidebar state and main panel state are inconsistent).

Apr 20 2017, 10:23 PM · Conpherence (v4)
epriestley added a comment to T12609: Prevent arc land when unit tests or build fails.

If you integrate with Harbormaster, users will be prompted explicitly when they try to arc land a revision with build failures:

Apr 20 2017, 10:22 PM · Feature Request
jessjohnson added a comment to T12609: Prevent arc land when unit tests or build fails.

Engineers are not hitting a prompt when landing, they are disregarding the unit test failure message or not reviewing why the build failed. Since the build failure is on an external system, the engineer needs to view this information separately (the system posts a comment why the build failed). The overall goal of a herald rule blocking the land is so that owner can communicate that checking in code without running or successful unit tests is not cool.

Apr 20 2017, 10:17 PM · Feature Request
epriestley created T12612: Design (and possibly implement) production rate limiting controls.
Apr 20 2017, 9:22 PM · Phacility, Ops
epriestley created T12611: Write Phabricator HTTP and SSH logs in the production cluster.
Apr 20 2017, 9:20 PM · Phacility, Ops
epriestley added a comment to T12609: Prevent arc land when unit tests or build fails.

Can you provide some more context about why engineers are hitting the "builds failed" prompt, and continuing through it anyway with failing tests and/or nonbuilding code?

Apr 20 2017, 9:02 PM · Feature Request
epriestley added a comment to T12610: Audit behavior of LB healthchecks against *.phacility.com and secure.phabricator.com.

The current ruleset implements all those rules correctly, except that it 200's directly for /status/.

Apr 20 2017, 8:55 PM · Ops, Phacility
epriestley added a comment to T12610: Audit behavior of LB healthchecks against *.phacility.com and secure.phabricator.com.

redirect to Javelin

Apr 20 2017, 8:55 PM · Ops, Phacility
epriestley added a comment to T12610: Audit behavior of LB healthchecks against *.phacility.com and secure.phabricator.com.

On secure, two not-so-great fixes are:

Apr 20 2017, 8:54 PM · Ops, Phacility
amckinley created T12610: Audit behavior of LB healthchecks against *.phacility.com and secure.phabricator.com.
Apr 20 2017, 8:50 PM · Ops, Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

Sounds good.

Apr 20 2017, 8:49 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

I'll file a task for "unfuck status check".

Apr 20 2017, 8:48 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

I think you might need to send a Host header to trigger the RedirectMatch... but the LB certainly isn't; it just knows IP/port/path. ¯\_(ツ)_/¯

Apr 20 2017, 8:48 PM · Phacility