Page MenuHomePhabricator

Pending Differential Revisions isn't filtered by branch
Closed, WontfixPublic

Description

When I browse a repository in Diffusion, I can get to the list of pending revisions by navigating to the repository and then clicking on one of the branches. This implies that the list of pending revisions should be filtered by branch (presumably by the branch onto which the revision will eventually land). However, this is is the same for any branch, which is a little confusing - I navigate to see the history of status of a very restricted support branch that should have almost nothing going on, but I see a bunch of pending revisions, none of which actually have anything to do with the branch I'm looking at.

It would be good to either actually do the filtering, so that frozen branches really look like they have no activity or just move this display to be repository-wide, rather than per branch.

Event Timeline

anton.vladimirov raised the priority of this task from to Needs Triage.
anton.vladimirov updated the task description. (Show Details)
anton.vladimirov added a subscriber: anton.vladimirov.
epriestley triaged this task as Wishlist priority.Nov 6 2014, 11:05 PM
epriestley added a subscriber: epriestley.

I think we're going to convert this to "Recent Pending Differential Revisions" at a minimum, and only show stuff updated in the last couple of weeks. That should help with some cases of this, although not the specific case mentioned here (see T5658).

This is hard in the general case because we don't store a "Most Recent Ancestor Upstream Branch" (see T3462).

So maybe just reconsidering the location of this in the UI would help?

epriestley claimed this task.

We haven't seen other users run into difficulty with this in the last couple of years, so I don't currently plan to change it.

The view in question is showing commits affecting the current directory. That directory is also on a branch, but there is no alternate view to move it to -- it's impossible to look at the state of the repository outside of any branch. There is no "repository-wide" view -- the top level view is showing the default repository branch (usually master).

I also think it's fairly reasonable to show revisions across all branches -- if you're looking at src/applications/phame/, it seems useful/interesting to know that active Phame development is happening in other branches.

(The view itself has been updated a bit in the intervening time.)