| epriestley | |
| Feb 19 2016, 3:20 PM |
| F4237328: extra-thinking.jpg | |
| Mar 21 2017, 10:47 PM |
| F4236527: thinking-face.png | |
| Mar 21 2017, 9:17 PM |
| F2638262: pasted_file | |
| Feb 7 2017, 5:02 PM |
Dashboard v2 Game Plan ™
| rP Phabricator | |||
| D17529 Remove "Add Existing Panel" from dashboard arrange view | |||
| D17492 Basic "Install Dashboard" workflow | |||
| D17528 | rP5e423c5fe021 Provide a 'no dashboards' fallback state if you can't add any | ||
| D17527 | rP3a838ba31269 Add Dashboards as a default pinned application | ||
| D17526 | rPd6f7da868506 Add some new Dashboard icons | ||
| D17524 | rP7d4c0f002f11 Allow searching Dashboards by Editable | ||
| D17393 | rP568a3877d17b Simplify dashboard panel creation | ||
| D17341 | rPbf44210dc8f1 Reduce application search engine results list for Dashboards | ||
| D17348 | rP2c09fc56051b Make Panels slightly easier to find and use | ||
| D17338 | rP554c4f10c5df Remove Copy Dashboard | ||
| D17326 | rPd1c253de9452 Touch up basic usability of Dashboards | ||
@epriestley I think for Dashboards, and probably other applications, having some sort of compound typeahead/select would be helpful. I think maybe we can abstract this into using ApplicationSearch as the filter, and the tokenizer for the final results. Thoughts?
Generally makes sense to me.
Are there other places where we'd use it? I can't immediately come up with any cases where we have a large number of ambiguous/similarly-named results.
One potential product issue is that the best default filter for tokenizers and the best default filter for normal ApplicationSearch may differ. We run into this with T7805, too.
For example, the default ApplicationSearch filter in Maniphest is "Assigned", but the best default filter for "Merge Duplicates In..." is probably "All Open Tasks, Most Recently Created First". I'm not sure what the best way to tackle this is, or how common it is. "Authored Dashboards" is probably the best default filter in most cases.
One thing I'd like to bring back is "Install" in some fashion, which is easy to prompt and do the legwork on landing it on a home or project menu, but doesn't seem we can let you know where a dashboard is used and if you have it installed.
There's currently no way to query that, since the dashboardPHID is in a JSON blob in the PhabricatorProfileMenuItemConfiguration table.
You could add a keyed column like referencePHID, let MenuItem emit it when the MenuItemConfiguration is saved, migrate existing items, then query for configurations.
It also seems tricky to go from a profilePHID to a human-readable description of where the item is installed. If an item is in the Favorites menu it will have PHID-APPS-PhabricatorFavoritesApplication or whatever as the profilePHID, and you can load that object or the handle for that object and get "Favorites (Application)" out of it, but that's probably not terribly comprehensible to a normal user (versus human-readable text like "This dashboard is currently installed in your Favorites menu."). But I guess you could just hard-code that for now
I'm fine with getting rid of the template, I think it's much less relevant now that home is no longer a single dashboard.
