Page MenuHomePhabricator

Updating revision reverts description changes, if you edit the description while `arc` is running
Open, WishlistPublic

Description

Steps to repro:

  • Edit a description of a revision
  • arc diff an updated revision to it

Event Timeline

There was previously a shouldOverwriteWhenBlahBlah() method that probably didn't get transitioned forward cleanly.

Actually I can't reproduce this? I did this:

  • Create a revision with arc diff, with a summary ("Summary 1").
  • From the web UI, edit the summary ("Summary 2").
  • From the CLI again, update with arc diff.

The summary stayed put ("Summary 2") across updates:

Screen Shot 2017-01-16 at 1.21.24 PM.png (286×1 px, 55 KB)

D17209 reverted on me twice if you look at the transaction logs. I can try again. Basically I'd start arc diff, which takes 1-2 minutes on my server, go edit the form, then arc diff would actually land, the changes would be reverted. Maybe it's that I started arc diff then made changes?

Starting arc diff and then making changes probably races, although I think that's likely pre-existing. I can look at it when arc gets another update, but I think we can't really fix it on the server side.

epriestley renamed this task from Updating revision reverts description changes to Updating revision reverts description changes, if you edit the description while `arc` is running.Jan 16 2017, 9:35 PM
epriestley removed chad as the assignee of this task.
epriestley triaged this task as Wishlist priority.