Page MenuHomePhabricator
Feed Advanced Search

Thu, Aug 9

epriestley closed T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale as Resolved by committing rP6df278bea84a: In "bin/ssh-auth", cache a structure instead of a flat file because paths may….
Thu, Aug 9, 8:33 PM · Bug Report

Wed, Aug 8

epriestley added a revision to T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale: D19568: In "bin/ssh-auth", cache a structure instead of a flat file because paths may change at runtime.
Wed, Aug 8, 5:21 PM · Bug Report

Mon, Aug 6

epriestley renamed T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale from `bin/ssh-auth` uses stale caches for its response to `bin/ssh-auth` cache includes paths which may be (or may become) stale.
Mon, Aug 6, 10:44 PM · Bug Report
epriestley raised the priority of T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale from Wishlist to Normal.
Mon, Aug 6, 10:44 PM · Bug Report
epriestley added a comment to T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale.

See PHI801. This is a similar case to the one above, but I think the underlying use case was a bit more compelling: the install was transitioning from a set of older web nodes to newer web nodes as a part of a general infrastructure upgrade, and making various fixes to the deployment and support software as part of that process. One aspect of these adjacent fixes was changing the path from /something/something/phabricator to /something-else/something-else/phabricator (I think as a consequence of adjusting deploy strategy), so newer nodes would have a different absolute path than older nodes. Both sets of nodes were in production simultaneously.

Mon, Aug 6, 10:44 PM · Bug Report

Wed, Aug 1

urzds added a comment to T11827: ssh-auth hangs on FreeBSD.

The workaround does not work for me on Debian 9.5 with OpenSSH 7.4p1.

Wed, Aug 1, 3:42 PM · Diffusion, Bug Report

Mon, Jul 30

epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19548: Possibly increase the width of the S3 -> Files -> Client pipeline.
Mon, Jul 30, 7:51 PM · Bug Report
epriestley added a commit to T12907: Unable to download large files through alternative file domain: rP58e8d3c13479: (stable) Remove the execution time limit (if any) before sinking HTTP responses.
Mon, Jul 30, 5:57 PM · Bug Report
epriestley added a commit to T12907: Unable to download large files through alternative file domain: rP81a7c9ac43f2: Remove the execution time limit (if any) before sinking HTTP responses.
Mon, Jul 30, 5:56 PM · Bug Report
epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19547: Remove the execution time limit (if any) before sinking HTTP responses.
Mon, Jul 30, 4:45 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

We have a more reliable break for this now, in the form:

Mon, Jul 30, 4:10 PM · Bug Report

Thu, Jul 26

epriestley added a comment to T12907: Unable to download large files through alternative file domain.

I can't get anything to break at all now. 💁

Thu, Jul 26, 7:39 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

I made a change like this to split responses into small blocks and give each a random chance of failing (I tried 4096 and 4027, a prime near 4KB, as miniblock sizes):

Thu, Jul 26, 6:35 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

A recent, probably more concrete issue that I've seen is that wget of a large file can succeed (wget automatically resumes) but we can end up with a file that has different content than the original, which is disastrously bad.

Thu, Jul 26, 5:58 PM · Bug Report

Jul 16 2018

monufer updated the task description for T12334: Arc land is not enforcing Herald Rule.
Jul 16 2018, 5:00 PM · Bug Report

Jun 7 2018

DragonBe added a comment to T12785: Arc unit command fails with PHPUnit 6.

Confirmed on PHPUnit 7.2.2 👍

Jun 7 2018, 1:36 PM · Arcanist, Bug Report

May 24 2018

epriestley closed T12613: In diffusion hosting subversion repository, several commands do not return (freeze). as Resolved.
May 24 2018, 2:19 PM · Diffusion, Bug Report
k_kazu added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

This problem fixed by T13140. Thank you.

May 24 2018, 11:25 AM · Diffusion, Bug Report

May 8 2018

Herald updated subscribers of T12814: pholio transaction emails have too much html.
May 8 2018, 12:05 PM · Pholio, Transactions, Bug Report

Apr 4 2018

epriestley closed T10398: Phabricator UI uses deprecated <tt> tag as Wontfix.

Since there's no known actual problem with this today, I don't plan to fix it.

Apr 4 2018, 2:11 PM · Remarkup, Bug Report
epriestley closed T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax as Wontfix.

I don't currently plan to change the remaining edge case behaviors since I'm not sure they ever occur in the wild.

Apr 4 2018, 1:59 PM · Remarkup, Bug Report

Apr 3 2018

tekacs added a comment to T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull.

Duplicate of T8936?

Apr 3 2018, 1:05 PM · Customer Impact, Git, Bug Report

Mar 30 2018

dereckson added a comment to T12785: Arc unit command fails with PHPUnit 6.

I confirm the Maxime Corteel patch to be working with PHPUnit 7.0.1 too.

Mar 30 2018, 4:03 PM · Arcanist, Bug Report

Mar 29 2018

epriestley closed T12759: Creating an Owners package before creating any repositories shows a blank select when adding paths to the package as Resolved.

I think this is sort of less bad/weird now, at least. You get a tokenizer instead, which is still empty, but you're prompted to "Type a repository name..." and the UI isn't this odd empty select thing anymore.

Mar 29 2018, 6:27 PM · Bug Report

Mar 21 2018

epriestley closed T11145: Dialog submit buttons don't disable on click as Resolved by committing rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:58 PM · Restricted Project, PHUI, Bug Report
epriestley added a revision to T11145: Dialog submit buttons don't disable on click: D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:55 PM · Restricted Project, PHUI, Bug Report

Mar 16 2018

1stone added a comment to T12727: Mail handler unable to parse e-mail from MS Outlook 12, Failed to JSON encode value.

is there a chance that this problem will get fixed?
The change D17989 is already from May 2017 without any reviewer...

Mar 16 2018, 2:49 PM · Bug Report

Mar 14 2018

epriestley closed T9972: Profile image from Google not being picked up as Wontfix.
Mar 14 2018, 5:11 PM · Auth, Bug Report

Mar 7 2018

epriestley closed T11015: Owners has perplexing behavior when directory paths are not terminated with a slash as Resolved.

I believe the behavior of this UI should generally align well with what reasonable users might expect, now. In particular, /src/backend and /src/backend/ are now exactly the same in terms of actually resolving ownership, although the UI will continue to show you the value you entered (to avoid confusion where someone types /docs/README.md and the UI echoes back /docs/README.md/ and they have a reasonable concern that the path wasn't understood).

Mar 7 2018, 4:54 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rP516aaad3410c: Use "pathIndex" in some owners package queries to improve query plans.
Mar 7 2018, 4:33 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rPdf1e9ce646c0: Treat Owners paths like "/src/backend" and "/src/backend/" identically.
Mar 7 2018, 4:31 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rPadde4089b49b: Allow owners paths to be arbitrarily long and add storage for display paths.
Mar 7 2018, 4:31 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rP8cb273a0532b: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>".
Mar 7 2018, 4:31 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rP1bf4422c749c: Add and populate a `pathIndex` column for OwnersPath.
Mar 7 2018, 4:30 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19185: Use "pathIndex" in some owners package queries to improve query plans.
Mar 7 2018, 4:28 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19184: Treat Owners paths like "/src/backend" and "/src/backend/" identically.
Mar 7 2018, 4:14 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19183: Allow owners paths to be arbitrarily long and add storage for display paths.
Mar 7 2018, 3:54 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19182: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>".
Mar 7 2018, 3:47 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19181: Add and populate a `pathIndex` column for OwnersPath.
Mar 7 2018, 3:37 AM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Probably better is to add pathIndex

Mar 7 2018, 3:25 AM · Owners, Bug Report
epriestley added a commit to T12787: Creating a subtask 'reopens' the new task: rPe57dbcda336a: Hide "abraham landed Dxyz irresponsibly" stories from feed.
Mar 7 2018, 1:48 AM · Feed, Bug Report
epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: D19179: Hide "abraham landed Dxyz irresponsibly" stories from feed.
Mar 7 2018, 1:41 AM · Feed, Bug Report

Mar 5 2018

epriestley moved T10608: Arc diff failing to generate diff with svn 1.9.3 from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:19 PM · Arcanist, Bug Report
epriestley moved T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:17 PM · Lint, Arcanist, Bug Report
epriestley moved T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12785: Arc unit command fails with PHPUnit 6 from Backlog to Unit/Lint Bindings on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Mercurial, Bug Report

Feb 26 2018

epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

See T13092; tangentially, it might be nice to render these stories more explicitly as "X added Y, removed Z (because Z is a subproject of Y, and objects may not be tagged with multiple mutual ancestors/descendant projects)", if some sufficiently terse phrasing can be found.

Feb 26 2018, 6:17 PM · Bug Report

Feb 21 2018

epriestley moved T10635: Loading differential revision slow when lots of unit test messages exist from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:40 PM · Restricted Project, Haskell.org, Harbormaster, Performance, Bug Report

Feb 16 2018

epriestley added a commit to T12907: Unable to download large files through alternative file domain: rPHUe1f7cfefe880: Provide a streaming HTTP response parser.
Feb 16 2018, 7:09 PM · Bug Report
epriestley added a commit to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: rPHU9f49d4ed21f1: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Feb 16 2018, 7:08 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

D19111 doesn't fix this in the general case, but should produce the desired behavior for most inputs such that the input is in the form [x](y) and y is the URI of a Wikipedia article.

Feb 16 2018, 7:07 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

The intent isn't unambiguous in the general case, consider: Blah blah (see also [x](y)).

Feb 16 2018, 7:06 PM · Remarkup, Bug Report
epriestley added a revision to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: D19111: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Feb 16 2018, 7:05 PM · Remarkup, Bug Report
epriestley merged T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Ah thanks!

Feb 16 2018, 6:23 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

The non-bold ones also open in a new tab.

Feb 16 2018, 6:20 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Oh! Yes. Sort of.

Feb 16 2018, 6:17 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Just curious, but is the bold effect intentional in the "No Encoding Relative" scenario?

Feb 16 2018, 5:57 PM · Phriction, Remarkup, Bug Report
epriestley closed T12344: Relative links to Phriction pages misinterprets URL-encoded characters as Resolved by committing rPb8bb4d3ad590: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/"….
Feb 16 2018, 5:55 PM · Phriction, Remarkup, Bug Report
epriestley closed T10969: Incorrect Phriction link in email as Resolved by committing rPbfdc9411f705: Provide context objects for remarkup mail rendering, fixing Phriction relative….
Feb 16 2018, 5:55 PM · Phriction, Bug Report
epriestley added a revision to T12344: Relative links to Phriction pages misinterprets URL-encoded characters: D19106: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/" Phriction document.
Feb 16 2018, 2:44 PM · Phriction, Remarkup, Bug Report
epriestley added a revision to T10969: Incorrect Phriction link in email: D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email.
Feb 16 2018, 1:18 PM · Phriction, Bug Report

Feb 14 2018

epriestley moved T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Backlog to Next on the Phriction board.
Feb 14 2018, 2:43 PM · Phriction, Remarkup, Bug Report
epriestley moved T10969: Incorrect Phriction link in email from Backlog to Next on the Phriction board.
Feb 14 2018, 2:33 PM · Phriction, Bug Report
epriestley moved T12793: Unable to move Phriction documents from Backlog to Next on the Phriction board.
Feb 14 2018, 2:31 PM · Customer Impact, Bug Report, Phriction

Feb 13 2018

epriestley closed T10559: Lease Working Copy Hangs on lease failure, but should fail as Resolved.

After changes T13073, I am no longer able to reproduce this. That task has made some improvements and may have fixed whatever happened here.

Feb 13 2018, 4:03 PM · Drydock, Bug Report

Feb 11 2018

epriestley closed T12714: `differential.createcomment` can race automatic revision closure as Resolved by committing rP653bc0fa019f: Read lock all transaction edits.
Feb 11 2018, 4:07 AM · Transactions, Bug Report, Restricted Project
epriestley added a revision to T12714: `differential.createcomment` can race automatic revision closure: D19059: Read lock all transaction edits.
Feb 11 2018, 2:05 AM · Transactions, Bug Report, Restricted Project
epriestley added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

It isn't currently retroactive: the fix is in transition logic and the transition just didn't trigger before.

Feb 11 2018, 12:41 AM · Restricted Project, Harbormaster, Bug Report
swisspol added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

Is this retroactive to builds in this half state prior to this commit and
deploy?

Feb 11 2018, 12:17 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T10746: Aborted build in Harbormaster still shows as building in Diffusion as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Feb 11 2018, 12:08 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T11154: Build results don't always get conferred to their buildable as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Feb 11 2018, 12:08 AM · Restricted Project, Harbormaster, Bug Report

Feb 10 2018

epriestley added a revision to T11154: Build results don't always get conferred to their buildable: D19055: When a build is aborted, fail the buildable.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: D19055: When a build is aborted, fail the buildable.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report

Feb 8 2018

epriestley closed T11389: Object links merged in plain text email as Resolved by committing rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:52 PM · Remarkup, Bug Report, Mail
epriestley added a comment to T11389: Object links merged in plain text email.

D19032 now renders D123 in text contexts (plaintext email) as D123 <https://dev.tyrellcorp.com/D123> instead of https://dev.tyrellcorp.com/D123.

Feb 8 2018, 5:51 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T11389: Object links merged in plain text email: D19032: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley moved T11389: Object links merged in plain text email from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley closed T10189: Differential email headers seem to be missing as Resolved by committing rP6186f0aa91b6: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:31 PM · Differential, Mail, Bug Report
epriestley added a comment to T10189: Differential email headers seem to be missing.

D19030 marks this as fixed: it removes this documentation.

Feb 8 2018, 5:23 PM · Differential, Mail, Bug Report
epriestley moved T10189: Differential email headers seem to be missing from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley added a revision to T10189: Differential email headers seem to be missing: D19030: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley closed T12689: Mail is still received after resigning from a revision as Resolved by committing rP1cd3a593784a: When users resign from revisions, stop expanding projects/packages to include….
Feb 8 2018, 2:29 PM · Mail, Differential, Bug Report
epriestley closed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place as Resolved by committing rPdbe479f0d9de: Don't send error/exception mail to unverified addresses.
Feb 8 2018, 2:26 PM · Mail, Bug Report

Feb 7 2018

epriestley added a revision to T12644: Emoji autocomplete ordering doesn't follow unicode standards: D19023: Improve handling of skin tone variant emoji.
Feb 7 2018, 6:53 PM · Remarkup, Bug Report
epriestley added a revision to T12689: Mail is still received after resigning from a revision: D19021: When users resign from revisions, stop expanding projects/packages to include them.
Feb 7 2018, 4:08 PM · Mail, Differential, Bug Report
epriestley added a revision to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place: D19018: Don't send error/exception mail to unverified addresses.
Feb 7 2018, 1:18 PM · Mail, Bug Report
tolbrino added a comment to T10725: Can't access binary files of differential revision.

I've been running into the same issue for a while now. Using the Default Policy set to Subscribers for Files works well when adding files to Phriction pages and Maniphest tickets. However, when adding binary files as part of a Diff the creator of that Diff needs to change each files permissions by hand before a reviewer can download the Diff. Moreover, this needs to be repeated for every new version of that Diff.

Feb 7 2018, 8:58 AM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19011: Provide a streaming HTTP response parser.
Feb 7 2018, 12:14 AM · Bug Report

Feb 4 2018

epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM · Diffusion, Bug Report

Feb 2 2018

ofbeaton added a comment to T12359: Registration does not accept valid email addresses.

We have also found legitimate users who have valid email addresses (Irish users) that are not accepted.

Feb 2 2018, 8:35 PM · Bug Report
ofbeaton added a comment to T12718: Local email validation with apostrophe.

For those visiting from the future via search, I have decided to publish an unofficial bug patch in a github repo, as it breaks once in awhile due to upstream changes.

Feb 2 2018, 8:31 PM · Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

Thanks @mcorteel, I'll take a look.

Feb 2 2018, 5:01 PM · Arcanist, Bug Report

Feb 1 2018

epriestley closed T11138: mail is not delivered if metamta.placeholder-to-recipient is null as Invalid.

This report doesn't include working reproduction instructions so we can't move forward.

Feb 1 2018, 10:58 PM · Mail, Bug Report
epriestley closed T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part as Resolved.

I can't reproduce this; it may have been fixed by D18776 + D18778.

Feb 1 2018, 10:54 PM · Mail, Bug Report
mcorteel added a comment to T12785: Arc unit command fails with PHPUnit 6.

@cmmata here is my diff. It can probably be improved, but it works for me:

1diff --git a/src/unit/engine/PhpunitTestEngine.php b/src/unit/engine/PhpunitTestEngine.php
2index 8206b787..ef01fda4 100644
3--- a/src/unit/engine/PhpunitTestEngine.php
4+++ b/src/unit/engine/PhpunitTestEngine.php
5@@ -52,7 +52,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
6 if (!Filesystem::pathExists($test_path)) {
7 continue;
8 }
9- $json_tmp = new TempFile();
10+ $xml_tmp = new TempFile();
11 $clover_tmp = null;
12 $clover = null;
13 if ($this->getEnableCoverage() !== false) {
14@@ -64,10 +64,10 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
15
16 $stderr = '-d display_errors=stderr';
17
18- $futures[$test_path] = new ExecFuture('%C %C %C --log-json %s %C %s',
19- $this->phpunitBinary, $config, $stderr, $json_tmp, $clover, $test_path);
20+ $futures[$test_path] = new ExecFuture('%C %C %C --log-junit %s %C %s',
21+ $this->phpunitBinary, $config, $stderr, $xml_tmp, $clover, $test_path);
22 $tmpfiles[$test_path] = array(
23- 'json' => $json_tmp,
24+ 'xml' => $xml_tmp,
25 'clover' => $clover_tmp,
26 );
27 }
28@@ -81,7 +81,7 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
29
30 $results[] = $this->parseTestResults(
31 $test,
32- $tmpfiles[$test]['json'],
33+ $tmpfiles[$test]['xml'],
34 $tmpfiles[$test]['clover'],
35 $stderr);
36 }
37@@ -90,17 +90,17 @@ final class PhpunitTestEngine extends ArcanistUnitTestEngine {
38 }
39
40 /**
41- * Parse test results from phpunit json report.
42+ * Parse test results from phpunit XML report.
43 *
44 * @param string $path Path to test
45- * @param string $json_tmp Path to phpunit json report
46+ * @param string $xml_tmp Path to phpunit XML report
47 * @param string $clover_tmp Path to phpunit clover report
48 * @param string $stderr Data written to stderr
49 *
50 * @return array
51 */
52- private function parseTestResults($path, $json_tmp, $clover_tmp, $stderr) {
53- $test_results = Filesystem::readFile($json_tmp);
54+ private function parseTestResults($path, $xml_tmp, $clover_tmp, $stderr) {
55+ $test_results = Filesystem::readFile($xml_tmp);
56 return id(new ArcanistPhpunitTestResultParser())
57 ->setEnableCoverage($this->getEnableCoverage())
58 ->setProjectRoot($this->projectRoot)
59diff --git a/src/unit/parser/ArcanistPhpunitTestResultParser.php b/src/unit/parser/ArcanistPhpunitTestResultParser.php
60index 5ccff970..3d7fcd77 100644
61--- a/src/unit/parser/ArcanistPhpunitTestResultParser.php
62+++ b/src/unit/parser/ArcanistPhpunitTestResultParser.php
63@@ -9,10 +9,10 @@
64 final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
65
66 /**
67- * Parse test results from phpunit json report
68+ * Parse test results from phpunit XML report
69 *
70 * @param string $path Path to test
71- * @param string $test_results String containing phpunit json report
72+ * @param string $test_results String containing phpunit XML report
73 *
74 * @return array
75 */
76@@ -25,7 +25,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
77 return array($result);
78 }
79
80- $report = $this->getJsonReport($test_results);
81+ $report = simplexml_load_string($test_results);
82
83 // coverage is for all testcases in the executed $path
84 $coverage = array();
85@@ -36,56 +36,36 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
86 $last_test_finished = true;
87
88 $results = array();
89- foreach ($report as $event) {
90- switch (idx($event, 'event')) {
91- case 'test':
92- break;
93- case 'testStart':
94- $last_test_finished = false;
95- // fall through
96- default:
97- continue 2; // switch + loop
98- }
99-
100+ foreach ($report->testsuite as $test_suite) {
101 $status = ArcanistUnitTestResult::RESULT_PASS;
102 $user_data = '';
103
104- if ('fail' == idx($event, 'status')) {
105+ if ((int)$test_suite['failures'] > 0) {
106 $status = ArcanistUnitTestResult::RESULT_FAIL;
107- $user_data .= idx($event, 'message')."\n";
108- foreach (idx($event, 'trace') as $trace) {
109- $user_data .= sprintf(
110- "\n%s:%s",
111- idx($trace, 'file'),
112- idx($trace, 'line'));
113+ foreach ($test_suite->testcase as $test_case) {
114+ foreach ($test_case->failure as $failure) {
115+ $user_data .= sprintf(
116+ "\n%s",
117+ (string)$failure);
118+ }
119 }
120- } else if ('error' == idx($event, 'status')) {
121- if (strpos(idx($event, 'message'), 'Skipped Test') !== false) {
122- $status = ArcanistUnitTestResult::RESULT_SKIP;
123- $user_data .= idx($event, 'message');
124- } else if (strpos(
125- idx($event, 'message'),
126- 'Incomplete Test') !== false) {
127- $status = ArcanistUnitTestResult::RESULT_SKIP;
128- $user_data .= idx($event, 'message');
129- } else {
130- $status = ArcanistUnitTestResult::RESULT_BROKEN;
131- $user_data .= idx($event, 'message');
132- foreach (idx($event, 'trace') as $trace) {
133- $user_data .= sprintf(
134- "\n%s:%s",
135- idx($trace, 'file'),
136- idx($trace, 'line'));
137+ } else if ($test_suite['errors'] > 0) {
138+ $status = ArcanistUnitTestResult::RESULT_BROKEN;
139+ foreach ($test_suite->testcase as $test_case) {
140+ foreach ($test_case->error as $error) {
141+ $user_data .= sprintf(
142+ "\n%s",
143+ (string)$error);
144 }
145 }
146 }
147
148- $name = preg_replace('/ \(.*\)/s', '', idx($event, 'test'));
149+ $name = preg_replace('/ \(.*\)/s', '', $test_suite['name']);
150
151 $result = new ArcanistUnitTestResult();
152 $result->setName($name);
153 $result->setResult($status);
154- $result->setDuration(idx($event, 'time'));
155+ $result->setDuration((float)$test_suite['time']);
156 $result->setCoverage($coverage);
157 $result->setUserData($user_data);
158
159@@ -95,7 +75,7 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
160
161 if (!$last_test_finished) {
162 $results[] = id(new ArcanistUnitTestResult())
163- ->setName(idx($event, 'test')) // use last event
164+ ->setName($test_suite['name']) // use last event
165 ->setUserData($this->stderr)
166 ->setResult(ArcanistUnitTestResult::RESULT_BROKEN);
167 }
168@@ -161,28 +141,4 @@ final class ArcanistPhpunitTestResultParser extends ArcanistTestResultParser {
169 return $reports;
170 }
171
172- /**
173- * We need this non-sense to make json generated by phpunit
174- * valid.
175- *
176- * @param string $json String containing JSON report
177- * @return array JSON decoded array
178- */
179- private function getJsonReport($json) {
180-
181- if (empty($json)) {
182- throw new Exception(
183- pht(
184- 'JSON report file is empty, it probably means that phpunit '.
185- 'failed to run tests. Try running %s with %s option and then run '.
186- 'generated phpunit command yourself, you might get the answer.',
187- 'arc unit',
188- '--trace'));
189- }
190-
191- $json = preg_replace('/}{\s*"/', '},{"', $json);
192- $json = '['.$json.']';
193- return phutil_json_decode($json);
194- }
195-
196 }

Feb 1 2018, 11:00 AM · Arcanist, Bug Report
cmmata added a comment to T12785: Arc unit command fails with PHPUnit 6.

@mcorteel I have the same problem, arc unit only works with phpunit 5.7. If I use 6.5, it fails. Do you have that patch anywhere with public access so we can use it while it's not published?

Feb 1 2018, 9:47 AM · Arcanist, Bug Report

Jan 27 2018

epriestley moved T11138: mail is not delivered if metamta.placeholder-to-recipient is null from v3 to Stamps/Failover on the Mail board.
Jan 27 2018, 9:58 PM · Mail, Bug Report
epriestley closed T12033: Large diffs can still repeatedly fail to insert as Resolved.

This is resolved as far as I'm aware. See also T11767 (improvements to these limits), PHI125 (similar issue with non-UTF8 attachments failing to insert) and T13053 (planning).

Jan 27 2018, 9:55 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report