Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 5

epriestley closed T12814: pholio transaction emails have too much html as Resolved by committing rP99034efa8b8d: Make Pholio mail render without a ton of over-escaped HTML.
Fri, Oct 5, 8:37 PM · Pholio, Transactions, Bug Report
epriestley added a revision to T12814: pholio transaction emails have too much html: D19733: Make Pholio mail render without a ton of over-escaped HTML.
Fri, Oct 5, 6:43 PM · Pholio, Transactions, Bug Report

Tue, Oct 2

epriestley moved T10910: Creating an arc diff from a working directory that is not the repository root from Backlog to Diff on the Windows board.
Tue, Oct 2, 1:00 PM · Windows, Arcanist, Bug Report
epriestley moved T11072: Arcanist reports that it cannot generate a diff from SVN repo even though there are changes in the working copy from Backlog to Diff on the Windows board.
Tue, Oct 2, 1:00 PM · Windows, Arcanist, Bug Report
epriestley renamed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) from Arcanist failed patch lint on windows to Arcanist failed patch lint on windows (because "cp" does not exist).
Tue, Oct 2, 12:59 PM · Windows, Bug Report
epriestley closed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) as Resolved.

This was almost certainly resolved by D16273.

Tue, Oct 2, 12:59 PM · Windows, Bug Report
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint` as Resolved.

Changes in T13209 make this the only mode.

Tue, Oct 2, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a parent task for T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`: T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Tue, Oct 2, 12:48 PM · Windows, Arcanist, Lint, Bug Report

Thu, Sep 27

epriestley moved T10818: Lint errors about filenames, which do not include any source context, render with awkward whitespace from vNext to Unit/Lint Bindings on the Arcanist board.
Thu, Sep 27, 3:09 PM · Arcanist, Bug Report
epriestley added a parent task for T11479: ArcanistUnitTestEngine->shouldEchoTestResults() logic inverted: T13098: Plans: Arcanist toolsets and extensions.
Thu, Sep 27, 2:25 PM · Arcanist, Bug Report
epriestley closed T11479: ArcanistUnitTestEngine->shouldEchoTestResults() logic inverted as Resolved.

This is effectively fixed by T13098, which modularizes test output.

Thu, Sep 27, 2:25 PM · Arcanist, Bug Report

Aug 27 2018

epriestley closed T12793: Unable to move Phriction documents as Wontfix.

This doesn't have a repro and will probably be fixed via rewrite / modernization in T13077 anyway.

Aug 27 2018, 9:47 PM · Customer Impact, Bug Report, Phriction

Aug 9 2018

epriestley closed T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale as Resolved by committing rP6df278bea84a: In "bin/ssh-auth", cache a structure instead of a flat file because paths may….
Aug 9 2018, 8:33 PM · Bug Report

Aug 8 2018

epriestley added a revision to T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale: D19568: In "bin/ssh-auth", cache a structure instead of a flat file because paths may change at runtime.
Aug 8 2018, 5:21 PM · Bug Report

Aug 6 2018

epriestley renamed T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale from `bin/ssh-auth` uses stale caches for its response to `bin/ssh-auth` cache includes paths which may be (or may become) stale.
Aug 6 2018, 10:44 PM · Bug Report
epriestley raised the priority of T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale from Wishlist to Normal.
Aug 6 2018, 10:44 PM · Bug Report
epriestley added a comment to T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale.

See PHI801. This is a similar case to the one above, but I think the underlying use case was a bit more compelling: the install was transitioning from a set of older web nodes to newer web nodes as a part of a general infrastructure upgrade, and making various fixes to the deployment and support software as part of that process. One aspect of these adjacent fixes was changing the path from /something/something/phabricator to /something-else/something-else/phabricator (I think as a consequence of adjusting deploy strategy), so newer nodes would have a different absolute path than older nodes. Both sets of nodes were in production simultaneously.

Aug 6 2018, 10:44 PM · Bug Report

Aug 1 2018

urzds added a comment to T11827: ssh-auth hangs on FreeBSD.

The workaround does not work for me on Debian 9.5 with OpenSSH 7.4p1. Actually I am surprised this worked for anyone, since the issue appears to be that the buffer of the pipe between ssh-auth's stdout and the parent's stdin is being filled, hence ssh-auth blocking at some point. It should not matter how fast these buffers are being filled...

Aug 1 2018, 3:42 PM · Diffusion, Bug Report

Jul 30 2018

epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19548: Possibly increase the width of the S3 -> Files -> Client pipeline.
Jul 30 2018, 7:51 PM · Bug Report
epriestley added a commit to T12907: Unable to download large files through alternative file domain: rP58e8d3c13479: (stable) Remove the execution time limit (if any) before sinking HTTP responses.
Jul 30 2018, 5:57 PM · Bug Report
epriestley added a commit to T12907: Unable to download large files through alternative file domain: rP81a7c9ac43f2: Remove the execution time limit (if any) before sinking HTTP responses.
Jul 30 2018, 5:56 PM · Bug Report
epriestley added a revision to T12907: Unable to download large files through alternative file domain: D19547: Remove the execution time limit (if any) before sinking HTTP responses.
Jul 30 2018, 4:45 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

We have a more reliable break for this now, in the form:

Jul 30 2018, 4:10 PM · Bug Report

Jul 26 2018

epriestley added a comment to T12907: Unable to download large files through alternative file domain.

I can't get anything to break at all now. 💁

Jul 26 2018, 7:39 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

I made a change like this to split responses into small blocks and give each a random chance of failing (I tried 4096 and 4027, a prime near 4KB, as miniblock sizes):

Jul 26 2018, 6:35 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

A recent, probably more concrete issue that I've seen is that wget of a large file can succeed (wget automatically resumes) but we can end up with a file that has different content than the original, which is disastrously bad.

Jul 26 2018, 5:58 PM · Bug Report

Jul 16 2018

monufer updated the task description for T12334: Arc land is not enforcing Herald Rule.
Jul 16 2018, 5:00 PM · Bug Report

Jun 7 2018

DragonBe added a comment to T12785: Arc unit command fails with PHPUnit 6.

Confirmed on PHPUnit 7.2.2 👍

Jun 7 2018, 1:36 PM · Arcanist, Bug Report

May 24 2018

epriestley closed T12613: In diffusion hosting subversion repository, several commands do not return (freeze). as Resolved.
May 24 2018, 2:19 PM · Diffusion, Bug Report
k_kazu added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

This problem fixed by T13140. Thank you.

May 24 2018, 11:25 AM · Diffusion, Bug Report

May 8 2018

Herald updated subscribers of T12814: pholio transaction emails have too much html.
May 8 2018, 12:05 PM · Pholio, Transactions, Bug Report

Apr 4 2018

epriestley closed T10398: Phabricator UI uses deprecated <tt> tag as Wontfix.

Since there's no known actual problem with this today, I don't plan to fix it.

Apr 4 2018, 2:11 PM · Remarkup, Bug Report
epriestley closed T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax as Wontfix.

I don't currently plan to change the remaining edge case behaviors since I'm not sure they ever occur in the wild.

Apr 4 2018, 1:59 PM · Remarkup, Bug Report

Apr 3 2018

tekacs added a comment to T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull.

Duplicate of T8936?

Apr 3 2018, 1:05 PM · Customer Impact, Git, Bug Report

Mar 30 2018

dereckson added a comment to T12785: Arc unit command fails with PHPUnit 6.

I confirm the Maxime Corteel patch to be working with PHPUnit 7.0.1 too.

Mar 30 2018, 4:03 PM · Arcanist, Bug Report

Mar 29 2018

epriestley closed T12759: Creating an Owners package before creating any repositories shows a blank select when adding paths to the package as Resolved.

I think this is sort of less bad/weird now, at least. You get a tokenizer instead, which is still empty, but you're prompted to "Type a repository name..." and the UI isn't this odd empty select thing anymore.

Mar 29 2018, 6:27 PM · Bug Report

Mar 21 2018

epriestley closed T11145: Dialog submit buttons don't disable on click as Resolved by committing rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:58 PM · Restricted Project, PHUI, Bug Report
epriestley added a revision to T11145: Dialog submit buttons don't disable on click: D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:55 PM · Restricted Project, PHUI, Bug Report

Mar 16 2018

1stone added a comment to T12727: Mail handler unable to parse e-mail from MS Outlook 12, Failed to JSON encode value.

is there a chance that this problem will get fixed?
The change D17989 is already from May 2017 without any reviewer...

Mar 16 2018, 2:49 PM · Bug Report

Mar 14 2018

epriestley closed T9972: Profile image from Google not being picked up as Wontfix.
Mar 14 2018, 5:11 PM · Auth, Bug Report

Mar 7 2018

epriestley closed T11015: Owners has perplexing behavior when directory paths are not terminated with a slash as Resolved.

I believe the behavior of this UI should generally align well with what reasonable users might expect, now. In particular, /src/backend and /src/backend/ are now exactly the same in terms of actually resolving ownership, although the UI will continue to show you the value you entered (to avoid confusion where someone types /docs/README.md and the UI echoes back /docs/README.md/ and they have a reasonable concern that the path wasn't understood).

Mar 7 2018, 4:54 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rP516aaad3410c: Use "pathIndex" in some owners package queries to improve query plans.
Mar 7 2018, 4:33 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rPdf1e9ce646c0: Treat Owners paths like "/src/backend" and "/src/backend/" identically.
Mar 7 2018, 4:31 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rPadde4089b49b: Allow owners paths to be arbitrarily long and add storage for display paths.
Mar 7 2018, 4:31 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rP8cb273a0532b: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>".
Mar 7 2018, 4:31 AM · Owners, Bug Report
epriestley added a commit to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: rP1bf4422c749c: Add and populate a `pathIndex` column for OwnersPath.
Mar 7 2018, 4:30 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19185: Use "pathIndex" in some owners package queries to improve query plans.
Mar 7 2018, 4:28 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19184: Treat Owners paths like "/src/backend" and "/src/backend/" identically.
Mar 7 2018, 4:14 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19183: Allow owners paths to be arbitrarily long and add storage for display paths.
Mar 7 2018, 3:54 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19182: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>".
Mar 7 2018, 3:47 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19181: Add and populate a `pathIndex` column for OwnersPath.
Mar 7 2018, 3:37 AM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Probably better is to add pathIndex

Mar 7 2018, 3:25 AM · Owners, Bug Report
epriestley added a commit to T12787: Creating a subtask 'reopens' the new task: rPe57dbcda336a: Hide "abraham landed Dxyz irresponsibly" stories from feed.
Mar 7 2018, 1:48 AM · Feed, Bug Report
epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: D19179: Hide "abraham landed Dxyz irresponsibly" stories from feed.
Mar 7 2018, 1:41 AM · Feed, Bug Report

Mar 5 2018

epriestley moved T10608: Arc diff failing to generate diff with svn 1.9.3 from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:19 PM · Arcanist, Bug Report
epriestley moved T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:17 PM · Lint, Arcanist, Bug Report
epriestley moved T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12785: Arc unit command fails with PHPUnit 6 from Backlog to Unit/Lint Bindings on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Mercurial, Bug Report

Feb 26 2018

epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

See T13092; tangentially, it might be nice to render these stories more explicitly as "X added Y, removed Z (because Z is a subproject of Y, and objects may not be tagged with multiple mutual ancestors/descendant projects)", if some sufficiently terse phrasing can be found.

Feb 26 2018, 6:17 PM · Bug Report

Feb 21 2018

epriestley moved T10635: Loading differential revision slow when lots of unit test messages exist from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:40 PM · Restricted Project, Haskell.org, Harbormaster, Performance, Bug Report

Feb 16 2018

epriestley added a commit to T12907: Unable to download large files through alternative file domain: rPHUe1f7cfefe880: Provide a streaming HTTP response parser.
Feb 16 2018, 7:09 PM · Bug Report
epriestley added a commit to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: rPHU9f49d4ed21f1: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Feb 16 2018, 7:08 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

D19111 doesn't fix this in the general case, but should produce the desired behavior for most inputs such that the input is in the form [x](y) and y is the URI of a Wikipedia article.

Feb 16 2018, 7:07 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

The intent isn't unambiguous in the general case, consider: Blah blah (see also [x](y)).

Feb 16 2018, 7:06 PM · Remarkup, Bug Report
epriestley added a revision to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: D19111: Tweak handling of "[[ / ]]" and "[x](y)" where "y" has parentheses.
Feb 16 2018, 7:05 PM · Remarkup, Bug Report
epriestley merged T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Ah thanks!

Feb 16 2018, 6:23 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

The non-bold ones also open in a new tab.

Feb 16 2018, 6:20 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Oh! Yes. Sort of.

Feb 16 2018, 6:17 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Just curious, but is the bold effect intentional in the "No Encoding Relative" scenario?

Feb 16 2018, 5:57 PM · Phriction, Remarkup, Bug Report
epriestley closed T12344: Relative links to Phriction pages misinterprets URL-encoded characters as Resolved by committing rPb8bb4d3ad590: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/"….
Feb 16 2018, 5:55 PM · Phriction, Remarkup, Bug Report
epriestley closed T10969: Incorrect Phriction link in email as Resolved by committing rPbfdc9411f705: Provide context objects for remarkup mail rendering, fixing Phriction relative….
Feb 16 2018, 5:55 PM · Phriction, Bug Report
epriestley added a revision to T12344: Relative links to Phriction pages misinterprets URL-encoded characters: D19106: Accept either "[[ %24doge ]]" or "[[ $doge ]]" as references to the "/w/$doge/" Phriction document.
Feb 16 2018, 2:44 PM · Phriction, Remarkup, Bug Report
epriestley added a revision to T10969: Incorrect Phriction link in email: D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email.
Feb 16 2018, 1:18 PM · Phriction, Bug Report

Feb 14 2018

epriestley moved T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Backlog to Next on the Phriction board.
Feb 14 2018, 2:43 PM · Phriction, Remarkup, Bug Report
epriestley moved T10969: Incorrect Phriction link in email from Backlog to Next on the Phriction board.
Feb 14 2018, 2:33 PM · Phriction, Bug Report
epriestley moved T12793: Unable to move Phriction documents from Backlog to Next on the Phriction board.
Feb 14 2018, 2:31 PM · Customer Impact, Bug Report, Phriction

Feb 13 2018

epriestley closed T10559: Lease Working Copy Hangs on lease failure, but should fail as Resolved.

After changes T13073, I am no longer able to reproduce this. That task has made some improvements and may have fixed whatever happened here.

Feb 13 2018, 4:03 PM · Drydock, Bug Report

Feb 11 2018

epriestley closed T12714: `differential.createcomment` can race automatic revision closure as Resolved by committing rP653bc0fa019f: Read lock all transaction edits.
Feb 11 2018, 4:07 AM · Transactions, Bug Report, Restricted Project
epriestley added a revision to T12714: `differential.createcomment` can race automatic revision closure: D19059: Read lock all transaction edits.
Feb 11 2018, 2:05 AM · Transactions, Bug Report, Restricted Project
epriestley added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

It isn't currently retroactive: the fix is in transition logic and the transition just didn't trigger before.

Feb 11 2018, 12:41 AM · Restricted Project, Harbormaster, Bug Report
swisspol added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

Is this retroactive to builds in this half state prior to this commit and
deploy?

Feb 11 2018, 12:17 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T10746: Aborted build in Harbormaster still shows as building in Diffusion as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Feb 11 2018, 12:08 AM · Restricted Project, Harbormaster, Bug Report
epriestley closed T11154: Build results don't always get conferred to their buildable as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.
Feb 11 2018, 12:08 AM · Restricted Project, Harbormaster, Bug Report

Feb 10 2018

epriestley added a revision to T11154: Build results don't always get conferred to their buildable: D19055: When a build is aborted, fail the buildable.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: D19055: When a build is aborted, fail the buildable.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report

Feb 8 2018

epriestley closed T11389: Object links merged in plain text email as Resolved by committing rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:52 PM · Remarkup, Bug Report, Mail
epriestley added a comment to T11389: Object links merged in plain text email.

D19032 now renders D123 in text contexts (plaintext email) as D123 <https://dev.tyrellcorp.com/D123> instead of https://dev.tyrellcorp.com/D123.

Feb 8 2018, 5:51 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T11389: Object links merged in plain text email: D19032: Render object remarkup references in a text context as "Dxxx <uri>".
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley moved T11389: Object links merged in plain text email from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley closed T10189: Differential email headers seem to be missing as Resolved by committing rP6186f0aa91b6: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:31 PM · Differential, Mail, Bug Report
epriestley added a comment to T10189: Differential email headers seem to be missing.

D19030 marks this as fixed: it removes this documentation.

Feb 8 2018, 5:23 PM · Differential, Mail, Bug Report
epriestley moved T10189: Differential email headers seem to be missing from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley added a revision to T10189: Differential email headers seem to be missing: D19030: Briefly document mail stamps and remove obsolete header documentation.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley closed T12689: Mail is still received after resigning from a revision as Resolved by committing rP1cd3a593784a: When users resign from revisions, stop expanding projects/packages to include….
Feb 8 2018, 2:29 PM · Mail, Differential, Bug Report
epriestley closed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place as Resolved by committing rPdbe479f0d9de: Don't send error/exception mail to unverified addresses.
Feb 8 2018, 2:26 PM · Mail, Bug Report

Feb 7 2018

epriestley added a revision to T12644: Emoji autocomplete ordering doesn't follow unicode standards: D19023: Improve handling of skin tone variant emoji.
Feb 7 2018, 6:53 PM · Remarkup, Bug Report
epriestley added a revision to T12689: Mail is still received after resigning from a revision: D19021: When users resign from revisions, stop expanding projects/packages to include them.
Feb 7 2018, 4:08 PM · Mail, Differential, Bug Report
epriestley added a revision to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place: D19018: Don't send error/exception mail to unverified addresses.
Feb 7 2018, 1:18 PM · Mail, Bug Report