Page MenuHomePhabricator

When picking a default menu item to render, don't pick disabled items
ClosedPublic

Authored by epriestley on Mar 31 2019, 9:13 PM.

Details

Summary

Depends on D20358. Fixes T12871. After refactoring, we can now tell when a "storage" menu item generated only disabled "display" menu items, and not pick any of them as the default rendering.

This means that if you're looking at a portal/menu with several dashboards, but can't see some at the top, you'll get the first one you can see.

Also clean up a lot of minor issues with less-common states.

Test Plan
  • Created a portal with two private dashboards and a public dashboard.
  • Viewed it as another user, saw the default view show the dashboard I can actually see.
  • Minor fix: Disabled and enabled the hard-coded "Home" item, now worked cleanly with the right menu state.
  • Minor fix: added a motivator panel.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 31 2019, 9:13 PM
epriestley requested review of this revision.Mar 31 2019, 9:15 PM
epriestley added inline comments.Mar 31 2019, 9:15 PM
src/applications/search/engine/PhabricatorProfileMenuItemViewList.php
96–101

This is the actual fix to T12871 after shuffling a thousand lines of code around.

epriestley updated this revision to Diff 48579.Mar 31 2019, 9:16 PM
  • Typo fix.
amckinley accepted this revision.Apr 2 2019, 9:01 PM
This revision is now accepted and ready to land.Apr 2 2019, 9:01 PM
This revision was automatically updated to reflect the committed changes.