Observed on Phacility
We have a bot user called instabug and a project called instabug: search field only shows one
swisspol | |
Apr 11 2017, 6:23 PM |
F4898898: pasted_file | |
Apr 12 2017, 3:02 PM |
F4898901: pasted_file | |
Apr 12 2017, 3:02 PM |
F4883688: pasted_file | |
Apr 11 2017, 6:23 PM |
Observed on Phacility
We have a bot user called instabug and a project called instabug: search field only shows one
This is a sort-of-intended result of several different rules colliding to make a mess. Here's the primary rule:
So the logic goes:
Obviously, this does not produce the right outcome here, although fixing it properly is probably somewhat involved (e.g., see T11110, T6906).
All that said, I'm not sure we need the filtering at all (?) because later changes also do this with sorting. Except not in this typeahead. But it isn't really important anyway. Probably. I'm going to try a one-line "fix" here and see if it digs us any deeper or not.
My intended fix here is:
Another instance of the bug her:
Interestingly, when I click on the search button of the search field, then filter by "instabug", I see both the project and user, BUT the user is struck through for some reason I don't understand?
Ah I missed that sentence above, this is why the bot user is disabled:
Mailing list and bot users are also considered "closed" because you usually want to hit normal users instead of them.
Yeah, the user is struck through because they are "closed", which is because they are a bot. This isn't the best way to deal with this, but it dates from early 2014 (D8231) when everything was simpler.
T12157 lists some other cases where we're currently inconsistent about this that should be consolidated.
More modern object types are more nuanced about these sorts of distinctions, user accounts just haven't changed much in a long time.