Page MenuHomePhabricator
Create Task
Maniphest T13069

Make mail stamps routable on the server, include transaction information, and replace mail tags
Open, NormalPublic
Actions

Description

T13053/T10448 introduced "mail stamps", which are more expressive labels for mail to support client routing. They can also be inlined into the mail body for client routing with Gmail.

Currently, stamps coexist with the older (and significantly less expressive) "mail tags" system, and you can't write rules against stamps in Phabricator itself, only against tags.

I'd like to replace Phabricator-side routing of mail with a stamps-based system and remove the current Settings → Email Preferences UI. This probably isn't very difficult technically, but building a UI to let users define rules is likely a significant amount of work, since it should ideally be a big fancy Javascript thing that lets users define rules with a lot of logic, accommodates "global" and "personal" rules in a reasonable way, and doesn't require any PhDs to configure the common 90% of things that users are most interested in configuring.

Outstanding use cases for this include:

  • (T4654) Rules like "when I'm mentioned: send me an email and stop processing rules".
  • (T10448) Original request: ignore all (some? This was a little vague) mail from Owners packages.
  • (T11363) Ignore revisions being updated.
  • Also, ignore revisions being closed.
  • (PHI175) Ignore resigns.
  • (PHI54) Maybe ignore revision mail where you aren't a reviewer?

Stamps also currently do not include information about the actions that the mail describes, only stateful information about the object. This is likely not difficult but is a fair amount of legwork. I also want to add some UI around stamps first so we can automatically generate a list of applicable transactions and the tags they generate, to make sure I'm not missing anything when I implement this stuff as much as anything else.

Revisions and Commits

rP Phabricator
D19227rPcd7ba6cd7bf9 Improve documentation around using Mail stamps with Gmail

Related Objects

Event Timeline

epriestley triaged this task as Normal priority.Feb 8 2018, 7:24 PM
epriestley created this task.
Herald added a subscriber: eadler. · View Herald TranscriptFeb 8 2018, 7:24 PM
epriestley mentioned this in T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.Feb 8 2018, 7:28 PM
epriestley mentioned this in T10448: Modularize mail tags.
epriestley mentioned this in T11363: Differential "revision updated" mail preference is pretty useless.
epriestley mentioned this in T13053: Plans: Mail Tags and Failover.Feb 8 2018, 7:35 PM
aklapper added a subscriber: aklapper.Feb 8 2018, 8:03 PM
epriestley mentioned this in T13068: Refinements for "Mute Notifications".Feb 8 2018, 8:10 PM
epriestley mentioned this in D19035: When users are subscribed explicitly, count them as "mentioned".Feb 8 2018, 8:37 PM
epriestley mentioned this in Unknown Object (Phriction Wiki Document).Feb 10 2018, 1:02 AM
epriestley mentioned this in 2018 Week 6 (Early February).Feb 10 2018, 1:16 AM
hskiba added a subscriber: hskiba.Feb 12 2018, 2:10 PM
nemobis added a subscriber: nemobis.Feb 15 2018, 3:38 PM

Will stamps be applied for all email notifications and reasons for the recipient to receive them, so as to fix T6297: Maniphest email notification doesn't say why I'm receiving it?

epriestley added a comment.Feb 15 2018, 4:13 PM

No. Mail stamps are not intended to answer "Why am I receiving this mail?" in the general case (which lives in T9412 now, I think).

For example, you might receive a mail notification about a revision because:

  • the revision affected /barn/animals/cow/moo.txt;
  • the Owners package O123 Cow Crew owns /barn/animals/cow with "Weak Dominion" and no more specific package owns moo.txt, and has an autoreview rule;
  • one of the owners for the package is the project #farmhands;
  • you are a member of that project.

A mail stamp can't express this. It would look something like package(O123, project(#farmhands, member(@alice)))), perhaps, which would neither answer the question (at least, for a non-expert user), nor be particularly routable with client rules, nor be very amenable to server-side routing.

I suspect the /mail/view/<message-id>/ page will eventually have a more detailed UI element which explains why everyone who received the mail was part of the recipient list, but this is moderately complicated to build and I don't currently believe that it's a very important feature. (A good chunk of T9412 is users just forgetting that they used 'Watch Project" -- which isn't great, but which I think isn't a huge concern.)

epriestley mentioned this in T10102: No way to control PonderAnswer emails/notifications.Mar 14 2018, 5:05 PM
epriestley added a revision: D19227: Improve documentation around using Mail stamps with Gmail.Mar 14 2018, 8:07 PM
epriestley added a commit: rPcd7ba6cd7bf9: Improve documentation around using Mail stamps with Gmail.Mar 14 2018, 8:09 PM
Krinkle added a subscriber: Krinkle.EditedJun 15 2018, 1:22 AM

@epriestley T7468: No way to disable web notifications for token awards was marked as duplicate of T10448, which in turn was resolved with a pointer to this task.

Does that mean T7468 has been fixed and/or will be resolved by this task? If not, should T7468 be re-opened?

quiddity added a subscriber: quiddity.Nov 8 2018, 2:04 AM
epriestley mentioned this in T11782: Inconsistent mail notification subject ([Updated] vs [Merged]) depending on from which task a duplicate task was merged.Jan 15 2019, 3:09 PM
epriestley mentioned this in T10745: Emails are sent out about restricted changes.Mar 13 2019, 6:27 PM
Herald added a subscriber: amckinley. · View Herald TranscriptAug 2 2019, 2:48 PM
Krinkle awarded a token.Jul 10 2020, 4:17 PM
Phabricator · Built by Phacility