Fix sorting bug in ProjectDatasource
ClosedPublic
Actions

Authored by amckinley on Dec 18 2018, 8:08 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name

Commits

rP95ea4f11b94f: Fix sorting bug in ProjectDatasource

Summary

See https://discourse.phabricator-community.org/t/typeahead-returning-only-archived-results/2220. Ref T12538.

If a user has more than 100 disabled projects matching their search term, only disabled projects will be returned in the typeahead search results.

Test Plan

Harcoded hard limit in PhabricatorTypeaheadModularDatasourceController to force truncation of search results, observed active project on top of results as expected.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Dec 18 2018, 8:08 PM

Harbormaster completed remote builds in B21373: Diff 47519.Dec 18 2018, 8:10 PM

amckinley requested review of this revision.Dec 18 2018, 8:10 PM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 18 2018, 8:10 PM

epriestley accepted this revision.Dec 18 2018, 8:13 PM

This revision is now accepted and ready to land.Dec 18 2018, 8:13 PM

Closed by commit rP95ea4f11b94f: Fix sorting bug in ProjectDatasource (authored by amckinley). · Explain WhyDec 18 2018, 8:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

5 lines

typeahead/

PhabricatorProjectDatasource.php

3 lines

Diff 47521

View Options

src/applications/project/query/PhabricatorProjectQuery.php