Page MenuHomePhabricator

When running "arc land" from a detached HEAD, don't try to delete the source ref
ClosedPublic

Authored by epriestley on Sep 5 2019, 12:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 1, 5:36 AM
Unknown Object (File)
Feb 21 2024, 1:57 PM
Unknown Object (File)
Feb 21 2024, 11:01 AM
Unknown Object (File)
Feb 13 2024, 10:37 AM
Unknown Object (File)
Feb 9 2024, 12:55 AM
Unknown Object (File)
Feb 3 2024, 11:09 PM
Unknown Object (File)
Feb 3 2024, 11:09 PM
Unknown Object (File)
Feb 3 2024, 11:09 PM
Subscribers
None
Tokens
"Party Time" token, awarded by leoluk.

Details

Summary

Fixes T10321. Some reasonable but less-common workflows involve running arc land from a detached HEAD state.

When users do this, we currently try to delete the raw hash as though it were a branch during cleanup. Instead, detect if the thing we're thinking about deleting is a branch or not, and just leave it alone if it isn't.

Test Plan
  • Ran git checkout <some hash>, then arc land --revision <some revision>.
  • Before, everything worked but cleanup tried to git branch -D <some hash>.
  • After, everything worked and cleanup skipped branch deletion.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable