Page MenuHomePhabricator

When the last rejecting reviewer resigns from a revision, return it to "Needs Review"

Authored by epriestley on Nov 26 2018, 2:06 PM.



Ref T13216. Fixes T12920. See PHI911. If you reject a revision and then resign from it, it stays in "Needs Revision".

There's some arguable motivation for this, but it's inconsistent with how "Accept" works (if the last accepting reviewer resigns, we kick you out of "Accepted"). Make it consistent.

Test Plan
  • As the only reviewer: requested changes to a revision, then resigned.
  • Before: revision stays in "Needs Revision".
  • After: revision moves back to "Needs Review".

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 26 2018, 2:06 PM
epriestley requested review of this revision.Nov 26 2018, 2:07 PM
amckinley accepted this revision.Nov 26 2018, 4:32 PM
This revision is now accepted and ready to land.Nov 26 2018, 4:32 PM
This revision was automatically updated to reflect the committed changes.