Differential D19840

When the last rejecting reviewer resigns from a revision, return it to "Needs Review"
ClosedPublic
Actions

Authored by epriestley on Nov 26 2018, 2:06 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12920: Retracting requested changes can leave revision in "Needs Revision" state
T13216: 2018 Week 45-47 Bonus Content

Commits

rP97e7ef0f015c: When the last rejecting reviewer resigns from a revision, return it to "Needs…

Summary

Ref T13216. Fixes T12920. See PHI911. If you reject a revision and then resign from it, it stays in "Needs Revision".

There's some arguable motivation for this, but it's inconsistent with how "Accept" works (if the last accepting reviewer resigns, we kick you out of "Accepted"). Make it consistent.

Test Plan

As the only reviewer: requested changes to a revision, then resigned.
Before: revision stays in "Needs Revision".
After: revision moves back to "Needs Review".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 26 2018, 2:06 PM

Harbormaster completed remote builds in B21218: Diff 47369.Nov 26 2018, 2:07 PM

epriestley requested review of this revision.Nov 26 2018, 2:07 PM

amckinley accepted this revision.Nov 26 2018, 4:32 PM

This revision is now accepted and ready to land.Nov 26 2018, 4:32 PM

Closed by commit rP97e7ef0f015c: When the last rejecting reviewer resigns from a revision, return it to "Needs… (authored by epriestley). · Explain WhyNov 26 2018, 6:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

5 lines

Diff 47372

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

When the last rejecting reviewer resigns from a revision, return it to "Needs Review"ClosedPublicActions