Page MenuHomePhabricator

Lint errors about filenames, which do not include any source context, render with awkward whitespace
Open, Needs TriagePublic

Description

Observed on OS X 10.11.4 with latest Arcanist (just updated).

Here's the output of arc lint:

$ arc lint --everything
PHP Warning:  PHP Startup: Unable to load dynamic library '/Applications/Server.app/Contents/ServerRoot/usr/lib/php/extensions/no-debug-non-zts-20100525/pdo_pgsql.so' - dlopen(/Applications/Server.app/Contents/ServerRoot/usr/lib/php/extensions/no-debug-non-zts-20100525/pdo_pgsql.so, 9): image not found in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/Applications/Server.app/Contents/ServerRoot/usr/lib/php/extensions/no-debug-non-zts-20100525/pgsql.so' - dlopen(/Applications/Server.app/Contents/ServerRoot/usr/lib/php/extensions/no-debug-non-zts-20100525/pgsql.so, 9): image not found in Unknown on line 0
>>> Lint for Apple/OSX/Assets.xcassets/card-menu.imageset/icn-gear@2x.png:


   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.
>>> Lint for Apple/OSX/Assets.xcassets/checkbox-filled.imageset/icn-check-filled@2x.png:


   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.
>>> Lint for Apple/OSX/Assets.xcassets/checkbox-unfilled.imageset/icn-check-nofill@2x.png:


   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.
>>> Lint for Apple/OSX/Assets.xcassets/comment-icon.imageset/icn-comment@2x.png:


(truncated)

And here it is as seen in Terminal:

The placement of blank lines makes it hard to see at a glance which file is affected by which lint warning / error. For instance see this output group:

Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.
>>> Lint for Apple/OSX/Assets.xcassets/checkbox-unfilled.imageset/icn-check-nofill@2x.png:

Actually, the reported error is not for the file specified after >>> but for the file in the previous group!

Here's the output I would expect from arc lint:

$ arc lint --everything
>>> Lint for Apple/OSX/Assets.xcassets/card-menu.imageset/icn-gear@2x.png:
   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.


>>> Lint for Apple/OSX/Assets.xcassets/checkbox-filled.imageset/icn-check-filled@2x.png:
   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.


>>> Lint for Apple/OSX/Assets.xcassets/checkbox-unfilled.imageset/icn-check-nofill@2x.png:
   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.


>>> Lint for Apple/OSX/Assets.xcassets/comment-icon.imageset/icn-comment@2x.png:

(truncated)

Event Timeline

eadler added a subscriber: eadler.Apr 15 2016, 1:00 AM
epriestley moved this task from Backlog to vNext on the Arcanist board.Nov 14 2016, 5:48 PM
epriestley renamed this task from Blank lines placement in output of arc lint is confusing to Lint errors about filenames, which do not include any source context, render with awkward whitespace.
epriestley moved this task from vNext to Unit/Lint Bindings on the Arcanist board.Sep 27 2018, 3:09 PM