Page MenuHomePhabricator

Provide better UI feedback about cards that can't be dragged or edited

Authored by epriestley on Mar 11 2019, 6:01 AM.



Depends on D20273. Fixes T10722. Currently, we don't make it very clear when a card can't be edited. Long ago, some code made a weak attempt to do this (by hiding the "grip" on the card), but later UI changes hid the "grip" unconditionally so that mooted things.


  • Replace the edit pencil with a red lock.
  • Provide cursor hints for grabbable / not grabbable.
  • Don't let users pick up cards they can't edit.
Test Plan

On a workboard with a mixture of editable and not-editable cards, hovered over the different cards and was able to figure out which ones I could drag or not drag pretty easily. Picked up cards I could pick up, wasn't able to drag cards I can't edit.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 11 2019, 6:01 AM
epriestley requested review of this revision.Mar 11 2019, 6:03 AM
amckinley accepted this revision.Mar 12 2019, 8:07 PM
amckinley added inline comments.

This should also clearly make a loud bonging noise if the user attempts to drag a card anyway.

This revision is now accepted and ready to land.Mar 12 2019, 8:07 PM
epriestley added inline comments.Mar 12 2019, 8:08 PM

GREAT idea

HUGE ui/ux improvement

This revision was automatically updated to reflect the committed changes.