Page MenuHomePhabricator

Provide better UI feedback about cards that can't be dragged or edited
ClosedPublic

Authored by epriestley on Mar 11 2019, 6:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 8, 3:10 PM
Unknown Object (File)
Wed, May 7, 5:36 AM
Unknown Object (File)
Mon, May 5, 3:06 PM
Unknown Object (File)
Tue, Apr 29, 6:14 PM
Unknown Object (File)
Sat, Apr 26, 10:54 AM
Unknown Object (File)
Apr 13 2025, 1:40 PM
Unknown Object (File)
Apr 10 2025, 10:15 PM
Unknown Object (File)
Apr 4 2025, 5:13 PM
Subscribers
None

Details

Summary

Depends on D20273. Fixes T10722. Currently, we don't make it very clear when a card can't be edited. Long ago, some code made a weak attempt to do this (by hiding the "grip" on the card), but later UI changes hid the "grip" unconditionally so that mooted things.

Instead:

  • Replace the edit pencil with a red lock.
  • Provide cursor hints for grabbable / not grabbable.
  • Don't let users pick up cards they can't edit.
Test Plan

On a workboard with a mixture of editable and not-editable cards, hovered over the different cards and was able to figure out which ones I could drag or not drag pretty easily. Picked up cards I could pick up, wasn't able to drag cards I can't edit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
webroot/rsrc/css/phui/workboards/phui-workcard.css
91–93

This should also clearly make a loud bonging noise if the user attempts to drag a card anyway.

This revision is now accepted and ready to land.Mar 12 2019, 8:07 PM
webroot/rsrc/css/phui/workboards/phui-workcard.css
91–93

GREAT idea

HUGE ui/ux improvement

This revision was automatically updated to reflect the committed changes.