Differential D19972

Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject
ClosedPublic
Actions

Authored by epriestley on Jan 14 2019, 10:34 PM.

Details

Reviewers

Maniphest Tasks

T11782: Inconsistent mail notification subject ([Updated] vs [Merged]) depending on from which task a duplicate task was merged

Commits

rPdc4d7f1f3e8d: Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]"…

Summary

Fixes T11782. When you "Close as Duplicate", generate a "[Merged]" email by making the merge the first transaction.

(There are other, more-deterministic ways to do this with action strength, but this is much simpler and I believe it suffices.)

Test Plan

Used "Close as Duplicate", got a "[Merged]" email out of it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 14 2019, 10:34 PM

Harbormaster completed remote builds in B21524: Diff 47671.Jan 14 2019, 10:36 PM

epriestley requested review of this revision.Jan 14 2019, 10:36 PM

epriestley mentioned this in T11782: Inconsistent mail notification subject ([Updated] vs [Merged]) depending on from which task a duplicate task was merged.Jan 15 2019, 3:09 PM

amckinley accepted this revision.Jan 16 2019, 2:13 AM

This revision is now accepted and ready to land.Jan 16 2019, 2:13 AM

Closed by commit rPdc4d7f1f3e8d: Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]"… (authored by epriestley). · Explain WhyJan 16 2019, 9:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

relationship/

ManiphestTaskRelationship.php

9 lines

Diff 47710

View Options

src/applications/maniphest/relationship/ManiphestTaskRelationship.php

Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subjectClosedPublicActions