Page MenuHomePhabricator

Allow users to register with non-registration providers if they are invited to an instance
ClosedPublic

Authored by epriestley on Thu, Feb 7, 2:04 AM.

Details

Summary

Depends on D20117. Fixes T10071. When you're sent an email invitation, it's intended to allow you to register an account even if you otherwise could not (see D11737).

Some time between D11737 and today, this stopped working (or perhaps it never worked and I got things wrong in D11737). I think this actually ended up not mattering for us, given the way Phacility auth was ultimately built.

This feature generally seems reasonable, though, and probably should work. Make it work in the "password" and "oauth" cases, at least. This may still not work for LDAP, but testing that is nontrivial.

Test Plan
  • Enabled only passwords, turned off registration, sent an invite, registered with a password.
  • Enabled only Google OAuth, turned off registration, sent an invite, registered with Google OAuth.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Feb 7, 2:04 AM
epriestley requested review of this revision.Thu, Feb 7, 2:05 AM
amckinley accepted this revision.Thu, Feb 7, 8:35 PM
This revision is now accepted and ready to land.Thu, Feb 7, 8:35 PM
This revision was automatically updated to reflect the committed changes.