Page MenuHomePhabricator

Allow users to register with non-registration providers if they are invited to an instance
ClosedPublic

Authored by epriestley on Feb 7 2019, 2:04 AM.
Tags
None
Referenced Files
F18085181: D20118.diff
Tue, Aug 5, 7:02 PM
F17970643: D20118.id.diff
Fri, Aug 1, 2:51 PM
F17946814: D20118.diff
Thu, Jul 31, 3:12 PM
F17940461: D20118.id48131.diff
Thu, Jul 31, 4:25 AM
F17815101: D20118.id48033.diff
Fri, Jul 25, 9:41 PM
F17769608: D20118.diff
Wed, Jul 23, 8:48 AM
Unknown Object (File)
Jun 30 2025, 7:59 AM
Unknown Object (File)
Jun 29 2025, 7:20 AM
Subscribers
None

Details

Summary

Depends on D20117. Fixes T10071. When you're sent an email invitation, it's intended to allow you to register an account even if you otherwise could not (see D11737).

Some time between D11737 and today, this stopped working (or perhaps it never worked and I got things wrong in D11737). I think this actually ended up not mattering for us, given the way Phacility auth was ultimately built.

This feature generally seems reasonable, though, and probably should work. Make it work in the "password" and "oauth" cases, at least. This may still not work for LDAP, but testing that is nontrivial.

Test Plan
  • Enabled only passwords, turned off registration, sent an invite, registered with a password.
  • Enabled only Google OAuth, turned off registration, sent an invite, registered with Google OAuth.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable