Page MenuHomePhabricator

Allow users to add "ProfileMenu" items on mobile
ClosedPublic

Authored by epriestley on Wed, Mar 27, 9:12 PM.

Details

Summary

Depends on D20337. Fixes T12167. Ref T13272. On this page ("Favorites > Edit Favorites > Personal", for example) the curtain actions aren't available on mobile.

Normally, curtains are built with Controller->newCurtainView(), which sets an ID on the action list, which populates the header button. This curtain is built directly because there's no Controller handy.

To fix the issue, just set an ID. This could probably be cleaner, but that's likely a much more involved change.

Test Plan

Edited my favorites, narrowed the window, saw an "Actions" button.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Mar 27, 9:12 PM
epriestley requested review of this revision.Wed, Mar 27, 9:14 PM
epriestley added inline comments.Wed, Mar 27, 9:14 PM
src/applications/search/engine/PhabricatorProfileMenuEngine.php
920–921

(This and the other thing below are unused.)

amckinley accepted this revision.Wed, Mar 27, 9:34 PM
This revision is now accepted and ready to land.Wed, Mar 27, 9:34 PM
This revision was automatically updated to reflect the committed changes.