Paths

Table of Contentst

Differential D16273

Use phutil functions to copy/move files
ClosedPublic
Actions

Authored by alexmv on Jul 11 2016, 10:45 PM.

Tags

None

Referenced Files

	F14074275: D16273.diff
	Thu, Nov 21, 5:36 AM

	Unknown Object (File)
	Tue, Nov 12, 2:57 AM

	Unknown Object (File)
	Sat, Nov 9, 2:09 PM

	Unknown Object (File)
	Sun, Nov 3, 9:48 AM

	Unknown Object (File)
	Mon, Oct 28, 8:33 PM

	Unknown Object (File)
	Oct 21 2024, 12:50 AM

	Unknown Object (File)
	Oct 18 2024, 9:33 PM

	Unknown Object (File)
	Oct 15 2024, 10:15 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC8f69a5c378c3: Use phutil functions to copy/move files

Summary

The cp and mv commands, when run from a Windows
environment, error out. Use library functions from Filesystem
for cross-platform compatibility.

Test Plan

Ran arc lint with auto-fix lint errors on both Linux and
Windows.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alexmv updated this revision to Diff 39145.Jul 11 2016, 10:45 PM

alexmv retitled this revision from to Provide windows command-line equivalents for `cp` and `mv` commands.

alexmv updated this object.

alexmv edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 11 2016, 10:45 PM

Herald added a subscriber: epriestley. · View Herald Transcript

These should go in Filesystem in libphutil, as copyFile($src, $dst) and something like overwriteFile($src, $dst), and have unit tests so they survive the coming apocalypse in T8298 / D15675.

This revision now requires changes to proceed.Jul 11 2016, 11:23 PM

Use new libphutil functions.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 12 2016, 12:19 AM

alexmv retitled this revision from Provide windows command-line equivalents for `cp` and `mv` commands to Use phutil functions to copy/move files.Jul 12 2016, 12:20 AM

alexmv updated this object.

alexmv edited edge metadata.

epriestley accepted this revision.Jul 12 2016, 1:26 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 12 2016, 1:26 PM

Thanks! Looks like you're already in Blessed Committers. I added you to Community for good measure.

alexmv mentioned this in rPHU2d457275bea6: Add a method to copy files, preserving attributes.Jul 12 2016, 5:20 PM

Closed by commit rARC8f69a5c378c3: Use phutil functions to copy/move files (authored by alexmv, committed by alexmv). · Explain WhyJul 12 2016, 5:22 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9956: Arcanist failed patch lint on windows (because "cp" does not exist).Oct 2 2018, 12:59 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

ArcanistLintPatcher.php

7 lines

Diff 39155

src/lint/ArcanistLintPatcher.php

Loading...