Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 3:50 AM
Unknown Object (File)
Thu, Nov 21, 12:23 PM
Unknown Object (File)
Wed, Nov 20, 8:38 AM
Unknown Object (File)
Fri, Nov 15, 8:00 PM
Unknown Object (File)
Mon, Nov 11, 6:30 PM
Unknown Object (File)
Fri, Nov 8, 1:58 AM
Unknown Object (File)
Wed, Oct 30, 6:42 AM
Unknown Object (File)
Oct 22 2024, 9:02 AM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable