Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
F14829690: D20196.id.diff
Wed, Jan 29, 5:31 PM
Unknown Object (File)
Sat, Jan 25, 3:53 AM
Unknown Object (File)
Sat, Jan 25, 3:52 AM
Unknown Object (File)
Sat, Jan 25, 3:52 AM
Unknown Object (File)
Fri, Jan 24, 4:12 PM
Unknown Object (File)
Tue, Jan 21, 9:34 PM
Unknown Object (File)
Tue, Jan 21, 12:47 PM
Unknown Object (File)
Sat, Jan 18, 10:53 PM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable