Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
F14431439: D20196.id48228.diff
Wed, Dec 25, 6:30 PM
Unknown Object (File)
Sun, Dec 22, 4:37 PM
Unknown Object (File)
Sun, Dec 22, 1:57 AM
Unknown Object (File)
Fri, Dec 20, 3:00 PM
Unknown Object (File)
Sun, Dec 15, 4:47 PM
Unknown Object (File)
Mon, Dec 9, 4:50 PM
Unknown Object (File)
Fri, Dec 6, 8:27 AM
Unknown Object (File)
Wed, Dec 4, 4:17 PM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable