Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
F19930471: D20196.diff
Thu, Apr 9, 1:52 AM
F19926699: D20196.id48228.diff
Tue, Apr 7, 5:50 PM
F19535097: D20196.id48228.diff
Jan 21 2026, 4:16 AM
F19082919: D20196.id48228.diff
Dec 2 2025, 12:27 PM
F19039775: D20196.diff
Nov 26 2025, 9:44 AM
F18985038: D20196.id48223.diff
Nov 17 2025, 12:51 PM
F18876793: D20196.id.diff
Nov 6 2025, 3:40 AM
F18873883: D20196.id48228.diff
Nov 5 2025, 11:56 AM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable