Page MenuHomePhabricator

Audit not Triggered Sometimes in Owners/Packages Application
Closed, InvalidPublic

Description

After I upgraded my install to the latest stable code base in the weekend, I found the owner audit is not triggered correctly sometimes. Pls see the image below:

2016-05-23 17:42:33屏幕截图.png (251×1 px, 49 KB)

The icon/status of the 2 commits in the middle shows "Audit Not Required", though they were committed to the same repo by the same user. In the right side of the image we can see the owner package does appear as auditors.
I believe this should be related to my code update. Before the update, my code is from the stable code at the end of April. I received the audit request email as the package owner for all the 4 commits in the images, which I never received before the update. I checked phd log and there is nothing around the commit time.

Event Timeline

Please follow all the steps in Contributing Bug Reports. Specifically we need to know how to reproduce the issue locally.

In T11012#176668, @chad wrote:

Please follow all the steps in Contributing Bug Reports. Specifically we need to know how to reproduce the issue locally.

I have not found a concrete way to reproduce it. Sometimes the status is correct and sometimes it's not and I can not find any difference on those commits yet.

In T11012#176731, @chad wrote:

This may also be T11015.

It seems different. All my paths in my package are root paths of the repo like this:

2016-05-24 10:04:57屏幕截图.png (143×229 px, 6 KB)

In this same packages, just some commits are good and some are not.

I have not found a concrete way to reproduce it. Sometimes the status is correct and sometimes it's not and I can not find any difference on those commits yet.

We require reproduction steps on all bug reports, this way we know we're fixing your actual bug, and have a means to test and verify any fix. As Owners was recently overhauled with many new features, it's hard to identify what case we may have missed in testing.

In T11012#176923, @chad wrote:

We require reproduction steps on all bug reports, this way we know we're fixing your actual bug, and have a means to test and verify any fix. As Owners was recently overhauled with many new features, it's hard to identify what case we may have missed in testing.

I understand that. Will try to find reproduce steps.

I just looked the description in 74e117ae41dd.

Made a commit to a file which was part of a package but which I owned (so it does not trigger auditing).

Does the owner's commit not trigger audit now? I believe it was not the case before. I used to add several owners in the packages so that they can audit the commits from each other.
The user in the image in description of this task is one of the owners of the package. So still somehow the change from the owner triggers audit sometimes it doesn't.

eadler added a project: Restricted Project.Sep 15 2016, 6:10 PM
epriestley closed this task as Invalid.EditedJun 20 2019, 5:43 PM
epriestley added a subscriber: epriestley.

This is very old and it doesn't look like we ever found a working set of reproduction steps.