Page MenuHomePhabricator
Create Task
Maniphest T10747

Import and export ICS from Calendar
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
epriestley
Apr 7 2016, 9:44 PM
Tags
Referenced Files
F1890560: Screen Shot 2016-10-30 at 8.41.45 AM.png
Oct 30 2016, 3:45 PM
F1889682: Screen Shot 2016-10-28 at 3.50.51 PM.png
Oct 28 2016, 10:51 PM
F1832249: Screen Shot 2016-09-15 at 6.53.08 AM.png
Sep 15 2016, 1:58 PM
Subscribers
20after4
adam93
eadler
epriestley
ftdysa
hach-que
jayvdb
View All 9 Subscribers
Tokens
"Party Time" token, awarded by ftdysa."Mountain of Wealth" token, awarded by jayvdb."Mountain of Wealth" token, awarded by hach-que."Haypence" token, awarded by chad.

Description

It is a thing for events:

Excellent news: we can make events play custom sounds from arbitrary URLs! But will clients respect them? I can only hope.

Done:

  • SearchEngine / view all for import logs.
  • Delete all events from a source.
  • ICS errors probably throw instead of hitting the log?
  • Drag-and-droping an ICS file should import it.
  • Silence mail/feed for imports.
  • Show that imported events were imported on detail screen.
    • Link back to source.
    • Better messaging for explaining why you can't edit them?
  • Engine properties on import details.
  • When stubs/instances (can instances be generated?) are generated from an imported event, carry over the import source.
  • URL-based ICS imports.
  • Reload imports action.
  • Missing (int) cast on interval/COUNT.
  • Actually support COUNT.
  • Triggers for periodic imports (URL/Google).
  • Import attendees.
  • Try that GMail header stuff from @20after4.
  • Export host/organizer.

Still to be done:

  • Rules for collapsing duplicate instances of imported events for a viewer while querying, so they don't all show up on views.

Revisions and Commits

rPHU libphutil
D16767rPHUf62a265bad60 Fix an issue importing instantaneous events
D16761rPHUdaeaed6bfbc3 Parse (and discard) VALARM sections in ICS files
D16760rPHUef96bb56fc2b When importing ICS events, also import attendees
D16748rPHU6d6308803540 Fix import casts for RRULE "INTERVAL" and "COUNT" properties
D16729rPHUf275bb3a363d Fix some minor parsing bugs in ICS parser
D16715rPHU6db57365a28b Import RRULEs when parsing Calendar events
D16698rPHU72a4c65ec945 Fix some libphutil Calendar document bugs
D16678rPHU48fb6fac0232 Add support for exporting RECURRENCE-ID in ICS events
D16653rPHU5a9e3ef1bfe0 Allow DateTime objects to be serialized and deserialized
D16648rPHU65eed1be889e Support RRULE export in ICS from libphutil
D16637rPHU4b12a4f7a31a Implement RRULE FREQ=WEEKLY tests and BYSETPOS with WEEKLY
D16634rPHU68bb2c62181d Implement RFC5545 WEEKLY RRULE tests
D16633rPHU9bf1784ca265 Add most RFC5545 tests for RRULEs
D16631rPHUb077cfaf1b07 Add SECONDLY tests to RRULE code
D16630rPHU1024f03f68e8 Support BYSETPOS for RRULE events with FREQ=MINUTELY
D16629rPHU49f472ab8578 Support BYSETPOS for RRULE events with FREQ=HOURLY
D16628rPHU91cf945a2bdf Fix a TERRIBLE RRULE issue with INTERVAL interacting with ALL OTHER RULES and…
D16622rPHUf6424183c50e Add RRULE support for SETPOS with FREQ=DAILY
D16619rPHU83e9aaa17832 Fix an RRULE bug with day cursors and skipped months
D16617rPHU1a5bbe5971cc Implement BYSETPOS for YEARLY and MONTHLY RRULES
D16616rPHU16cb15ae0c22 Add many working RRULE test cases
D16615rPHU50db12901a84 Fix an RRULE bug with MONTHLY INTERVALs larger than 12
D16614rPHU90b5670cd5e0 Implement RRULE support for BYDAY with relative offsets ("FREQ=YEARLY;BYDAY=…
D16613rPHU4e9a2288f527 Add some working RRULE unit tests
D16612rPHU9a923abf4e49 Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency…
D16611rPHU51a1ac172a35 Fix RRULE bugs with week numbers for leading and trailing partial weeks
D16610rPHU9db0dd4fe2fd Fix some RRULE bugs with BYWEEKNO
D16609rPHUa84b6f73a7dd Fix two RRULE bugs with YEARDAY
D16608rPHUa1254d047a55 Fix a RRULE issue with BYDAY and similar constraints in noninitial months
D16607rPHU03ca6a391f8e Fix a remaining `cursorYear` instead of `stateYear`
D16606rPHU4f0b4899b570 Fix an RRULE issue where BYMONTHDAY did not properly expand the month set
D16605rPHUe7ff546372db Fix an RRULE issue with month days at the end of the month
D16603rPHU5e5ae77b462b Validate various RRULE components and simplify logic slightly
D16599rPHU103f13c03f38 Rough cut of implementing some of RRULE behaviors
D16590rPHU1a0371a2247a Add initial support for complex recurring events
D16557rPHUfa6519f4cea1 Add "ORGANIZER" and "ATTENDEE" sections to ICS writer
D16552rPHUb398e48a8fc7 Support more ICS parameters and properties
D16551rPHU7c1fc80a54f0 Write basic ICS files from Phutil intermediate objects
D16548rPHUf241706ade25 Parse ICS datetimes and durations
D16521rPHUf8af794b2135 Make error handling for ICS parsing more robust
D16520rPHU0107c187b6d8 Add a very basic ICS syntax parser
rP Phabricator
D16772rPe1a9b7694517 Give organizers in ICS exports a dummy email address to placate Gmail
D16771rPd9c91f857cef Apply a TYPE_CREATE transaction when importing events to improve strings in…
D16770rP96b064b7e9b2 Properly import all-day events in Calendar
D16768rP1e488e92771a When importing events, delete events which have been removed on the other end
D16766rP1014a2771795 Document Calendar imports
D16759rP09775279a949 Support arbitary event invitees when importing events
D16752rP2d7f574b9d6d Allow Calendar imports to be configured with hourly or daily auto-updates
D16749rP48666839feb5 Support RRULE "COUNT" for recurring events
D16747rPf4a3887b6bdd Add an explicit "Reload Import" action to imports
D16730rP314dc30017d4 Add a URI-based ICS import source engine
D16728rPc3de8f8305a9 When generating Calendar event stubs, inherit import properties
D16727rPd860008b6a45 Make event detail view more user-friendly for imported events
D16726rP5039b9ca28e4 Add some descriptive properties when viewing a Calendar import
D16723rPcc0f0b386525 Don't publish feed stories or send mail about imported events
D16722rPf9f25c1e4d5b Allow users to drop .ics files on calendar views to import them
D16721rP67cb277bed6c When import fails because we can't parse an ICS file, show it nicely
D16720rPb47a42bf5583 Allow events from a particular import source to be bulk-deleted
D16719rP94a5a09d7544 Add a SearchEngine for Calendar import logs
D16716rP860809ae79b1 Reject high-frequency and out-of-range events during import
D16704rP3d985585937c Add import log messages to Calendar imports
D16703rPc2411e3dcc9c When viewing a Calendar import, show all the events it imported
D16702rP6e2a86470b47 Support disabling calendar imports
D16701rPced151e6f2e8 Use transactions when importing events in Calendar, and update existing events
D16699rP86a00ee4abd6 Make Calendar ICS imports sort of work in a crude, approximate way
D16696rP2ab07ed29bd9 Prepare for event imports in Calendar
D16681rPbc6e6c0500b7 Allow Calendar exports to be disabled
D16680rPff97ed219599 Document how to export Calendar events
D16679rP4819446fe511 Export recurring events and build ICS files for configured exports
D16676rPfa6a5a46ba57 Make more of the Calendar export workflow work
D16675rP49448a87c17c Rough in most of Calendar exports
D16670rP3164ff68db58 Convert Calendar Events to use RRULE frequency constants in various other places
D16668rP20f7de91ceb5 Drive calendar event queries through the RRULE engine
D16664rPd3fc1800f86a Migrate Calendar away from stored-epoch fields
D16663rPfae0ec9220a7 Use more CalendarDateTime and fewer epoch timestamps in Calendar
D16662rP37f35e9ecca6 Remove "viewerDateFrom" / "viewerDateTo" in favor of CalendarDateTime methods
D16661rPe042533375d3 Store "start", "end", and "until" event dates as CalendarDateTime objects
D16652rP0ce7eacaf1c1 Introduce Calendar "UTC Epoch" columns for query windowing
D16559rP3d6c3c2c45e8 Make .ics export less scary and attach .ics files to event mail
D16558rP96f800249b31 Export ORGANIZER and ATTENDEE sections in ".ics" files from Calendar
D16553rP47debbd57c85 Add an "Export as .ics" action to Calendar events

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley added a revision: D16678: Add support for exporting RECURRENCE-ID in ICS events.Oct 6 2016, 7:52 PM
epriestley added a revision: D16679: Export recurring events and build ICS files for configured exports.Oct 6 2016, 8:14 PM
epriestley added a commit: rPHU48fb6fac0232: Add support for exporting RECURRENCE-ID in ICS events.Oct 6 2016, 9:07 PM
epriestley added a commit: rP4819446fe511: Export recurring events and build ICS files for configured exports.
epriestley added a revision: D16680: Document how to export Calendar events.Oct 6 2016, 9:48 PM
ftdysa awarded a token.Oct 6 2016, 9:50 PM
epriestley added a revision: D16681: Allow Calendar exports to be disabled.Oct 6 2016, 10:01 PM
epriestley added a commit: rPff97ed219599: Document how to export Calendar events.Oct 6 2016, 10:33 PM
epriestley added a commit: rPbc6e6c0500b7: Allow Calendar exports to be disabled.
epriestley added a revision: D16696: Prepare for event imports in Calendar.Oct 12 2016, 4:48 PM
epriestley added a commit: rP2ab07ed29bd9: Prepare for event imports in Calendar.Oct 12 2016, 5:45 PM
epriestley added a revision: D16698: Fix some libphutil Calendar document bugs.Oct 12 2016, 8:43 PM
epriestley added a revision: D16699: Make Calendar ICS imports sort of work in a crude, approximate way.Oct 12 2016, 8:46 PM
epriestley added a commit: rPHU72a4c65ec945: Fix some libphutil Calendar document bugs.Oct 12 2016, 10:28 PM
epriestley added a commit: rP86a00ee4abd6: Make Calendar ICS imports sort of work in a crude, approximate way.
epriestley moved this task from Backlog to The Queue on the Prioritized board.Oct 13 2016, 2:20 PM
epriestley added a revision: D16701: Use transactions when importing events in Calendar, and update existing events.Oct 13 2016, 3:04 PM
epriestley added a revision: D16702: Support disabling calendar imports.Oct 13 2016, 3:33 PM
epriestley added a revision: D16703: When viewing a Calendar import, show all the events it imported.Oct 13 2016, 3:52 PM
epriestley added a commit: rPced151e6f2e8: Use transactions when importing events in Calendar, and update existing events.Oct 13 2016, 4:05 PM
epriestley added a commit: rP6e2a86470b47: Support disabling calendar imports.
epriestley added a commit: rPc2411e3dcc9c: When viewing a Calendar import, show all the events it imported.
epriestley added a revision: D16704: Add import log messages to Calendar imports.Oct 13 2016, 7:02 PM
epriestley added a commit: rP3d985585937c: Add import log messages to Calendar imports.Oct 14 2016, 2:57 PM
epriestley added a revision: D16715: Import RRULEs when parsing Calendar events.Oct 18 2016, 5:07 PM
epriestley added a revision: D16716: Reject high-frequency and out-of-range events during import.Oct 18 2016, 5:11 PM
epriestley added a commit: rPHU6db57365a28b: Import RRULEs when parsing Calendar events.Oct 18 2016, 5:48 PM
epriestley added a commit: rP860809ae79b1: Reject high-frequency and out-of-range events during import.
epriestley updated the task description. (Show Details)Oct 18 2016, 6:00 PM
epriestley added a revision: D16719: Add a SearchEngine for Calendar import logs.Oct 18 2016, 8:26 PM
epriestley added a revision: D16720: Allow events from a particular import source to be bulk-deleted.Oct 18 2016, 8:40 PM
epriestley updated the task description. (Show Details)Oct 18 2016, 8:41 PM
epriestley added a revision: D16721: When import fails because we can't parse an ICS file, show it nicely.Oct 18 2016, 8:54 PM
epriestley updated the task description. (Show Details)Oct 18 2016, 8:56 PM
epriestley added a revision: D16722: Allow users to drop .ics files on calendar views to import them.Oct 18 2016, 9:30 PM
epriestley updated the task description. (Show Details)Oct 18 2016, 9:31 PM
epriestley added a revision: D16723: Don't publish feed stories or send mail about imported events.Oct 18 2016, 9:36 PM
epriestley updated the task description. (Show Details)Oct 18 2016, 9:36 PM
epriestley added a commit: rP94a5a09d7544: Add a SearchEngine for Calendar import logs.Oct 18 2016, 10:23 PM
epriestley added a commit: rPb47a42bf5583: Allow events from a particular import source to be bulk-deleted.
epriestley added a commit: rP67cb277bed6c: When import fails because we can't parse an ICS file, show it nicely.
epriestley added a commit: rPf9f25c1e4d5b: Allow users to drop .ics files on calendar views to import them.Oct 18 2016, 10:26 PM
epriestley added a commit: rPcc0f0b386525: Don't publish feed stories or send mail about imported events.Oct 18 2016, 11:01 PM
epriestley added a revision: D16726: Add some descriptive properties when viewing a Calendar import.Oct 19 2016, 3:35 PM
epriestley added a revision: D16727: Make event detail view more user-friendly for imported events.Oct 19 2016, 4:02 PM
epriestley updated the task description. (Show Details)Oct 19 2016, 4:03 PM
epriestley updated the task description. (Show Details)Oct 19 2016, 4:20 PM
epriestley added a revision: D16728: When generating Calendar event stubs, inherit import properties.Oct 19 2016, 4:20 PM
epriestley added a revision: D16729: Fix some minor parsing bugs in ICS parser.Oct 19 2016, 4:55 PM
epriestley added a revision: D16730: Add a URI-based ICS import source engine.
epriestley added a commit: rP5039b9ca28e4: Add some descriptive properties when viewing a Calendar import.Oct 19 2016, 4:58 PM
epriestley added a commit: rPd860008b6a45: Make event detail view more user-friendly for imported events.
epriestley added a commit: rPc3de8f8305a9: When generating Calendar event stubs, inherit import properties.
epriestley added a commit: rPHUf275bb3a363d: Fix some minor parsing bugs in ICS parser.Oct 19 2016, 5:55 PM
epriestley added a commit: rP314dc30017d4: Add a URI-based ICS import source engine.
epriestley updated the task description. (Show Details)Oct 25 2016, 4:08 PM
epriestley added a revision: D16747: Add an explicit "Reload Import" action to imports.Oct 25 2016, 5:02 PM
epriestley updated the task description. (Show Details)Oct 25 2016, 5:10 PM
epriestley added a revision: D16748: Fix import casts for RRULE "INTERVAL" and "COUNT" properties.Oct 25 2016, 5:18 PM
epriestley added a revision: D16749: Support RRULE "COUNT" for recurring events.Oct 25 2016, 5:32 PM
epriestley added a commit: rPf4a3887b6bdd: Add an explicit "Reload Import" action to imports.Oct 25 2016, 5:33 PM
epriestley added a commit: rP48666839feb5: Support RRULE "COUNT" for recurring events.Oct 25 2016, 5:38 PM
epriestley added a commit: rPHU6d6308803540: Fix import casts for RRULE "INTERVAL" and "COUNT" properties.
epriestley updated the task description. (Show Details)Oct 25 2016, 6:27 PM
epriestley added a revision: D16752: Allow Calendar imports to be configured with hourly or daily auto-updates.Oct 26 2016, 6:51 PM
epriestley updated the task description. (Show Details)Oct 26 2016, 6:52 PM
epriestley added a commit: rP2d7f574b9d6d: Allow Calendar imports to be configured with hourly or daily auto-updates.Oct 26 2016, 7:19 PM
adam93 added a subscriber: adam93.Oct 27 2016, 2:04 PM
epriestley added a revision: D16759: Support arbitary event invitees when importing events.Oct 27 2016, 6:32 PM
epriestley added a revision: D16760: When importing ICS events, also import attendees.
epriestley added a revision: D16761: Parse (and discard) VALARM sections in ICS files.Oct 27 2016, 8:08 PM
epriestley added a commit: rPHUef96bb56fc2b: When importing ICS events, also import attendees.Oct 27 2016, 8:27 PM
epriestley added a commit: rPHUdaeaed6bfbc3: Parse (and discard) VALARM sections in ICS files.
epriestley added a commit: rP09775279a949: Support arbitary event invitees when importing events.
epriestley updated the task description. (Show Details)Oct 27 2016, 9:34 PM
epriestley added a revision: D16766: Document Calendar imports.Oct 28 2016, 10:15 PM
epriestley added a revision: D16767: Fix an issue importing instantaneous events.Oct 28 2016, 10:44 PM
epriestley added a commit: rPHUf62a265bad60: Fix an issue importing instantaneous events.Oct 28 2016, 10:45 PM
epriestley added a comment.Oct 28 2016, 10:51 PM

OK I imported some real great events:

Screen Shot 2016-10-28 at 3.50.51 PM.png (972×1 px, 138 KB)

No one can see them but they're great.

epriestley added a revision: D16768: When importing events, delete events which have been removed on the other end.Oct 28 2016, 11:00 PM
epriestley added a commit: rP1014a2771795: Document Calendar imports.Oct 29 2016, 1:14 AM
epriestley added a commit: rP1e488e92771a: When importing events, delete events which have been removed on the other end.
epriestley added a revision: D16770: Properly import all-day events in Calendar.Oct 30 2016, 3:14 PM
epriestley added a revision: D16771: Apply a TYPE_CREATE transaction when importing events to improve strings in timeline.Oct 30 2016, 3:22 PM
epriestley added a comment.Oct 30 2016, 3:45 PM

The Gmail/ICS integration seems to actually work OK in practice, here's an event from this install working (modulo some stuff like us not exporting a host/organizer yet):

Screen Shot 2016-10-30 at 8.41.45 AM.png (1×1 px, 197 KB)

I think it doesn't show this UI when it thinks the sender is "bad", for some definition of "bad". In the case of my non-working test cases, they came from a complex series of mailbox aliases because my mail test setup does a lot of weird magic, so I think we're OK on the header stuff as-is. We can revisit this if users are having issues in the wild, but seems to be working OK for me.

epriestley updated the task description. (Show Details)Oct 30 2016, 3:45 PM
epriestley added a revision: D16772: Give organizers in ICS exports a dummy email address to placate Gmail.Oct 30 2016, 4:13 PM
epriestley added a commit: rP96b064b7e9b2: Properly import all-day events in Calendar.Oct 30 2016, 4:20 PM
epriestley added a commit: rPd9c91f857cef: Apply a TYPE_CREATE transaction when importing events to improve strings in….
epriestley added a commit: rPe1a9b7694517: Give organizers in ICS exports a dummy email address to placate Gmail.
epriestley updated the task description. (Show Details)Oct 30 2016, 4:21 PM
epriestley added a comment.Oct 30 2016, 4:29 PM

(Google API integration is covered by T2334 -- you can already interact with Google Calendar via ICS files, but that will add support for using the API instead.)

epriestley added a comment.Oct 30 2016, 5:43 PM

I'm going to file the duplicate import thing as a separate task since it probably won't come up for a while and close this out.

epriestley closed this task as Resolved.Oct 30 2016, 5:45 PM

Duplicate thing filed in T11800.

epriestley mentioned this in T11801: Calendar: ICS Import Errata.Oct 30 2016, 5:56 PM
timor added a subscriber: timor.Dec 20 2016, 3:58 PM
timor removed a subscriber: timor.
Phabricator · Built by Phacility